You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pekko.apache.org by nv...@apache.org on 2023/03/07 09:37:03 UTC
[incubator-pekko-management] branch main updated: Fix warnings (#41)
This is an automated email from the ASF dual-hosted git repository.
nvollmar pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-pekko-management.git
The following commit(s) were added to refs/heads/main by this push:
new 293f207 Fix warnings (#41)
293f207 is described below
commit 293f207b0b12ec57ccd8d2c02ef96ce127971ad7
Author: Nicolas Vollmar <nv...@gmail.com>
AuthorDate: Tue Mar 7 10:36:57 2023 +0100
Fix warnings (#41)
---
.../pekko/discovery/awsapi/ecs/AsyncEcsTaskSetDiscovery.scala | 2 +-
.../apache/pekko/discovery/consul/ConsulServiceDiscovery.scala | 2 +-
.../cluster/scaladsl/ClusterHttpManagementRoutes.scala | 8 ++++----
.../org/apache/pekko/management/scaladsl/PekkoManagement.scala | 10 +++++-----
4 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/discovery-aws-api-async/src/main/scala/org/apache/pekko/discovery/awsapi/ecs/AsyncEcsTaskSetDiscovery.scala b/discovery-aws-api-async/src/main/scala/org/apache/pekko/discovery/awsapi/ecs/AsyncEcsTaskSetDiscovery.scala
index 8dbdac1..a6f8f50 100644
--- a/discovery-aws-api-async/src/main/scala/org/apache/pekko/discovery/awsapi/ecs/AsyncEcsTaskSetDiscovery.scala
+++ b/discovery-aws-api-async/src/main/scala/org/apache/pekko/discovery/awsapi/ecs/AsyncEcsTaskSetDiscovery.scala
@@ -123,7 +123,7 @@ object AsyncEcsTaskSetDiscovery {
case HttpResponse(StatusCodes.OK, _, entity, _) =>
val metadata = Unmarshal(entity).to[TaskMetadata].map(Option(_))
metadata
- case resp @ HttpResponse(_, _, _, _) =>
+ case resp: HttpResponse =>
resp.discardEntityBytes()
Future.successful(None)
}
diff --git a/discovery-consul/src/main/scala/org/apache/pekko/discovery/consul/ConsulServiceDiscovery.scala b/discovery-consul/src/main/scala/org/apache/pekko/discovery/consul/ConsulServiceDiscovery.scala
index f713e9f..54fbf59 100644
--- a/discovery-consul/src/main/scala/org/apache/pekko/discovery/consul/ConsulServiceDiscovery.scala
+++ b/discovery-consul/src/main/scala/org/apache/pekko/discovery/consul/ConsulServiceDiscovery.scala
@@ -107,7 +107,7 @@ object ConsulServiceDiscovery {
final case class ConsulResponseFutureCallback[T]() extends ConsulResponseCallback[T] {
- private val promise = Promise[ConsulResponse[T]]
+ private val promise = Promise[ConsulResponse[T]]()
def fail(exception: Throwable) = promise.failure(exception)
diff --git a/management-cluster-http/src/main/scala/org/apache/pekko/management/cluster/scaladsl/ClusterHttpManagementRoutes.scala b/management-cluster-http/src/main/scala/org/apache/pekko/management/cluster/scaladsl/ClusterHttpManagementRoutes.scala
index 39dd05b..7ab2b8f 100644
--- a/management-cluster-http/src/main/scala/org/apache/pekko/management/cluster/scaladsl/ClusterHttpManagementRoutes.scala
+++ b/management-cluster-http/src/main/scala/org/apache/pekko/management/cluster/scaladsl/ClusterHttpManagementRoutes.scala
@@ -70,7 +70,7 @@ object ClusterHttpManagementRoutes extends ClusterHttpManagementJsonProtocol {
private def routePostMembers(cluster: Cluster): Route =
post {
- formField('address) { addressString =>
+ formField("address") { addressString =>
complete {
val address = AddressFromURIString(addressString)
cluster.join(address)
@@ -96,7 +96,7 @@ object ClusterHttpManagementRoutes extends ClusterHttpManagementJsonProtocol {
private def routePutMember(cluster: Cluster, member: Member) =
put {
- formField('operation) { operation =>
+ formField("operation") { operation =>
ClusterHttpManagementMemberOperation.fromString(operation) match {
case Some(Down) =>
cluster.down(member.uniqueAddress.address)
@@ -245,7 +245,7 @@ object ClusterHttpManagementRoutes extends ClusterHttpManagementJsonProtocol {
get {
extractExecutionContext { implicit executor =>
complete {
- implicit val timeout = Timeout(5.seconds)
+ implicit val timeout: Timeout = Timeout(5.seconds)
try {
ClusterSharding(cluster.system)
.shardRegion(shardRegionName)
@@ -297,7 +297,7 @@ object ClusterHttpManagementRoutes extends ClusterHttpManagementJsonProtocol {
private def routePutCluster(cluster: Cluster): Route = {
put {
- formField('operation) { operation =>
+ formField("operation") { operation =>
if (operation.toLowerCase == "prepare-for-full-shutdown") {
cluster.prepareForFullClusterShutdown()
complete(ClusterHttpManagementMessage(s"Preparing for full cluster shutdown"))
diff --git a/management/src/main/scala/org/apache/pekko/management/scaladsl/PekkoManagement.scala b/management/src/main/scala/org/apache/pekko/management/scaladsl/PekkoManagement.scala
index 12a66db..4013460 100644
--- a/management/src/main/scala/org/apache/pekko/management/scaladsl/PekkoManagement.scala
+++ b/management/src/main/scala/org/apache/pekko/management/scaladsl/PekkoManagement.scala
@@ -239,25 +239,25 @@ final class PekkoManagement(implicit private[pekko] val system: ExtendedActorSys
.recoverWith {
case _ => dynamicAccess.createInstanceFor[ExtensionIdProvider](fqcn, Nil)
}
- .recoverWith {
+ .recoverWith[ExtensionIdProvider] {
case _: ClassCastException | _: NoSuchMethodException =>
dynamicAccess.createInstanceFor[ExtensionIdProvider](fqcn, (classOf[ExtendedActorSystem], system) :: Nil)
}
- .recoverWith {
+ .recoverWith[AnyRef] {
case _: ClassCastException | _: NoSuchMethodException =>
dynamicAccess.createInstanceFor[ManagementRouteProvider](fqcn, Nil)
}
- .recoverWith {
+ .recoverWith[AnyRef] {
case _: ClassCastException | _: NoSuchMethodException =>
dynamicAccess.createInstanceFor[ManagementRouteProvider](
fqcn,
(classOf[ExtendedActorSystem], system) :: Nil)
}
- .recoverWith {
+ .recoverWith[AnyRef] {
case _: ClassCastException | _: NoSuchMethodException =>
dynamicAccess.createInstanceFor[javadsl.ManagementRouteProvider](fqcn, Nil)
}
- .recoverWith {
+ .recoverWith[AnyRef] {
case _: ClassCastException | _: NoSuchMethodException =>
dynamicAccess
.createInstanceFor[javadsl.ManagementRouteProvider](fqcn, (classOf[ExtendedActorSystem], system) :: Nil)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pekko.apache.org
For additional commands, e-mail: commits-help@pekko.apache.org