You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/05/03 11:29:47 UTC
Review Request: fix for CLOUDSTACK-2146: scaling up system vm failed.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10914/
-----------------------------------------------------------
Review request for cloudstack and Abhinandan Prateek.
Description
-------
CLOUDSTACK-2146: system vm scaleup failed ;{ "scalevirtualmachineresponse" : {"errorcode":530,"cserrorcode":9999,"errortext":"Failed to scale vm"} }
System vms scaling up is successful but response generation failed so fixed by changing the response object.
This addresses bug CLOUDSTACK-2146.
Diffs
-----
api/src/com/cloud/vm/UserVmService.java c8ccb67
api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 4fc65c3
api/test/org/apache/cloudstack/api/command/test/ScaleVMCmdTest.java 301fa02
server/src/com/cloud/vm/UserVmManagerImpl.java 6179948
server/test/com/cloud/vm/MockUserVmManagerImpl.java 22bbbe8
Diff: https://reviews.apache.org/r/10914/diff/
Testing
-------
Tested scaling up both user vms and system vms.
Thanks,
Harikrishna Patnala
Re: Review Request: fix for CLOUDSTACK-2146: scaling up system vm failed.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10914/#review20142
-----------------------------------------------------------
Commit 38b4f84f1749f86ac058b25d86995fe54bc7fde6 in branch refs/heads/internallb from Abhinandan Prateek <ap...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=38b4f84 ]
CLOUDSTACK-2146: system vm scaleup failed ;{ "scalevirtualmachineresponse" : {"errorcode":530,"cserrorcode":9999,"errortext":"Failed to scale vm"} }
Only response generation for system vm scale up failed so fixed by changing the response object.
Signed-off-by: Abhinandan Prateek <ap...@apache.org>
- ASF Subversion and Git Services
On May 3, 2013, 9:40 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10914/
> -----------------------------------------------------------
>
> (Updated May 3, 2013, 9:40 a.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
> CLOUDSTACK-2146: system vm scaleup failed ;{ "scalevirtualmachineresponse" : {"errorcode":530,"cserrorcode":9999,"errortext":"Failed to scale vm"} }
>
> System vms scaling up is successful but response generation failed so fixed by changing the response object.
>
>
> This addresses bug CLOUDSTACK-2146.
>
>
> Diffs
> -----
>
> api/src/com/cloud/vm/UserVmService.java c8ccb67
> api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 4fc65c3
> api/test/org/apache/cloudstack/api/command/test/ScaleVMCmdTest.java 301fa02
> server/src/com/cloud/vm/UserVmManagerImpl.java 6179948
> server/test/com/cloud/vm/MockUserVmManagerImpl.java 22bbbe8
>
> Diff: https://reviews.apache.org/r/10914/diff/
>
>
> Testing
> -------
>
> Tested scaling up both user vms and system vms.
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: fix for CLOUDSTACK-2146: scaling up system vm failed.
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10914/#review20110
-----------------------------------------------------------
Ship it!
This is not the final fix but betterment over what was there and therefore I will mark it as ship it. For the final complete fix I have filed this ticket https://issues.apache.org/jira/browse/CLOUDSTACK-2321
- Abhinandan Prateek
On May 3, 2013, 9:40 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10914/
> -----------------------------------------------------------
>
> (Updated May 3, 2013, 9:40 a.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
> CLOUDSTACK-2146: system vm scaleup failed ;{ "scalevirtualmachineresponse" : {"errorcode":530,"cserrorcode":9999,"errortext":"Failed to scale vm"} }
>
> System vms scaling up is successful but response generation failed so fixed by changing the response object.
>
>
> This addresses bug CLOUDSTACK-2146.
>
>
> Diffs
> -----
>
> api/src/com/cloud/vm/UserVmService.java c8ccb67
> api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 4fc65c3
> api/test/org/apache/cloudstack/api/command/test/ScaleVMCmdTest.java 301fa02
> server/src/com/cloud/vm/UserVmManagerImpl.java 6179948
> server/test/com/cloud/vm/MockUserVmManagerImpl.java 22bbbe8
>
> Diff: https://reviews.apache.org/r/10914/diff/
>
>
> Testing
> -------
>
> Tested scaling up both user vms and system vms.
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: fix for CLOUDSTACK-2146: scaling up system vm failed.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10914/#review20112
-----------------------------------------------------------
Commit 38b4f84f1749f86ac058b25d86995fe54bc7fde6 in branch refs/heads/master from Abhinandan Prateek <ap...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=38b4f84 ]
CLOUDSTACK-2146: system vm scaleup failed ;{ "scalevirtualmachineresponse" : {"errorcode":530,"cserrorcode":9999,"errortext":"Failed to scale vm"} }
Only response generation for system vm scale up failed so fixed by changing the response object.
Signed-off-by: Abhinandan Prateek <ap...@apache.org>
- ASF Subversion and Git Services
On May 3, 2013, 9:40 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10914/
> -----------------------------------------------------------
>
> (Updated May 3, 2013, 9:40 a.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
> CLOUDSTACK-2146: system vm scaleup failed ;{ "scalevirtualmachineresponse" : {"errorcode":530,"cserrorcode":9999,"errortext":"Failed to scale vm"} }
>
> System vms scaling up is successful but response generation failed so fixed by changing the response object.
>
>
> This addresses bug CLOUDSTACK-2146.
>
>
> Diffs
> -----
>
> api/src/com/cloud/vm/UserVmService.java c8ccb67
> api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 4fc65c3
> api/test/org/apache/cloudstack/api/command/test/ScaleVMCmdTest.java 301fa02
> server/src/com/cloud/vm/UserVmManagerImpl.java 6179948
> server/test/com/cloud/vm/MockUserVmManagerImpl.java 22bbbe8
>
> Diff: https://reviews.apache.org/r/10914/diff/
>
>
> Testing
> -------
>
> Tested scaling up both user vms and system vms.
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: fix for CLOUDSTACK-2146: scaling up system vm failed.
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10914/
-----------------------------------------------------------
(Updated May 3, 2013, 9:40 a.m.)
Review request for cloudstack and Abhinandan Prateek.
Changes
-------
updated patch
Description
-------
CLOUDSTACK-2146: system vm scaleup failed ;{ "scalevirtualmachineresponse" : {"errorcode":530,"cserrorcode":9999,"errortext":"Failed to scale vm"} }
System vms scaling up is successful but response generation failed so fixed by changing the response object.
This addresses bug CLOUDSTACK-2146.
Diffs (updated)
-----
api/src/com/cloud/vm/UserVmService.java c8ccb67
api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 4fc65c3
api/test/org/apache/cloudstack/api/command/test/ScaleVMCmdTest.java 301fa02
server/src/com/cloud/vm/UserVmManagerImpl.java 6179948
server/test/com/cloud/vm/MockUserVmManagerImpl.java 22bbbe8
Diff: https://reviews.apache.org/r/10914/diff/
Testing
-------
Tested scaling up both user vms and system vms.
Thanks,
Harikrishna Patnala