You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/11 20:09:49 UTC
[GitHub] [cloudstack] andrijapanicsb opened a new pull request #3961: Reduce
nonsence value for capacity.skipcounting.hours
andrijapanicsb opened a new pull request #3961: Reduce nonsence value for capacity.skipcounting.hours
URL: https://github.com/apache/cloudstack/pull/3961
When doing rapid host maintenance one after the other, and when previously stopping huge number of VMs on a single host (i.e. all VMs on that host are stopped) - no new VMs can be started on this empty host since those VMs' capacities are reserved for 3600sec - so when doing maintenance of another host, VMs can't be migrated to this empty host.
Not sure who and why has this setting default value to such high value (1h) (doesn't make sense)
Not to mentioned the name of the setting is wrong, should be "capacity.skipcounting.second"
Another PR to rename this setting is most welcome @nvazquez @DaanHoogland @weizhouapache
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3961: Reduce nonsence
value for capacity.skipcounting.hours
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3961: Reduce nonsence value for capacity.skipcounting.hours
URL: https://github.com/apache/cloudstack/pull/3961#issuecomment-598200197
👎 no config key should be added in this way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3961: Reduce
nonsence value for capacity.skipcounting.hours
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3961: Reduce nonsence value for capacity.skipcounting.hours
URL: https://github.com/apache/cloudstack/pull/3961#issuecomment-598102799
> @weizhouapache if it doesn't exists in config key form, I guess that's OK? How about #3960
@andrijapanicsb I think these are different.
max.retries was added in 4.13->4.14, since 4.14 is not released yet, we do not need extra sql change if we rename it.
capacity.skipcounting.hours was added quite long ago (before 2013), so extra sql change is needed if we rename it. we have two options (1) rename it in sql (2) delete it in sql and add new ConfigKey.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb closed pull request #3961: Reduce
nonsence value for capacity.skipcounting.hours
Posted by GitBox <gi...@apache.org>.
andrijapanicsb closed pull request #3961: Reduce nonsence value for capacity.skipcounting.hours
URL: https://github.com/apache/cloudstack/pull/3961
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3961: Reduce
nonsence value for capacity.skipcounting.hours
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3961: Reduce nonsence value for capacity.skipcounting.hours
URL: https://github.com/apache/cloudstack/pull/3961#issuecomment-598110622
sorry @weizhouapache my bad (read something wrong...) - so whatever works for you - if the config key-based addition of this one is not there, yes please (don't expect me to know how to add config key :) - so feel free to edit my PR please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3961: Reduce
nonsence value for capacity.skipcounting.hours
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3961: Reduce nonsence value for capacity.skipcounting.hours
URL: https://github.com/apache/cloudstack/pull/3961#issuecomment-598113591
@weizhouapache I was expecting a PR from @nvazquez to rename this setting to xxx..seconds (not hours) - that's what I was mentioning (linked to wrong PR)... so we can put everything in a single PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3961: Reduce
nonsence value for capacity.skipcounting.hours
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3961: Reduce nonsence value for capacity.skipcounting.hours
URL: https://github.com/apache/cloudstack/pull/3961#issuecomment-598059227
@andrijapanicsb is is better to remove this configuration from database and add new config via Configkey ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3961: Reduce
nonsence value for capacity.skipcounting.hours
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3961: Reduce nonsence value for capacity.skipcounting.hours
URL: https://github.com/apache/cloudstack/pull/3961#issuecomment-598100546
@weizhouapache if it doesn't exists in config key form, I guess that's OK? How about #3960
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3961: Reduce
nonsence value for capacity.skipcounting.hours
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3961: Reduce nonsence value for capacity.skipcounting.hours
URL: https://github.com/apache/cloudstack/pull/3961#issuecomment-598693021
Closed due to not being able to accomplish the full goal - as discussed in #3942
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services