You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/09/09 10:25:18 UTC

[GitHub] [james-project] vttranlina opened a new pull request #652: JAMES-3647 Adopt eclipse-temurin:11-jre-focal docker image

vttranlina opened a new pull request #652:
URL: https://github.com/apache/james-project/pull/652


   ref https://github.com/apache/james-project/pull/647


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on a change in pull request #652: JAMES-3647 Adopt eclipse-temurin:11-jre-focal docker image

Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #652:
URL: https://github.com/apache/james-project/pull/652#discussion_r705939398



##########
File path: src/site/Dockerfile
##########
@@ -2,7 +2,7 @@
 #
 # VERSION	1.0
 
-FROM adoptopenjdk:11-jdk-hotspot
+FROM eclipse-temurin:11-jre-focal

Review comment:
       Can't we use `eclipse-temurin:11-jdk-focal` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on a change in pull request #652: JAMES-3647 Adopt eclipse-temurin:11-jre-focal docker image

Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #652:
URL: https://github.com/apache/james-project/pull/652#discussion_r705221628



##########
File path: src/site/Dockerfile
##########
@@ -2,7 +2,7 @@
 #
 # VERSION	1.0
 
-FROM adoptopenjdk:11-jdk-hotspot
+FROM eclipse-temurin:11-jre-focal

Review comment:
       We IMO need a JDK to run maven?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] vttranlina commented on a change in pull request #652: JAMES-3647 Adopt eclipse-temurin:11-jre-focal docker image

Posted by GitBox <gi...@apache.org>.
vttranlina commented on a change in pull request #652:
URL: https://github.com/apache/james-project/pull/652#discussion_r706067976



##########
File path: src/site/Dockerfile
##########
@@ -2,7 +2,7 @@
 #
 # VERSION	1.0
 
-FROM adoptopenjdk:11-jdk-hotspot
+FROM eclipse-temurin:11-jre-focal

Review comment:
       updated `eclipse-temurin:11-jdk-focal` 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa merged pull request #652: JAMES-3647 Adopt eclipse-temurin:11-jre-focal docker image

Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #652:
URL: https://github.com/apache/james-project/pull/652


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] vttranlina commented on a change in pull request #652: JAMES-3647 Adopt eclipse-temurin:11-jre-focal docker image

Posted by GitBox <gi...@apache.org>.
vttranlina commented on a change in pull request #652:
URL: https://github.com/apache/james-project/pull/652#discussion_r705914571



##########
File path: src/site/Dockerfile
##########
@@ -2,7 +2,7 @@
 #
 # VERSION	1.0
 
-FROM adoptopenjdk:11-jdk-hotspot
+FROM eclipse-temurin:11-jre-focal

Review comment:
       ```suggestion
   FROM adoptopenjdk:11-jdk-hotspot
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] Arsnael commented on a change in pull request #652: JAMES-3647 Adopt eclipse-temurin:11-jre-focal docker image

Posted by GitBox <gi...@apache.org>.
Arsnael commented on a change in pull request #652:
URL: https://github.com/apache/james-project/pull/652#discussion_r705865894



##########
File path: examples/custom-james-assembly/pom.xml
##########
@@ -54,7 +54,7 @@
                 <version>2.7.1</version>
                 <configuration>
                     <from>
-                        <image>adoptopenjdk:11-jdk-hotspot</image>
+                        <image>eclipse-temurin:11-jre-focal</image>

Review comment:
       jdk too here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] vttranlina commented on a change in pull request #652: JAMES-3647 Adopt eclipse-temurin:11-jre-focal docker image

Posted by GitBox <gi...@apache.org>.
vttranlina commented on a change in pull request #652:
URL: https://github.com/apache/james-project/pull/652#discussion_r705914430



##########
File path: src/site/Dockerfile
##########
@@ -2,7 +2,7 @@
 #
 # VERSION	1.0
 
-FROM adoptopenjdk:11-jdk-hotspot
+FROM eclipse-temurin:11-jre-focal

Review comment:
       ![Screenshot from 2021-09-10 12-53-04](https://user-images.githubusercontent.com/81145350/132806655-f8b07af7-027d-4609-9307-a8d4299bdbb2.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] vttranlina commented on a change in pull request #652: JAMES-3647 Adopt eclipse-temurin:11-jre-focal docker image

Posted by GitBox <gi...@apache.org>.
vttranlina commented on a change in pull request #652:
URL: https://github.com/apache/james-project/pull/652#discussion_r705913824



##########
File path: src/site/Dockerfile
##########
@@ -2,7 +2,7 @@
 #
 # VERSION	1.0
 
-FROM adoptopenjdk:11-jdk-hotspot
+FROM eclipse-temurin:11-jre-focal

Review comment:
       You're right, 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on a change in pull request #652: JAMES-3647 Adopt eclipse-temurin:11-jre-focal docker image

Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #652:
URL: https://github.com/apache/james-project/pull/652#discussion_r705869392



##########
File path: examples/custom-james-assembly/pom.xml
##########
@@ -54,7 +54,7 @@
                 <version>2.7.1</version>
                 <configuration>
                     <from>
-                        <image>adoptopenjdk:11-jdk-hotspot</image>
+                        <image>eclipse-temurin:11-jre-focal</image>

Review comment:
       No JRE is fine here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org