[jira] [Commented] (FLINK-5851) Renaming AsyncCollector into ResultPromise/ResultFuture

["mingleizhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071572#comment-16071572 ] 

mingleizhang commented on FLINK-5851:
-------------------------------------

They are often used interchangeably, but has small differences. Promise is the function that set the value (return as a Future) of a async function, a promise from Wiki. I probably work on this soon.

> Renaming AsyncCollector into ResultPromise/ResultFuture
> -------------------------------------------------------
>
>                 Key: FLINK-5851
>                 URL: https://issues.apache.org/jira/browse/FLINK-5851
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>    Affects Versions: 1.2.0, 1.3.0
>            Reporter: Till Rohrmann
>             Fix For: 1.4.0
>
>
> Currently, the async I/O API gives an {{AsyncCollector}} to an {{AsyncFunction}} implementation. The name does not really reflect what the {{AsyncCollector}} does since it does not collect but is actually a one time completable future. Therefore, I propose to rename the {{AsyncCollector}} into {{ResultPromise}} or {{ResultFuture}}. This is API changing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)