You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4cxx-dev@logging.apache.org by ts...@apache.org on 2015/10/11 09:04:39 UTC
svn commit: r1707953 - /incubator/log4cxx/trunk/src/main/cpp/odbcappender.cpp
Author: tschoening
Date: Sun Oct 11 07:04:39 2015
New Revision: 1707953
URL: http://svn.apache.org/viewvc?rev=1707953&view=rev
Log:
clang warned about logical AND with a constant operator and this line looks more like it should use bit wise operator, like the lines before.
Modified:
incubator/log4cxx/trunk/src/main/cpp/odbcappender.cpp
Modified: incubator/log4cxx/trunk/src/main/cpp/odbcappender.cpp
URL: http://svn.apache.org/viewvc/incubator/log4cxx/trunk/src/main/cpp/odbcappender.cpp?rev=1707953&r1=1707952&r2=1707953&view=diff
==============================================================================
--- incubator/log4cxx/trunk/src/main/cpp/odbcappender.cpp (original)
+++ incubator/log4cxx/trunk/src/main/cpp/odbcappender.cpp Sun Oct 11 07:04:39 2015
@@ -352,7 +352,7 @@ void ODBCAppender::encode(unsigned short
unsigned char u = (unsigned char) (sv >> 16);
unsigned char w = (unsigned char) (u - 1);
unsigned short hs = (0xD800 + ((w & 0xF) << 6) + ((sv & 0xFFFF) >> 10));
- unsigned short ls = (0xDC00 + (sv && 0x3FF));
+ unsigned short ls = (0xDC00 + (sv & 0x3FF));
*current++ = (unsigned short) hs;
*current++ = (unsigned short) ls;
}