[GitHub] [solr] gerlowskija commented on a change in pull request #433: SOLR-15747: Convert /node v2 APIs to annotations

[GitBox <gi...@apache.org>]

gerlowskija commented on a change in pull request #433:
URL: https://github.com/apache/solr/pull/433#discussion_r758369621



##########
File path: solr/core/src/java/org/apache/solr/handler/admin/InfoHandler.java
##########
@@ -150,11 +156,6 @@ public SolrRequestHandler getSubHandler(String subPath) {
 
   @Override
   public Collection<Api> getApis() {
-    return singletonList(new ReqHandlerToApi(this, getSpec("node.Info")));
-  }
-
-  @Override
-  public Boolean registerV2() {
-    return Boolean.TRUE;
+    return Collections.emptyList();

Review comment:
       I need to look into this a little more.  I _think_ that this method can go away altogether here - it exists to register the v2 APIs associated with this request handler, but in this PR that registration moves over to the 'ApiRegistrar' class where other annotation-based APIs are registered.
   
   So maybe I can remove this here, but I'll need a little more digging to see.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org