You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/23 22:16:57 UTC
[GitHub] [fineract] thesmallstar opened a new pull request #931: FINERACT-821 Added and enforced NeedBraces Checkstyle
thesmallstar opened a new pull request #931:
URL: https://github.com/apache/fineract/pull/931
Refer: https://issues.apache.org/jira/browse/FINERACT-821
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar edited a comment on pull request #931: FINERACT-821 Added and enforced NeedBraces Checkstyle
Posted by GitBox <gi...@apache.org>.
thesmallstar edited a comment on pull request #931:
URL: https://github.com/apache/fineract/pull/931#issuecomment-633306819
@vorburger I tried to automate this with every plugin/ide that I knew. The best help I could get was a quick fix bulb icon in VSC, which on visiting such if/for loop would help me identify/add braces, but still I had to visit each one of them individually(not a very exciting job tbh). A detailed review will be better? although unlikely if there is a problem, we might not even notice it after this gets merged. Also, It would be great if we could merge this is 3/4 days to avoid multiple merge conflicts :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #931: FINERACT-821 Added and enforced NeedBraces Checkstyle
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #931:
URL: https://github.com/apache/fineract/pull/931#issuecomment-633147741
@vorburger this is the most not-so-obedient checkstyle :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #931: FINERACT-821 Added and enforced NeedBraces Checkstyle
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #931:
URL: https://github.com/apache/fineract/pull/931#issuecomment-634276935
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #931: FINERACT-821 Added and enforced NeedBraces Checkstyle
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #931:
URL: https://github.com/apache/fineract/pull/931#issuecomment-633306819
@vorburger I tried to automate this with every plugin/ide that I knew. The best help I could get was a quick fix bulb icon, which on visiting such if/for loop would help me identify/add braces, but still I had to visit each one of them individually(not a very exciting job tbh). A detailed review will be better? although unlikely if there is a problem, we might not even notice it after this gets merged. Also, It would be great if we could merge this is 3/4 days to avoid multiple merge conflicts :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #931: FINERACT-821 Added and enforced NeedBraces Checkstyle
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #931:
URL: https://github.com/apache/fineract/pull/931#issuecomment-633196548
WOW! Did you do this manually, or with a tool? IDE like Eclipse or IDEA could maybe help with something like this.. Also I'm trying to decide if I should review this carefully line by line, or just merge... @awasum @Anh3h thoughts? Should be safe?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #931: FINERACT-821 Added and enforced NeedBraces Checkstyle
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #931:
URL: https://github.com/apache/fineract/pull/931
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #931: FINERACT-821 Added and enforced NeedBraces Checkstyle
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #931:
URL: https://github.com/apache/fineract/pull/931#issuecomment-634279112
Why comment out the RegExpMultiline?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #931: FINERACT-821 Added and enforced NeedBraces Checkstyle
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #931:
URL: https://github.com/apache/fineract/pull/931#issuecomment-633851195
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org