You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Dean Gaudet <dg...@arctic.org> on 1997/10/22 09:13:14 UTC
[PATCH] Re: os-sunos/1294: Spurious mmap error messages? (fwd)
An slight logic error when MMAP_THRESHOLD is non-zero. It prints warnings
when it really shouldn't ... This patch fixes it.
Dean
---------- Forwarded message ----------
Date: 22 Oct 1997 01:10:00 -0000
From: Dean Gaudet <dg...@arctic.org>
To: apache-bugdb@apache.org
Cc: apache-bugdb@apache.org,
Subject: Re: os-sunos/1294: Spurious mmap error messages?
The following reply was made to PR os-sunos/1294; it has been noted by GNATS.
From: Dean Gaudet <dg...@arctic.org>
To: David Chambers <da...@flosun.salk.edu>
Cc: apbugs@hyperreal.org
Subject: Re: os-sunos/1294: Spurious mmap error messages?
Date: Tue, 21 Oct 1997 18:01:42 -0700 (PDT)
Yup this is a bug. The block/unblock are important ... try this patch
instead of your patch:
Dean
Index: http_core.c
===================================================================
RCS file: /export/home/cvs/apachen/src/main/http_core.c,v
retrieving revision 1.125
diff -u -r1.125 http_core.c
--- http_core.c 1997/10/07 19:34:00 1.125
+++ http_core.c 1997/10/22 00:59:36
@@ -1686,8 +1686,10 @@
if (mm == (caddr_t)-1) {
unblock_alarms();
- aplog_error(APLOG_MARK, APLOG_CRIT, r->server,
- "mmap_handler: mmap failed: %s", r->filename);
+ if (r->finfo.st_size >= MMAP_THRESHOLD) {
+ aplog_error(APLOG_MARK, APLOG_CRIT, r->server,
+ "mmap_handler: mmap failed: %s", r->filename);
+ }
#endif
if (d->content_md5 & 1) {