You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rya.apache.org by amihalik <gi...@git.apache.org> on 2015/12/01 21:17:26 UTC
[GitHub] incubator-rya pull request: RYA-7 POM and License Clean-up for Apa...
GitHub user amihalik opened a pull request:
https://github.com/apache/incubator-rya/pull/2
RYA-7 POM and License Clean-up for Apache Move
Numerous POM and License Mods:
- Make the apache pom the parent
- Depend on Apache releases for Hadoop and ZooKeeper
- Updated to most recent bug-fix release for dependencies
- Moved Deps to Parent POM
- Change groupId from mvn.rya to org.apache.rya
- Set proper names for each maven module
- Fix SCM block in parent pom
- Remove Dead/CB Projects
- Remove Extra Repos/Profiles
- Moved rya.sail.impl to rya.sail
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amihalik/incubator-rya mihalik/RYA-7
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/2.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2
----
commit 3238bf27143faf1fecd71c6dd22f9ed3c02f4057
Author: Aaron Mihalik <mi...@alum.mit.edu>
Date: 2015-12-01T20:11:17Z
RYA-7 POM and License Clean-up for Apache Move
Numerous POM and License Mods:
- Make the apache pom the parent
- Depend on Apache releases for Hadoop and ZooKeeper
- Updated to most recent bug-fix release for dependencies
- Moved Deps to Parent POM
- Change groupId from mvn.rya to org.apache.rya
- Set proper names for each maven module
- Fix SCM block in parent pom
- Remove Dead/CB Projects
- Remove Extra Repos/Profiles
- Moved rya.sail.impl to rya.sail
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request: RYA-7 POM and License Clean-up for Apa...
Posted by DLotts <gi...@git.apache.org>.
Github user DLotts commented on the pull request:
https://github.com/apache/incubator-rya/pull/2#issuecomment-161370216
I reviewed the license headers, and it looks great.
These two are in place and are correct: ./LICENSE ./NOTICE
The license is in every file except the following. Each of these is either binary, generated, or low creativity:
./dao/accumulo.rya/src/test/resources/namedgraphs.trig
./dao/accumulo.rya/src/test/resources/test.ntriples
./extras/indexing/src/main/java/mvm/rya/indexing/accumulo/freetext/query/QueryParser.jj
./extras/rya.console/.gitignore
./extras/rya.prospector/src/main/resources/META-INF/services/mvm.rya.prospector.plans.IndexWorkPlan
./osgi/camel.rya/src/main/resources/META-INF/services/org/apache/camel/component/cbsail
./osgi/sesame-runtime-osgi/openrdf-sesame-osgi.bnd
./pig/accumulo.pig/src/test/resources/ResultsFile1.txt
./pig/accumulo.pig/src/test/resources/testQuery.txt
./pig/accumulo.pig/src/test/resources/testQuery2.txt
./sail/src/main/resources/META-INF/org.openrdf.store.schemas
./sail/src/main/resources/META-INF/schemas/cloudbasestore-schema.ttl
./sail/src/main/resources/META-INF/services/org.openrdf.sail.config.SailFactory
./sail/src/test/resources/namedgraphs.trig
./sail/src/test/resources/ntriples.nt
./sail/src/test/resources/univ-bench.owl
./web/web.rya/src/test/resources/dummyData/memorystore.data
./web/web.rya/src/test/resources/namedgraphs.trig
./web/web.rya/src/test/resources/test.nt
david.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request: RYA-7 POM and License Clean-up for Apa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rya/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request: RYA-7 POM and License Clean-up for Apa...
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the pull request:
https://github.com/apache/incubator-rya/pull/2#issuecomment-161380000
Took a glance, and it looks alright to me. I haven't put a close eye to whether the LICENSE and NOTICE files are actually correct (not a super high priority at Rya's current stage in life).
Lots of nice fixes to the poms. Thanks for taking the time to work on this.
A minor nit is that it would be better to push down the rat-plugin exclusions to each module (rather than defining it in the parent pom). This helps make sure we know _exactly_ what is being ignored and we don't accidentally ignore something new in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---