You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2016/03/02 22:48:45 UTC

Review Request 44299: Added unit test for file URI fetcher.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44299/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

Added unit test for file URI fetcher.


Diffs
-----

  src/tests/containerizer/provisioner_appc_tests.cpp 9d9779ac04e32348ce0e28da54fd7aa039a7fbcd 

Diff: https://reviews.apache.org/r/44299/diff/


Testing
-------

make check.


Thanks,

Jojy Varghese


Re: Review Request 44299: Added unit test for file URI fetcher.

Posted by Jojy Varghese <jo...@mesosphere.io>.

> On March 8, 2016, 1:57 a.m., Jie Yu wrote:
> > src/tests/containerizer/provisioner_appc_tests.cpp, lines 590-591
> > <https://reviews.apache.org/r/44299/diff/2/?file=1280158#file1280158line590>
> >
> >     Looking at the original code, why do we need this id? Should that always be the same? Why do we need to pass it in?

moved the image id up to `prepareImage` method.


- Jojy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44299/#review122461
-----------------------------------------------------------


On March 8, 2016, 10:49 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44299/
> -----------------------------------------------------------
> 
> (Updated March 8, 2016, 10:49 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit test for file URI fetcher.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 6c8087e17aa8b7139ba12337d5be472b7099e77f 
> 
> Diff: https://reviews.apache.org/r/44299/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Re: Review Request 44299: Added unit test for file URI fetcher.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44299/#review122461
-----------------------------------------------------------




src/tests/containerizer/provisioner_appc_tests.cpp (lines 587 - 588)
<https://reviews.apache.org/r/44299/#comment184457>

    Looking at the original code, why do we need this id? Should that always be the same? Why do we need to pass it in?



src/tests/containerizer/provisioner_appc_tests.cpp (lines 591 - 592)
<https://reviews.apache.org/r/44299/#comment184459>

    I don't like this. Sounds like to try very hard to reuse the same fixture, but that causes a lot of confusion. Let's chat about this tomorrow.



src/tests/containerizer/provisioner_appc_tests.cpp (line 665)
<https://reviews.apache.org/r/44299/#comment184458>

    It looks weired to me that FileFetch test will use a 'Server'. It's very confusing. I understand that you want to re-use the same helper. Can we rename the helper and change the semantics to just create an image tarball? Let's chat about this tomorrow.


- Jie Yu


On March 3, 2016, 11:37 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44299/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 11:37 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit test for file URI fetcher.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 6c8087e17aa8b7139ba12337d5be472b7099e77f 
> 
> Diff: https://reviews.apache.org/r/44299/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Re: Review Request 44299: Added unit test for file URI fetcher.

Posted by Jie Yu <yu...@gmail.com>.

> On March 11, 2016, 12:43 a.m., Jie Yu wrote:
> > src/tests/containerizer/provisioner_appc_tests.cpp, lines 572-578
> > <https://reviews.apache.org/r/44299/diff/3/?file=1292352#file1292352line572>
> >
> >     No need for this?

I'll fix it for you.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44299/#review123048
-----------------------------------------------------------


On March 8, 2016, 10:49 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44299/
> -----------------------------------------------------------
> 
> (Updated March 8, 2016, 10:49 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit test for file URI fetcher.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 6c8087e17aa8b7139ba12337d5be472b7099e77f 
> 
> Diff: https://reviews.apache.org/r/44299/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Re: Review Request 44299: Added unit test for file URI fetcher.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44299/#review123048
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


src/tests/containerizer/provisioner_appc_tests.cpp (lines 572 - 575)
<https://reviews.apache.org/r/44299/#comment185174>

    No need for this?


- Jie Yu


On March 8, 2016, 10:49 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44299/
> -----------------------------------------------------------
> 
> (Updated March 8, 2016, 10:49 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit test for file URI fetcher.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 6c8087e17aa8b7139ba12337d5be472b7099e77f 
> 
> Diff: https://reviews.apache.org/r/44299/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Re: Review Request 44299: Added unit test for file URI fetcher.

Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44299/
-----------------------------------------------------------

(Updated March 8, 2016, 10:49 p.m.)


Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

Added unit test for file URI fetcher.


Diffs (updated)
-----

  src/tests/containerizer/provisioner_appc_tests.cpp 6c8087e17aa8b7139ba12337d5be472b7099e77f 

Diff: https://reviews.apache.org/r/44299/diff/


Testing
-------

make check.


Thanks,

Jojy Varghese


Re: Review Request 44299: Added unit test for file URI fetcher.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44299/#review122024
-----------------------------------------------------------



Patch looks great!

Reviews applied: [44239, 44298, 43969, 44299]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 3, 2016, 11:37 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44299/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 11:37 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit test for file URI fetcher.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 6c8087e17aa8b7139ba12337d5be472b7099e77f 
> 
> Diff: https://reviews.apache.org/r/44299/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Re: Review Request 44299: Added unit test for file URI fetcher.

Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44299/
-----------------------------------------------------------

(Updated March 3, 2016, 11:37 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

rebased.


Repository: mesos


Description
-------

Added unit test for file URI fetcher.


Diffs (updated)
-----

  src/tests/containerizer/provisioner_appc_tests.cpp 6c8087e17aa8b7139ba12337d5be472b7099e77f 

Diff: https://reviews.apache.org/r/44299/diff/


Testing
-------

make check.


Thanks,

Jojy Varghese