You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "Sqoop QA bot (JIRA)" <ji...@apache.org> on 2015/08/29 16:21:45 UTC
[jira] [Commented] (SQOOP-2544) Sqoop2: Drop connectors servlet
[ https://issues.apache.org/jira/browse/SQOOP-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721121#comment-14721121 ]
Sqoop QA bot commented on SQOOP-2544:
-------------------------------------
Testing file [SQOOP-2544.patch|https://issues.apache.org/jira/secure/attachment/12753136/SQOOP-2544.patch] against branch sqoop2 took 0:51:40.812169.
{color:red}Overall:{color} -1 due to an error(s), see details below:
{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:red}ERROR:{color} Patch does not add/modify any test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1408 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1652/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1652/artifact/patch-process/findbugs_report.txt])
{color:green}SUCCESS:{color} All integration tests passed (executed 73 tests)
Console output is available [here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1652/console].
This message is automatically generated.
> Sqoop2: Drop connectors servlet
> -------------------------------
>
> Key: SQOOP-2544
> URL: https://issues.apache.org/jira/browse/SQOOP-2544
> Project: Sqoop
> Issue Type: Sub-task
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 1.99.7
>
> Attachments: SQOOP-2544.patch
>
>
> If I'm looking correctly, then we have two servlets - one called {{Connectors}} and second called {{Connector}} (plurality is the difference). Looking into the client code it seems that we're not really using {{Connectors}} form anywhere as it's a functionality equivalent for calling {{connector/all}}. Hence I would like to propose simply dropping it and have one public interface less to worry about. Any objections?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)