You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/04 08:14:13 UTC

[GitHub] [flink] tillrohrmann commented on pull request #13042: [FLINK-16510] Allow overriding of graceful with forceful shutdown

tillrohrmann commented on pull request #13042:
URL: https://github.com/apache/flink/pull/13042#issuecomment-668452463


   Fair points. If it should ever become a problem that we set a custom `SecurityManager` we might have to revisit this problem.
   
   +1 for making the mechanism available for all Flink processes.
   
   One small comment for the place where to instantiate the `SecurityManager`: At the moment it happens in the `TaskManagerRunner.startTaskManager` method. This method will be called multiple times by the `MiniCluster`, though. Hence, I would suggest to move the instantiation of the `SecurityManager` more to the entrypoints (`ClusterEntrypoint`, `MiniCluster`, `TaskManagerRunner.runTaskManagerSecurely` (update `YarnTaskExecutorRunner` to call into the same method)).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org