You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/23 12:28:04 UTC

[GitHub] [dubbo] zrlw opened a new issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

zrlw opened a new issue #8581:
URL: https://github.com/apache/dubbo/issues/8581


   ### Environment
   
   * Dubbo version: 2.7.13
   
   ### Steps to reproduce this issue
   NetUtils.ignoreNetworkInterface方法使用matches判断是否是要忽略的网卡，
   当网卡名称包含圆括号时，如INTEL(R) XXX
   即使完全相同，结果也是false： ”INTEL(R) XXX".matches("INTEL(R) XXX" 结果为false！
   
   比较了3.0的代码，该方法已经删除了DUBBO_NETWORK_IGNORED_INTERFACE相关的处理，建议2.7系列做一下同步修订。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw edited a comment on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
zrlw edited a comment on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-907761372


   debug测试发现忽略的网卡名包含某些元字符时，matches直接抛异常，需要做一下捕获处理。
   新提交的PR内容里顺便修订了一下原来测试案例的一处手误（匹配所有应该用```.*```，不能省略```.```字符），新增了一个网卡名称包含常见元字符的测试案例。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw commented on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
zrlw commented on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-903723181


   实际上不止圆括号，网卡名称包含其他正则表达式元字符时，这条语句也会失败的。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw commented on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
zrlw commented on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-904368301


   ```
   String ignoredInterfaces = “Intel(R) wireless XXX";
   System.setProperty(DUBBO_NETWORK_IGNORED_INTERFACE,ignoredInterfaces);
   ```
   详细可参考NetUtilsTest.java测试类里的testIgnoreGivenPrefixInterfaceName方法。
   PS:
   可能dubbo不止这一处缺陷，无线网卡物理名称里面通常都有个(R)，在windows下控制面板把其他网卡全disable掉，只留下一个物理名称带(R)的无线网卡，然后跑dubbo整个工程的mvn clean install，不止dubbo-common工程单元测试过不去的。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] AlbumenJ commented on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-906942299


   这个问题是不是给 dubbo.network.interface.ignored 加一下转义就好了


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] BazookaW commented on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
BazookaW commented on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-904322507


   @zrlw 请问`DUBBO_NETWORK_IGNORED_INTERFACE = "dubbo.network.interface.ignored"`这个参数你是在哪里设置的呢？
   
   > NetUtils.ignoreNetworkInterface方法使用matches判断是否是要忽略的网卡，当网卡名称包含圆括号时，如INTEL(R) XXX
   > 即使完全相同，结果也是false： ”INTEL(R) XXX".matches("INTEL(R) XXX" 结果为false！
   
   ![image](https://user-images.githubusercontent.com/17539174/130558080-46d99e38-9710-4431-b66d-4d70e041617a.png)
   我验证了一下，确实是返回false


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw edited a comment on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
zrlw edited a comment on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-907761372


   debug测试发现忽略的网卡名包含某些元字符时，matches直接抛异常，需要做一下捕获处理。
   新提交的PR内容里顺便修订了一下原来测试案例的一处手误（匹配所有应该用```.*```，不能省略```.```字符），新增了一个忽略网卡名称包含常见元字符的测试案例。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] AlbumenJ commented on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-906941853


   在 2.7 里面这个功能是由 https://github.com/apache/dubbo/pull/7884 这个 PR 提供的，3.0 还没迁移过来，你可以提个 PR 迁移下@wangchengming666 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw edited a comment on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
zrlw edited a comment on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-907611897


   > 这个问题是不是给 dubbo.network.interface.ignored 加一下转义就好了
   
   dubbo.network.interface.ignored这个配置内容需要用户自己去做转义，只有用户清楚里面的哪些特殊字符需要做转义处理，哪些不需要转。
   dubbo可以做的是在配置指南上指出如果需要屏蔽的网卡名称里面包含特殊字符，则在不需要转义的内容前后加上\Q和\E就好了，就像Pattern.quote方法做的那样，比如过滤掉Intel(R)开头的所有网卡，那么用户就需要配置为```\\QIntel(R)\\E.*``` 或者 ```Intel\\Q(R)\\E.*``` 或者```Intel\\Q(\\ER\\Q)\\E.*```，或者反斜杠转义这种： ```Intel\\(R\\).*```
   在vm启动参数配置ignored network时，用一个反斜杠，比如```-Ddubbo.network.interface.ignored=Intel\(R\).*,VirtualBox.*```，只有System.setProperty或者配置文件才要写两个反斜杠。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw edited a comment on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
zrlw edited a comment on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-907611897


   > 这个问题是不是给 dubbo.network.interface.ignored 加一下转义就好了
   
   dubbo.network.interface.ignored这个配置内容需要用户自己去做转义，只有用户清楚里面的哪些特殊字符需要做转义处理，哪些不需要转。
   dubbo可以做的是在配置指南上指出如果需要屏蔽的网卡名称里面包含特殊字符，则在不需要转义的内容前后加上\Q和\E就好了，就像Pattern.quote方法做的那样，比如过滤掉Intel(R)开头的所有网卡，那么用户就需要配置为```\\QIntel(R)\\E.*``` 或者 ```Intel\\Q(R)\\E.*``` 或者```Intel\\Q(\\ER\\Q)\\E.*```，或者反斜杠转义这种： ```Intel\\(R\\).*```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw commented on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
zrlw commented on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-907761372


   debug测试发现网卡名包含某些元字符时，matches直接抛异常，需要做一下捕获处理。
   顺便修订了一下原来测试案例的一处手误（匹配所有应该用```.*```，不能省略```.```字符），新增了一个网卡名称包含常见元字符的测试案例。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw edited a comment on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
zrlw edited a comment on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-904368301


   ```
   String ignoredInterfaces = “Intel(R) wireless XXX";
   System.setProperty(DUBBO_NETWORK_IGNORED_INTERFACE,ignoredInterfaces);
   ```
   详细可参考NetUtilsTest.java测试类里的testIgnoreGivenPrefixInterfaceName方法。
   PS:
   很多dubbo单元测试类使用了趋势网络防火墙的端口12345，有这个防火墙的环境下跑不动，虽然算不上缺陷，但是可以考虑把公共的测试参数集中起来统一进行配置，每个测试类都自己硬编码端口12345不太优雅,。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] wangchengming666 commented on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
wangchengming666 commented on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-906944386


   > 在 2.7 里面这个功能是由 #7884 这个 PR 提供的，3.0 还没迁移过来，你可以提个 PR 迁移下@wangchengming666
   
   👌, I'll will create PR to solve it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] BazookaW commented on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
BazookaW commented on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-904468571


   @AlbumenJ 我看3.0分支没有ignore network Interface的代码了，请问是出于什么考虑呢？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw commented on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
zrlw commented on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-907611897


   > 这个问题是不是给 dubbo.network.interface.ignored 加一下转义就好了
   
   dubbo.network.interface.ignored这个配置内容需要用户自己去做转义，只有用户清楚里面的哪些特殊字符需要做转义处理，哪些不需要转。
   dubbo可以做的是在配置指南上指出如果需要屏蔽的网卡名称里面包含特殊字符，则在不需要转义的内容前后加上\Q和\E就好了就像Pattern.quote方法做的那样，比如过滤掉Intel(R)开头的所有网卡，那么用户就需要配置为```\QIntel(R)\E.*``` 或者 ```Intel\Q(R\E).*```，或者反斜杠转义这种： ```Intel\\(R\\).*```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] wangchengming666 edited a comment on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
wangchengming666 edited a comment on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-906944386


   > 在 2.7 里面这个功能是由 #7884 这个 PR 提供的，3.0 还没迁移过来，你可以提个 PR 迁移下@wangchengming666
   
   OK, I'll will create PR to solve it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw commented on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
zrlw commented on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-906980395


   > dubbo.network.interface.ignored 加
   
   正则表达式的元字符规则比较多，比如-[的-就是普通字符，如果-后面跟着的不是[就是元字符，感觉转义太复杂了，是不是直接加个或全等条件算了，如
   ```
   if (a.matches(b) || a.equals(b)) { ...}
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw commented on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
zrlw commented on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-907635620


   考虑再三还是在提交的PR里还加进去了全等比较条件，作为正则匹配的补充。
   配置dubbo.network.interface.ignored参数时，还要查一下配置的网卡名称里面有没有需要转义的元字符，可能这个要求对于大多数人而言都有点离谱了。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] AlbumenJ closed issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
AlbumenJ closed issue #8581:
URL: https://github.com/apache/dubbo/issues/8581


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw edited a comment on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
zrlw edited a comment on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-907611897


   > 这个问题是不是给 dubbo.network.interface.ignored 加一下转义就好了
   
   dubbo.network.interface.ignored这个配置内容需要用户自己去做转义，只有用户清楚里面的哪些特殊字符需要做转义处理，哪些不需要转。
   dubbo可以做的是在配置指南上指出如果需要屏蔽的网卡名称里面包含特殊字符，则在不需要转义的内容前后加上\Q和\E就好了，就像Pattern.quote方法做的那样，比如过滤掉Intel(R)开头的所有网卡，那么用户就需要配置为```\QIntel(R)\E.*``` 或者 ```Intel\Q(R)\E.*```，或者反斜杠转义这种： ```Intel\\(R\\).*```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] wangchengming666 commented on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
wangchengming666 commented on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-906944812


   > 这个问题是不是给 dubbo.network.interface.ignored 加一下转义就好了
   
   Please assign to me and I'll solve it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] wangchengming666 removed a comment on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
wangchengming666 removed a comment on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-906944812


   > 这个问题是不是给 dubbo.network.interface.ignored 加一下转义就好了
   
   Please assign to me and I'll solve it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw commented on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
zrlw commented on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-906996308


   如果提供python那样的raw string类型就容易搞了，可惜喊了好多年，java现在也没有搞出来。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw edited a comment on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
zrlw edited a comment on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-907761372


   debug测试发现网卡名包含某些元字符时，matches直接抛异常，需要做一下捕获处理。
   新提交的PR内容里顺便修订了一下原来测试案例的一处手误（匹配所有应该用```.*```，不能省略```.```字符），新增了一个网卡名称包含常见元字符的测试案例。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw edited a comment on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

Posted by GitBox <gi...@apache.org>.
zrlw edited a comment on issue #8581:
URL: https://github.com/apache/dubbo/issues/8581#issuecomment-904368301


   ```
   String ignoredInterfaces = "Intel(R) wireless XXX";
   System.setProperty(DUBBO_NETWORK_IGNORED_INTERFACE,ignoredInterfaces);
   ```
   详细可参考NetUtilsTest.java测试类里的testIgnoreGivenPrefixInterfaceName方法。
   PS:
   很多dubbo单元测试类使用了趋势网络防火墙的端口12345，有这个防火墙的环境下跑不动，虽然算不上缺陷，但是可以考虑把公共的测试参数集中起来统一进行配置，每个测试类都自己硬编码端口12345不太优雅,。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org