[GitHub] [inlong] Greedyu commented on a diff in pull request #4882: [INLONG-4814][Sort][Manager] Declare the primary key for sink table when the query contains update/delete

[GitBox <gi...@apache.org>]

Greedyu commented on code in PR #4882:
URL: https://github.com/apache/inlong/pull/4882#discussion_r934091338


##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/load/ClickHouseLoadNode.java:
##########
@@ -73,12 +85,21 @@ public ClickHouseLoadNode(@JsonProperty("id") String id,
             @Nonnull @JsonProperty("tableName") String tableName,
             @Nonnull @JsonProperty("url") String url,
             @Nonnull @JsonProperty("userName") String userName,
-            @Nonnull @JsonProperty("passWord") String password) {
+            @Nonnull @JsonProperty("passWord") String password,
+            @JsonProperty("engine") String engine,
+            @JsonProperty("partitionBy") String partitionBy,

Review Comment:
   These are important attributes of clickhouse. Even if you don't use them directly now, you can add them first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org