You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/07 07:05:00 UTC
[GitHub] [beam] kmjung opened a new pull request #12494: [BEAM-10658] Update BigQuery storage sources to v1 API
kmjung opened a new pull request #12494:
URL: https://github.com/apache/beam/pull/12494
This pull request updates the BigQuery storage sources -- stream, table, and query -- to use v1 of the BigQuery storage API, rather than the now-legacy v1beta1 API, in preparation for turning down v1beta1.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kmjung commented on a change in pull request #12494: [BEAM-10658] Update BigQuery storage sources to v1 API
Posted by GitBox <gi...@apache.org>.
kmjung commented on a change in pull request #12494:
URL: https://github.com/apache/beam/pull/12494#discussion_r476580093
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java
##########
@@ -348,22 +347,17 @@ static RetryJobIdResult getRetryJobId(
UNKNOWN,
}
- @VisibleForTesting
- static TableReferenceProto.TableReference toTableRefProto(TableReference ref) {
- TableReferenceProto.TableReference.Builder builder =
- TableReferenceProto.TableReference.newBuilder();
- if (ref.getProjectId() != null) {
- builder.setProjectId(ref.getProjectId());
- }
- return builder.setDatasetId(ref.getDatasetId()).setTableId(ref.getTableId()).build();
+ static String toProjectResourceName(String projectName) {
+ return "projects/" + projectName;
Review comment:
Done.
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java
##########
@@ -348,22 +347,17 @@ static RetryJobIdResult getRetryJobId(
UNKNOWN,
}
- @VisibleForTesting
- static TableReferenceProto.TableReference toTableRefProto(TableReference ref) {
- TableReferenceProto.TableReference.Builder builder =
- TableReferenceProto.TableReference.newBuilder();
- if (ref.getProjectId() != null) {
- builder.setProjectId(ref.getProjectId());
- }
- return builder.setDatasetId(ref.getDatasetId()).setTableId(ref.getTableId()).build();
+ static String toProjectResourceName(String projectName) {
+ return "projects/" + projectName;
}
- @VisibleForTesting
- static TableReference toTableRef(TableReferenceProto.TableReference ref) {
- return new TableReference()
- .setProjectId(ref.getProjectId())
- .setDatasetId(ref.getDatasetId())
- .setTableId(ref.getTableId());
+ static String toTableResourceName(TableReference tableReference) {
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kmjung commented on pull request #12494: [BEAM-10658] Update BigQuery storage sources to v1 API
Posted by GitBox <gi...@apache.org>.
kmjung commented on pull request #12494:
URL: https://github.com/apache/beam/pull/12494#issuecomment-670364887
R: @chamikaramj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on a change in pull request #12494: [BEAM-10658] Update BigQuery storage sources to v1 API
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on a change in pull request #12494:
URL: https://github.com/apache/beam/pull/12494#discussion_r475960972
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java
##########
@@ -348,22 +347,17 @@ static RetryJobIdResult getRetryJobId(
UNKNOWN,
}
- @VisibleForTesting
- static TableReferenceProto.TableReference toTableRefProto(TableReference ref) {
- TableReferenceProto.TableReference.Builder builder =
- TableReferenceProto.TableReference.newBuilder();
- if (ref.getProjectId() != null) {
- builder.setProjectId(ref.getProjectId());
- }
- return builder.setDatasetId(ref.getDatasetId()).setTableId(ref.getTableId()).build();
+ static String toProjectResourceName(String projectName) {
+ return "projects/" + projectName;
Review comment:
Is this format standardized ? If so can we add a reference here ?
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java
##########
@@ -348,22 +347,17 @@ static RetryJobIdResult getRetryJobId(
UNKNOWN,
}
- @VisibleForTesting
- static TableReferenceProto.TableReference toTableRefProto(TableReference ref) {
- TableReferenceProto.TableReference.Builder builder =
- TableReferenceProto.TableReference.newBuilder();
- if (ref.getProjectId() != null) {
- builder.setProjectId(ref.getProjectId());
- }
- return builder.setDatasetId(ref.getDatasetId()).setTableId(ref.getTableId()).build();
+ static String toProjectResourceName(String projectName) {
+ return "projects/" + projectName;
}
- @VisibleForTesting
- static TableReference toTableRef(TableReferenceProto.TableReference ref) {
- return new TableReference()
- .setProjectId(ref.getProjectId())
- .setDatasetId(ref.getDatasetId())
- .setTableId(ref.getTableId());
+ static String toTableResourceName(TableReference tableReference) {
Review comment:
Ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj merged pull request #12494: [BEAM-10658] Update BigQuery storage sources to v1 API
Posted by GitBox <gi...@apache.org>.
chamikaramj merged pull request #12494:
URL: https://github.com/apache/beam/pull/12494
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kmjung commented on pull request #12494: [BEAM-10658] Update BigQuery storage sources to v1 API
Posted by GitBox <gi...@apache.org>.
kmjung commented on pull request #12494:
URL: https://github.com/apache/beam/pull/12494#issuecomment-679242125
@chamikaramj ping?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org