You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2017/07/06 03:52:55 UTC
[GitHub] incubator-guacamole-client pull request #173: GUACAMOLE-338: Expand connecti...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/173
GUACAMOLE-338: Expand connections/groups by default if any of their descendants are selected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-client auto-expand-groups
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/173.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #173
----
commit 5648c36c267b6becb287542766eba77a4d9a9311
Author: Michael Jumper <mj...@apache.org>
Date: 2017-07-03T23:07:24Z
GUACAMOLE-338: Allow guacGroupList and guacGroupListFilter to accept GroupListItems in addition to ConnectionGroups.
commit 5c4188e7ed3418bab82bb47ae7c57b5c50cd9d24
Author: Michael Jumper <mj...@apache.org>
Date: 2017-07-03T23:21:21Z
GUACAMOLE-338: The "expandable" property of connection GroupListItems should accurately reflect the default includeSharingProfiles value.
commit 970e50d0c6c9a0c4933c959f144681342cf4ac64
Author: Michael Jumper <mj...@apache.org>
Date: 2017-07-03T23:57:41Z
GUACAMOLE-338: Automatically expand connections or connection groups which are ancestors of objects for which the user being modified already has READ permission.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #173: GUACAMOLE-338: Expand connecti...
Posted by jmuehlner <gi...@git.apache.org>.
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/173#discussion_r127118531
--- Diff: guacamole/src/main/webapp/app/groupList/types/GroupListItem.js ---
@@ -187,7 +187,7 @@ angular.module('groupList').factory('GroupListItem', ['ConnectionGroup', functio
dataSource : dataSource,
// Type information
- expandable : includeSharingProfiles,
+ expandable : includeSharingProfiles !== false,
--- End diff --
Why this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #173: GUACAMOLE-338: Expand connecti...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/173#discussion_r127245352
--- Diff: guacamole/src/main/webapp/app/groupList/types/GroupListItem.js ---
@@ -187,7 +187,7 @@ angular.module('groupList').factory('GroupListItem', ['ConnectionGroup', functio
dataSource : dataSource,
// Type information
- expandable : includeSharingProfiles,
+ expandable : includeSharingProfiles !== false,
--- End diff --
Sharing profiles are supposed to be included by default (the function is documented as `includeSharingProfiles` defaulting to `true`), but not specifying that parameter makes `includeSharingProfiles` falsey. The `expandable` property needs to be `true` unless `includeSharingProfiles` is explicitly `false`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #173: GUACAMOLE-338: Expand connecti...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-client/pull/173
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---