You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "manzhizhen (GitHub)" <gi...@apache.org> on 2019/04/06 10:01:51 UTC
[GitHub] [incubator-dubbo] manzhizhen opened pull request #3816: RpcContext新增remoteApplicationName字段
## What is the purpose of the change
In the process of using Dubbo, there are many scenarios where the Provider needs to know the applicationName of the Consumer (not just the Consumer IP). For example, I want to output the upstream caller to the log file and want to limit the flow according to the upstream application. Or downgrade, want to use the upstream application for arson drills, etc., so we usually add Filter to achieve (for example, DubboAppContextFilter in Sentinel, which is specifically done on the Consumer side: https://github.com/alibaba/Sentinel/ Blob/6bb4ff21dadde00c9453a5f57d030d55f87b71a8/sentinel-adapter/sentinel-dubbo-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/dubbo/DubboAppContextFilter.java), so I also hope that Dubbo can put this inside Simple things have been done
在我们使用Dubbo的过程中，有很多场景Provider端需要知道Consumer端的applicationName（而不仅仅只需要知道Consumer的IP），比如我想将上游调用方输出到出入口日志中、想根据上游应用来限流或降级、想根据上游应用来进行放火演练等，所以我们通常会自己加Filter来实现（例如Sentinel中的DubboAppContextFilter，就是专门在Consumer端做这个事情：https://github.com/alibaba/Sentinel/blob/6bb4ff21dadde00c9453a5f57d030d55f87b71a8/sentinel-adapter/sentinel-dubbo-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/dubbo/DubboAppContextFilter.java），所以，我也特别希望Dubbo内部自己能把这块简单的事情给做了
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3816 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3816: RpcContext新增remoteApplicationName字段
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3816?src=pr&el=h1) Report
> Merging [#3816](https://codecov.io/gh/apache/incubator-dubbo/pull/3816?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/844534959833f5ca1653cbe0f9ab81dc576cec01?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3816?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3816 +/- ##
============================================
- Coverage 63.63% 63.59% -0.04%
Complexity 71 71
============================================
Files 704 704
Lines 31065 31069 +4
Branches 5037 5037
============================================
- Hits 19767 19759 -8
- Misses 9029 9033 +4
- Partials 2269 2277 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3816?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/dubbo/rpc/filter/ContextFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3816/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQ29udGV4dEZpbHRlci5qYXZh) | `93.33% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...src/main/java/org/apache/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3816/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNDb250ZXh0LmphdmE=) | `70% <75%> (+0.11%)` | `0 <0> (ø)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3816/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `58.69% <0%> (-8.7%)` | `0% <0%> (ø)` | |
| [...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3816/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==) | `73.68% <0%> (-5.27%)` | `0% <0%> (ø)` | |
| [...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3816/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVNlcnZlci5qYXZh) | `69.64% <0%> (-3.58%)` | `0% <0%> (ø)` | |
| [.../exchange/support/header/HeaderExchangeServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3816/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZVNlcnZlci5qYXZh) | `66.98% <0%> (-2.84%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3816/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `73.46% <0%> (-0.69%)` | `0% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3816?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3816?src=pr&el=footer). Last update [8445349...2eb5bc0](https://codecov.io/gh/apache/incubator-dubbo/pull/3816?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3816 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3816: RpcContext新增remoteApplicationName字段
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3816?src=pr&el=h1) Report
> Merging [#3816](https://codecov.io/gh/apache/incubator-dubbo/pull/3816?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/844534959833f5ca1653cbe0f9ab81dc576cec01?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3816?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3816 +/- ##
============================================
- Coverage 63.64% 63.62% -0.02%
Complexity 71 71
============================================
Files 704 704
Lines 31065 31069 +4
Branches 5037 5037
============================================
- Hits 19772 19769 -3
- Misses 9024 9028 +4
- Partials 2269 2272 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3816?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/dubbo/rpc/filter/ContextFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3816/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQ29udGV4dEZpbHRlci5qYXZh) | `93.33% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...src/main/java/org/apache/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3816/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNDb250ZXh0LmphdmE=) | `70% <75%> (+0.11%)` | `0 <0> (ø)` | :arrow_down: |
| [...apache/dubbo/common/config/ConfigurationUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3816/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbmZpZ3VyYXRpb25VdGlscy5qYXZh) | `64% <0%> (-8%)` | `0% <0%> (ø)` | |
| [.../exchange/support/header/HeaderExchangeServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3816/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZVNlcnZlci5qYXZh) | `66.98% <0%> (-2.84%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3816/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `75.51% <0%> (-0.69%)` | `0% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3816?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3816?src=pr&el=footer). Last update [8445349...2eb5bc0](https://codecov.io/gh/apache/incubator-dubbo/pull/3816?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3816 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] manzhizhen closed pull request #3816: RpcContext新增remoteApplicationName字段
Posted by "manzhizhen (GitHub)" <gi...@apache.org>.
[ pull request closed by manzhizhen ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3816 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] htynkn closed pull request #3816: RpcContext新增remoteApplicationName字段
Posted by "htynkn (GitHub)" <gi...@apache.org>.
[ pull request closed by htynkn ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3816 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org