[jira] [Created] (IMPALA-11184) Log rotation can fail if FLAGS_log_filename is set with custom value

["Riza Suminto (Jira)" <ji...@apache.org>]

Riza Suminto created IMPALA-11184:
-------------------------------------

             Summary: Log rotation can fail if FLAGS_log_filename is set with custom value
                 Key: IMPALA-11184
                 URL: https://issues.apache.org/jira/browse/IMPALA-11184
             Project: IMPALA
          Issue Type: Bug
          Components: Backend
    Affects Versions: Impala 4.0.0
            Reporter: Riza Suminto
            Assignee: Riza Suminto


There are several places where we use FLAGS_log_filename as glob pattern:

[https://github.com/apache/impala/8eeb000/master/be/src/common/logging.cc#L104]  
[https://github.com/apache/impala/8eeb000/master/be/src/common/logging.cc#L340] 

If FLAGS_log_filename is not set, it will be initialized with google::ProgramInvocationShortName(), which will lead to correct behavior of DeleteOldLogs() and GetLatestCanonicalLogPath(). But if user set custom value to this flag, the glob pattern will mistakenly target the symlink instead of the actual log files. This can be a problem in minicluster where we start multiple impalad sharing the same log dir.

We should replace them with google::ProgramInvocationShortName().



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org