You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/04/13 11:06:39 UTC
[GitHub] [arrow] alamb opened a new pull request, #35108: GH-35107: [FlightSQL]: Use `uint8` to refer to 8 bit unsigned integers rather than `uint1`
alamb opened a new pull request, #35108:
URL: https://github.com/apache/arrow/pull/35108
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
The spec is inconsistent -- see details on https://github.com/apache/arrow/issues/35107
### What changes are included in this PR?
Use `uint8` to refer to 8 bit unsigned integers rather than `uint1`
### Are these changes tested?
No, they are comment only changed
### Are there any user-facing changes?
This clarifies a small corner case in the document
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #35108: GH-35107: [FlightSQL]: Use `uint8` to refer to 8 bit unsigned integers rather than `uint1`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #35108:
URL: https://github.com/apache/arrow/pull/35108#issuecomment-1506774086
cc @lidavidm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb merged pull request #35108: GH-35107: [FlightSQL]: Use `uint8` to refer to 8 bit unsigned integers rather than `uint1`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #35108:
URL: https://github.com/apache/arrow/pull/35108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35108: GH-35107: [FlightSQL]: Use `uint8` to refer to 8 bit unsigned integers rather than `uint1`
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35108:
URL: https://github.com/apache/arrow/pull/35108#issuecomment-1506774224
* Closes: #35107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35108: GH-35107: [FlightSQL]: Use `uint8` to refer to 8 bit unsigned integers rather than `uint1`
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35108:
URL: https://github.com/apache/arrow/pull/35108#issuecomment-1512419985
Benchmark runs are scheduled for baseline = cc20df18708886dd1de3889e1f99df9b59749212 and contender = 4328ebac629b2c023b8d83d0329dd791cfa16aa7. 4328ebac629b2c023b8d83d0329dd791cfa16aa7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/93a9ddb7ff854fa79c20b8461f9ab367...b9f91e74fbbb4c9bbdb25ba1665ec4b7/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/20bc8c86b48f48909387a8523ef44846...7fca9428103947769eec2cf636f29514/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/6e59d089c289467fa5d4c7ab61355f64...2a3626b61c84491a8754b08c6eac0636/)
[Finished :arrow_down:2.09% :arrow_up:0.37%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9e1c1aaa04b24ef08528d75d5a9c58f1...375b5591bf174310a61cdf7a10af228b/)
Buildkite builds:
[Finished] [`4328ebac` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2725)
[Failed] [`4328ebac` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2759)
[Finished] [`4328ebac` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2723)
[Finished] [`4328ebac` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2750)
[Finished] [`cc20df18` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2724)
[Failed] [`cc20df18` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2758)
[Finished] [`cc20df18` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2722)
[Finished] [`cc20df18` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2749)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #35108: GH-35107: [FlightSQL]: Use `uint8` to refer to 8 bit unsigned integers rather than `uint1`
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #35108:
URL: https://github.com/apache/arrow/pull/35108#issuecomment-1506972070
I'm away from a computer for a while but in principle it seems good to me.
On Thu, Apr 13, 2023, at 20:07, github-actions[bot] wrote:
>
>
> • Closes: #35107 <https://github.com/apache/arrow/issues/35107>
>
> —
> Reply to this email directly, view it on GitHub <https://github.com/apache/arrow/pull/35108#issuecomment-1506774224>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACQB376WXZFK7VWLBB2NPTXA7M57ANCNFSM6AAAAAAW45NF7E>.
> You are receiving this because you were mentioned.Message ID: ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #35108: GH-35107: [FlightSQL]: Use `uint8` to refer to 8 bit unsigned integers rather than `uint1`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #35108:
URL: https://github.com/apache/arrow/pull/35108#issuecomment-1507738016
> +1
> I think that we don't need a vote for this change because this change is just a notation change.
I agree -- thank you -- I don't view this as a change of the spec, rather a textual clarification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #35108: GH-35107: [FlightSQL]: Use `uint8` to refer to 8 bit unsigned integers rather than `uint1`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #35108:
URL: https://github.com/apache/arrow/pull/35108#issuecomment-1507738393
I'll plan to leave this open for a few more days in case anyone else would like time to comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org