You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by el...@apache.org on 2012/10/07 14:26:32 UTC

svn commit: r1395286 - in /directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core: authn/ authn/ppolicy/ authz/ jndi/ operations/add/ suites/

Author: elecharny
Date: Sun Oct  7 12:26:32 2012
New Revision: 1395286

URL: http://svn.apache.org/viewvc?rev=1395286&view=rev
Log:
Added a sysout to know which test is being processed (it's useful when running the suite, as the tests are quite long)

Added:
    directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/jndi/RootDSEJndiIT.java
      - copied, changed from r1394453, directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/jndi/RootDSEIT.java
Modified:
    directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authn/SimpleAuthenticationIT.java
    directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authn/ppolicy/PasswordPolicyTest.java
    directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AddAuthorizationIT.java
    directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AdministratorsGroupIT.java
    directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AuthorizationServiceAsAdminIT.java
    directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AuthorizationServiceAsNonAdminIT.java
    directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AuthzAuthnIT.java
    directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/CompareAuthorizationIT.java
    directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/DeleteAuthorizationIT.java
    directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/GeneralAuthorizationIT.java
    directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/LookupAuthorizationIT.java
    directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/ModifyAuthorizationIT.java
    directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/MoveRenameAuthorizationIT.java
    directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/SearchAuthorizationIT.java
    directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/operations/add/PasswordHashingInterceptorTest.java
    directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/suites/MigratedStockCoreISuite.java
    directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/suites/StockCoreISuite.java

Modified: directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authn/SimpleAuthenticationIT.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authn/SimpleAuthenticationIT.java?rev=1395286&r1=1395285&r2=1395286&view=diff
==============================================================================
--- directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authn/SimpleAuthenticationIT.java (original)
+++ directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authn/SimpleAuthenticationIT.java Sun Oct  7 12:26:32 2012
@@ -41,6 +41,7 @@ import org.apache.directory.shared.ldap.
 import org.apache.directory.shared.ldap.model.name.Dn;
 import org.apache.directory.shared.util.Strings;
 import org.junit.After;
+import org.junit.AfterClass;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
@@ -77,6 +78,12 @@ public class SimpleAuthenticationIT exte
         IntegrationUtils.closeConnections();
     }
 
+    
+    @AfterClass
+    public static void after()
+    {
+        System.out.println( "SimpleAuthenticationIT tests done") ;
+    }
 
     /**
      * Check the creation of the admin account and persistence across restarts.

Modified: directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authn/ppolicy/PasswordPolicyTest.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authn/ppolicy/PasswordPolicyTest.java?rev=1395286&r1=1395285&r2=1395286&view=diff
==============================================================================
--- directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authn/ppolicy/PasswordPolicyTest.java (original)
+++ directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authn/ppolicy/PasswordPolicyTest.java Sun Oct  7 12:26:32 2012
@@ -72,6 +72,7 @@ import org.apache.directory.shared.ldap.
 import org.apache.directory.shared.ldap.model.message.ResultCodeEnum;
 import org.apache.directory.shared.ldap.model.name.Dn;
 import org.junit.After;
+import org.junit.AfterClass;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -132,6 +133,12 @@ public class PasswordPolicyTest extends 
     {
         IntegrationUtils.closeConnections();
     }
+    
+    @AfterClass
+    public static void after()
+    {
+        System.out.println( "PasswordPolicyTest tests done") ;
+    }
 
 
     @Test

Modified: directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AddAuthorizationIT.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AddAuthorizationIT.java?rev=1395286&r1=1395285&r2=1395286&view=diff
==============================================================================
--- directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AddAuthorizationIT.java (original)
+++ directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AddAuthorizationIT.java Sun Oct  7 12:26:32 2012
@@ -36,6 +36,7 @@ import org.apache.directory.shared.ldap.
 import org.apache.directory.shared.ldap.model.exception.LdapException;
 import org.apache.directory.shared.ldap.model.name.Dn;
 import org.junit.After;
+import org.junit.AfterClass;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -59,10 +60,11 @@ public class AddAuthorizationIT extends 
     }
 
 
-    @After
-    public void closeConnections()
+    @AfterClass
+    public static void closeConnections()
     {
         //IntegrationUtils.closeConnections();
+        System.out.println( "AddAuthorizationIT tests done") ;
     }
 
 

Modified: directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AdministratorsGroupIT.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AdministratorsGroupIT.java?rev=1395286&r1=1395285&r2=1395286&view=diff
==============================================================================
--- directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AdministratorsGroupIT.java (original)
+++ directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AdministratorsGroupIT.java Sun Oct  7 12:26:32 2012
@@ -34,6 +34,7 @@ import org.apache.directory.server.core.
 import org.apache.directory.shared.ldap.model.entry.Entry;
 import org.apache.directory.shared.ldap.model.name.Dn;
 import org.junit.After;
+import org.junit.AfterClass;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -63,6 +64,13 @@ public class AdministratorsGroupIT exten
         IntegrationUtils.closeConnections();
     }
 
+    
+    @AfterClass
+    public static void after()
+    {
+        System.out.println( "AdministratorsGroupIT tests done") ;
+    }
+
 
     boolean canReadAdministrators( LdapConnection connection ) throws Exception
     {

Modified: directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AuthorizationServiceAsAdminIT.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AuthorizationServiceAsAdminIT.java?rev=1395286&r1=1395285&r2=1395286&view=diff
==============================================================================
--- directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AuthorizationServiceAsAdminIT.java (original)
+++ directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AuthorizationServiceAsAdminIT.java Sun Oct  7 12:26:32 2012
@@ -44,6 +44,7 @@ import org.apache.directory.shared.ldap.
 import org.apache.directory.shared.ldap.model.name.Rdn;
 import org.apache.directory.shared.util.Strings;
 import org.junit.After;
+import org.junit.AfterClass;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -73,6 +74,13 @@ public class AuthorizationServiceAsAdmin
         IntegrationUtils.closeConnections();
     }
 
+    
+    @AfterClass
+    public static void after()
+    {
+        System.out.println( "AuthorizationServiceAsAdminIT tests done") ;
+    }
+
 
     /**
      * Makes sure the admin cannot delete the admin account.

Modified: directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AuthorizationServiceAsNonAdminIT.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AuthorizationServiceAsNonAdminIT.java?rev=1395286&r1=1395285&r2=1395286&view=diff
==============================================================================
--- directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AuthorizationServiceAsNonAdminIT.java (original)
+++ directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AuthorizationServiceAsNonAdminIT.java Sun Oct  7 12:26:32 2012
@@ -49,6 +49,7 @@ import org.apache.directory.shared.ldap.
 import org.apache.directory.shared.ldap.model.message.SearchScope;
 import org.apache.directory.shared.ldap.model.name.Dn;
 import org.apache.directory.shared.ldap.model.name.Rdn;
+import org.junit.AfterClass;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
@@ -63,6 +64,12 @@ import org.junit.runner.RunWith;
 @CreateDS(name = "AuthorizationServiceAsNonAdminIT")
 public class AuthorizationServiceAsNonAdminIT extends AbstractLdapTestUnit
 {
+    @AfterClass
+    public static void after()
+    {
+        System.out.println( "AuthorizationServiceAsNonAdminIT tests done") ;
+    }
+    
 
     /**
      * Makes sure a non-admin user cannot delete the admin account.

Modified: directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AuthzAuthnIT.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AuthzAuthnIT.java?rev=1395286&r1=1395285&r2=1395286&view=diff
==============================================================================
--- directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AuthzAuthnIT.java (original)
+++ directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/AuthzAuthnIT.java Sun Oct  7 12:26:32 2012
@@ -35,6 +35,7 @@ import org.apache.directory.server.core.
 import org.apache.directory.shared.ldap.model.entry.Entry;
 import org.apache.directory.shared.ldap.model.name.Dn;
 import org.junit.After;
+import org.junit.AfterClass;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -64,6 +65,13 @@ public class AuthzAuthnIT extends Abstra
         IntegrationUtils.closeConnections();
     }
 
+    
+    @AfterClass
+    public static void after()
+    {
+        System.out.println( "AuthzAuthnIT tests done") ;
+    }
+
 
     /**
      * Checks to make sure a user can authenticate with RootDSE as the

Modified: directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/CompareAuthorizationIT.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/CompareAuthorizationIT.java?rev=1395286&r1=1395285&r2=1395286&view=diff
==============================================================================
--- directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/CompareAuthorizationIT.java (original)
+++ directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/CompareAuthorizationIT.java Sun Oct  7 12:26:32 2012
@@ -38,6 +38,7 @@ import org.apache.directory.shared.ldap.
 import org.apache.directory.shared.ldap.model.exception.LdapNoPermissionException;
 import org.apache.directory.shared.ldap.model.name.Dn;
 import org.junit.After;
+import org.junit.AfterClass;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -52,7 +53,6 @@ import org.junit.runner.RunWith;
 @CreateDS(enableAccessControl = true, name = "CompareAuthorizationIT")
 public class CompareAuthorizationIT extends AbstractLdapTestUnit
 {
-
     @Before
     public void setService()
     {
@@ -66,6 +66,13 @@ public class CompareAuthorizationIT exte
         IntegrationUtils.closeConnections();
     }
 
+    
+    @AfterClass
+    public static void after()
+    {
+        System.out.println( "CompareAuthorizationIT tests done") ;
+    }
+
 
     /**
      * Checks if an attribute of a simple entry (an organizationalUnit's telephoneNumber)

Modified: directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/DeleteAuthorizationIT.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/DeleteAuthorizationIT.java?rev=1395286&r1=1395285&r2=1395286&view=diff
==============================================================================
--- directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/DeleteAuthorizationIT.java (original)
+++ directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/DeleteAuthorizationIT.java Sun Oct  7 12:26:32 2012
@@ -39,6 +39,7 @@ import org.apache.directory.shared.ldap.
 import org.apache.directory.shared.ldap.model.exception.LdapNoPermissionException;
 import org.apache.directory.shared.ldap.model.name.Dn;
 import org.junit.After;
+import org.junit.AfterClass;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -53,7 +54,6 @@ import org.junit.runner.RunWith;
 @CreateDS(enableAccessControl = true, name = "DeleteAuthorizationIT")
 public class DeleteAuthorizationIT extends AbstractLdapTestUnit
 {
-
     @Before
     public void setService()
     {
@@ -67,6 +67,13 @@ public class DeleteAuthorizationIT exten
         IntegrationUtils.closeConnections();
     }
 
+    
+    @AfterClass
+    public static void after()
+    {
+        System.out.println( "DeleteAuthorizationIT tests done") ;
+    }
+
 
     /**
      * Checks if a simple entry (organizationalUnit) can be deleted from the DIT at an

Modified: directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/GeneralAuthorizationIT.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/GeneralAuthorizationIT.java?rev=1395286&r1=1395285&r2=1395286&view=diff
==============================================================================
--- directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/GeneralAuthorizationIT.java (original)
+++ directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/GeneralAuthorizationIT.java Sun Oct  7 12:26:32 2012
@@ -29,6 +29,7 @@ import org.apache.directory.server.core.
 import org.apache.directory.server.core.integ.IntegrationUtils;
 import org.apache.directory.shared.ldap.model.message.ResultCodeEnum;
 import org.junit.After;
+import org.junit.AfterClass;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -43,7 +44,6 @@ import org.junit.runner.RunWith;
 @CreateDS(name = "GeneralAuthorizationIT")
 public class GeneralAuthorizationIT extends AbstractLdapTestUnit
 {
-
     @Before
     public void setService()
     {
@@ -57,6 +57,13 @@ public class GeneralAuthorizationIT exte
         IntegrationUtils.closeConnections();
     }
 
+    
+    @AfterClass
+    public static void after()
+    {
+        System.out.println( "GeneralAuthorizationIT tests done") ;
+    }
+
 
     /**
      * Checks to make sure we cannot create a malformed ACI missing two

Modified: directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/LookupAuthorizationIT.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/LookupAuthorizationIT.java?rev=1395286&r1=1395285&r2=1395286&view=diff
==============================================================================
--- directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/LookupAuthorizationIT.java (original)
+++ directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/LookupAuthorizationIT.java Sun Oct  7 12:26:32 2012
@@ -33,6 +33,7 @@ import org.apache.directory.server.core.
 import org.apache.directory.shared.ldap.model.entry.Entry;
 import org.apache.directory.shared.ldap.model.exception.LdapNoPermissionException;
 import org.apache.directory.shared.ldap.model.name.Dn;
+import org.junit.AfterClass;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -55,60 +56,67 @@ import org.junit.runner.RunWith;
 })
 public class LookupAuthorizationIT extends AbstractLdapTestUnit
 {
-@Before
-public void init()
-{
-    AutzIntegUtils.service = getService();
-}
-
-
-/**
- * Test a lookup( Dn ) operation with the ACI subsystem enabled
- */
-@Test
-public void testLookupACIEnabled() throws Exception
-{
-    getService().setAccessControlEnabled( true );
-    Dn dn = new Dn( "cn=test,ou=system" );
-
-    try
+    @Before
+    public void init()
     {
-        Entry entry = getService().getSession().lookup( dn );
-        fail();
+        AutzIntegUtils.service = getService();
     }
-    catch ( LdapNoPermissionException lnpe )
+
+    
+    @AfterClass
+    public static void after()
     {
+        System.out.println( "LookupAuthorizationIT tests done") ;
     }
 
-    createAccessControlSubentry(
-        "anybodySearch",
-        "{ " +
-            "  identificationTag \"searchAci\", " +
-            "  precedence 14, " +
-            "  authenticationLevel none, " +
-            "  itemOrUserFirst userFirst: " +
-            "  { " +
-            "    userClasses { allUsers }, " +
-            "    userPermissions " +
-            "    { " +
-            "      { " +
-            "        protectedItems {entry, allUserAttributeTypesAndValues}, " +
-            "        grantsAndDenials { grantRead, grantReturnDN, grantBrowse } " +
-            "      } " +
-            "    } " +
-            "  } " +
-            "}" );
-
-    Entry entry = getService().getSession().lookup( dn );
-
-    assertNotNull( entry );
-
-    // We should have 3 attributes
-    assertEquals( 3, entry.size() );
-
-    // Check that all the user attributes are present
-    assertEquals( "test", entry.get( "cn" ).getString() );
-    assertEquals( "sn_test", entry.get( "sn" ).getString() );
-    assertTrue( entry.contains( "objectClass", "top", "person" ) );
-}
+    
+    /**
+     * Test a lookup( Dn ) operation with the ACI subsystem enabled
+     */
+    @Test
+    public void testLookupACIEnabled() throws Exception
+    {
+        getService().setAccessControlEnabled( true );
+        Dn dn = new Dn( "cn=test,ou=system" );
+    
+        try
+        {
+            Entry entry = getService().getSession().lookup( dn );
+            fail();
+        }
+        catch ( LdapNoPermissionException lnpe )
+        {
+        }
+    
+        createAccessControlSubentry(
+            "anybodySearch",
+            "{ " +
+                "  identificationTag \"searchAci\", " +
+                "  precedence 14, " +
+                "  authenticationLevel none, " +
+                "  itemOrUserFirst userFirst: " +
+                "  { " +
+                "    userClasses { allUsers }, " +
+                "    userPermissions " +
+                "    { " +
+                "      { " +
+                "        protectedItems {entry, allUserAttributeTypesAndValues}, " +
+                "        grantsAndDenials { grantRead, grantReturnDN, grantBrowse } " +
+                "      } " +
+                "    } " +
+                "  } " +
+                "}" );
+    
+        Entry entry = getService().getSession().lookup( dn );
+    
+        assertNotNull( entry );
+    
+        // We should have 3 attributes
+        assertEquals( 3, entry.size() );
+    
+        // Check that all the user attributes are present
+        assertEquals( "test", entry.get( "cn" ).getString() );
+        assertEquals( "sn_test", entry.get( "sn" ).getString() );
+        assertTrue( entry.contains( "objectClass", "top", "person" ) );
+    }
 }

Modified: directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/ModifyAuthorizationIT.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/ModifyAuthorizationIT.java?rev=1395286&r1=1395285&r2=1395286&view=diff
==============================================================================
--- directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/ModifyAuthorizationIT.java (original)
+++ directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/ModifyAuthorizationIT.java Sun Oct  7 12:26:32 2012
@@ -50,6 +50,7 @@ import org.apache.directory.shared.ldap.
 import org.apache.directory.shared.ldap.model.message.ResultCodeEnum;
 import org.apache.directory.shared.ldap.model.name.Dn;
 import org.junit.After;
+import org.junit.AfterClass;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -64,7 +65,6 @@ import org.junit.runner.RunWith;
 @CreateDS(enableAccessControl = true, name = "ModifyAuthorizationIT")
 public class ModifyAuthorizationIT extends AbstractLdapTestUnit
 {
-
     @Before
     public void setService()
     {
@@ -78,6 +78,13 @@ public class ModifyAuthorizationIT exten
         IntegrationUtils.closeConnections();
     }
 
+    
+    @AfterClass
+    public static void after()
+    {
+        System.out.println( "ModifyAuthorizationIT tests done") ;
+    }
+
 
     /**
      * Checks if an attribute of a simple entry (an organizationalUnit) with an Rdn

Modified: directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/MoveRenameAuthorizationIT.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/MoveRenameAuthorizationIT.java?rev=1395286&r1=1395285&r2=1395286&view=diff
==============================================================================
--- directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/MoveRenameAuthorizationIT.java (original)
+++ directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/MoveRenameAuthorizationIT.java Sun Oct  7 12:26:32 2012
@@ -44,6 +44,7 @@ import org.apache.directory.shared.ldap.
 import org.apache.directory.shared.ldap.model.exception.LdapNoPermissionException;
 import org.apache.directory.shared.ldap.model.name.Dn;
 import org.junit.After;
+import org.junit.AfterClass;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -58,7 +59,6 @@ import org.junit.runner.RunWith;
 @CreateDS(name = "MoveRenameAuthorizationIT")
 public class MoveRenameAuthorizationIT extends AbstractLdapTestUnit
 {
-
     @Before
     public void setService()
     {
@@ -73,6 +73,13 @@ public class MoveRenameAuthorizationIT e
         IntegrationUtils.closeConnections();
     }
 
+    
+    @AfterClass
+    public static void after()
+    {
+        System.out.println( "MoveRenameAuthorizationIT tests done") ;
+    }
+
 
     public boolean checkCanRenameAs( String uid, String password, String entryRdn, String newNameRdn ) throws Exception
     {

Modified: directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/SearchAuthorizationIT.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/SearchAuthorizationIT.java?rev=1395286&r1=1395285&r2=1395286&view=diff
==============================================================================
--- directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/SearchAuthorizationIT.java (original)
+++ directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/authz/SearchAuthorizationIT.java Sun Oct  7 12:26:32 2012
@@ -51,6 +51,7 @@ import org.apache.directory.shared.ldap.
 import org.apache.directory.shared.ldap.model.message.SearchScope;
 import org.apache.directory.shared.ldap.model.name.Dn;
 import org.junit.After;
+import org.junit.AfterClass;
 import org.junit.Before;
 import org.junit.Ignore;
 import org.junit.Test;
@@ -70,7 +71,6 @@ public class SearchAuthorizationIT exten
     // to avoid creating too many connections during recursive operations
     private LdapConnection reusableAdminCon;
 
-
     @Before
     public void setService() throws Exception
     {
@@ -85,6 +85,13 @@ public class SearchAuthorizationIT exten
         IntegrationUtils.closeConnections();
     }
 
+    
+    @AfterClass
+    public static void after()
+    {
+        System.out.println( "SearchAuthorizationIT tests done") ;
+    }
+
     /**
      * The search results of tests are added to this map via put (<String, Entry>)
      * the map is also cleared before each search test.  This allows further inspections

Copied: directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/jndi/RootDSEJndiIT.java (from r1394453, directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/jndi/RootDSEIT.java)
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/jndi/RootDSEJndiIT.java?p2=directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/jndi/RootDSEJndiIT.java&p1=directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/jndi/RootDSEIT.java&r1=1394453&r2=1395286&rev=1395286&view=diff
==============================================================================
--- directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/jndi/RootDSEIT.java (original)
+++ directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/jndi/RootDSEJndiIT.java Sun Oct  7 12:26:32 2012
@@ -50,7 +50,7 @@ import org.junit.runner.RunWith;
  */
 @RunWith(FrameworkRunner.class)
 @CreateDS(name = "RootDSEIT")
-public class RootDSEIT extends AbstractLdapTestUnit
+public class RootDSEJndiIT extends AbstractLdapTestUnit
 {
 
     /**

Modified: directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/operations/add/PasswordHashingInterceptorTest.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/operations/add/PasswordHashingInterceptorTest.java?rev=1395286&r1=1395285&r2=1395286&view=diff
==============================================================================
--- directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/operations/add/PasswordHashingInterceptorTest.java (original)
+++ directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/operations/add/PasswordHashingInterceptorTest.java Sun Oct  7 12:26:32 2012
@@ -45,6 +45,8 @@ import org.apache.directory.shared.ldap.
 import org.apache.directory.shared.ldap.model.entry.ModificationOperation;
 import org.apache.directory.shared.ldap.model.name.Dn;
 import org.apache.directory.shared.ldap.model.schema.AttributeType;
+import org.junit.After;
+import org.junit.AfterClass;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
@@ -64,6 +66,11 @@ import org.junit.runner.RunWith;
 })
 public class PasswordHashingInterceptorTest extends AbstractLdapTestUnit
 {
+    @AfterClass
+    public static void after()
+    {
+        System.out.println( "PasswordHashingInterceptorTestIT tests done");
+    }
 
     @Test
     public void testAddWithPlainPassword() throws Exception

Modified: directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/suites/MigratedStockCoreISuite.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/suites/MigratedStockCoreISuite.java?rev=1395286&r1=1395285&r2=1395286&view=diff
==============================================================================
--- directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/suites/MigratedStockCoreISuite.java (original)
+++ directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/suites/MigratedStockCoreISuite.java Sun Oct  7 12:26:32 2012
@@ -57,7 +57,6 @@ import org.junit.runners.Suite;
 @CreateDS(enableAccessControl = true, name = "MigratedStockCoreISuite-DS")
 @Suite.SuiteClasses(
     {
-
         // authn
         SimpleAuthenticationIT.class,
         PasswordPolicyTest.class,

Modified: directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/suites/StockCoreISuite.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/suites/StockCoreISuite.java?rev=1395286&r1=1395285&r2=1395286&view=diff
==============================================================================
--- directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/suites/StockCoreISuite.java (original)
+++ directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/suites/StockCoreISuite.java Sun Oct  7 12:26:32 2012
@@ -33,7 +33,7 @@ import org.apache.directory.server.core.
 import org.apache.directory.server.core.jndi.ObjStateFactoryIT;
 import org.apache.directory.server.core.jndi.RFC2713IT;
 import org.apache.directory.server.core.jndi.ReferralIT;
-import org.apache.directory.server.core.jndi.RootDSEIT;
+import org.apache.directory.server.core.jndi.RootDSEJndiIT;
 import org.apache.directory.server.core.jndi.SimpleBindJndiIT;
 import org.apache.directory.server.core.jndi.UniqueMemberIT;
 import org.apache.directory.server.core.jndi.referral.AddReferralIT;
@@ -112,7 +112,8 @@ import org.junit.runners.Suite;
         ObjStateFactoryIT.class,
         ReferralIT.class,
         RFC2713IT.class,
-        RootDSEIT.class,
+        RootDSEJndiIT.class,
+        SimpleBindJndiIT.class,
         UniqueMemberIT.class,
 
         // jndi.referral
@@ -125,7 +126,6 @@ import org.junit.runners.Suite;
         RenameReferralIgnoreIT.class,
         RenameReferralIT.class,
         SearchReferralIT.class,
-        SimpleBindJndiIT.class,
 
         // normalization
         NormalizationServiceIT.class,
@@ -139,8 +139,7 @@ import org.junit.runners.Suite;
         // operations.lookup
         LookupIT.class,
         ExistsIT.class,
-        // LookupPerfIT.class,
-
+        
         // operations.modify
         ModifyAddIT.class,
         ModifyDelIT.class,
@@ -151,6 +150,7 @@ import org.junit.runners.Suite;
         AliasSearchIT.class,
         DIRSERVER759IT.class,
         SearchIT.class,
+        
         // SearchPerfIT.class,
         SearchWithIndicesIT.class,
         SearchBinaryIT.class,



Re: svn commit: r1395286 - in /directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core: authn/ authn/ppolicy/ authz/ jndi/ operations/add/ suites/

Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 10/7/12 8:08 PM, Emmanuel Lécharny a écrit :
> Le 10/7/12 6:59 PM, Stefan Seelmann a écrit :
>> On 07.10.2012 17:22, Emmanuel Lécharny wrote:
>>> Hi Stefan ! Glad to see you around :)
>>>
>>> Le 10/7/12 3:03 PM, Stefan Seelmann a écrit :
>>>> On 07.10.2012 14:26, elecharny@apache.org wrote:
>>>>> Author: elecharny
>>>>> Date: Sun Oct  7 12:26:32 2012
>>>>> New Revision: 1395286
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=1395286&view=rev
>>>>> Log:
>>>>> Added a sysout to know which test is being processed (it's useful
>>>>> when running the suite, as the tests are quite long)
>>>>>
>>>>> Modified:
>>>>> directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/suites/MigratedStockCoreISuite.java
>>>>>
>>>>> directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/suites/StockCoreISuite.java
>>>>>
>>>> Maybe a dumb question but why not just remove the suites completely?
>>> What I'm doing currently is to migrate the JNDI suites to use the API
>>> instead (but keeping the pure JNDI tests just to be sure that we still
>>> can access to the server using JNDI) to the Migrated suite. Once done,
>>> I'll remove the StockCoreISuite. But this is a bit orthogonal to your
>>> question...
>>>
>>> The reason we have the suite is because we can define some suite 
>>> related
>>> server, instead of having to declare that for every single class. At
>>> least, this was the rational. Is it still useful ? That's
>>> questionable... See later.
>>>
>>>> In pom.xml I replaced the current inclusion of the suites:
>>>>
>>>> - <include>**/*ISuite.java</include>
>>>> +                <include>**/*IT.java</include>
>>>> + <include>**/*Test.java</include>
>>>>
>>>> The result:
>>>> * The build of core-integ does not take longer, rather it is some
>>>> seconds faster!
>>>> * 711 tests were run instead of 684 when using the suites, so it seems
>>>> some test classes are missing in the suite classes.
>>> Once upon a time, the IT tests were only ran when you use the
>>> 'integration' profile (thus the -Dintegration parameter in the command
>>> line).
>>>
>>> I'm not sure this is a good idea to have this flag anymore : all those
>>> tests are mandatory, and needed to be sure that the server works, and I
>>> personally always use this flag *before* committing.
>>> So, IMO, we may make this a default build profile, and run all the 
>>> tests
>>> as you declared them (ie the double include).
>> In fact it is already activated by default. The -Dintegration flag has
>> no effect, the integration tests run even without that flag.
> Doh...
>>
>> Looking into the core-integ/pom.xml there are three profiles for tests:
>> * integration: activated by default, runs the (two) suites
>> * integration-all-partitions: activated with -Dtest-all-partitions, runs
>> the suites 3 times with JDBM, AVL, and LDIF partition, fails currently,
>> not sure if this is useful
> I guess it was added when you were working on the HBase partition, 
> just in case we wanted to add some new partitions. Don't remember 
> exactly the context...
>> * quicktests: activated with -Dquicktest, only runs 9 tests, not at all
>> useful IMO. Should it be removed?
> IMO, yes.
>>
>>> I'd like to push it a bit further : do we *really* need the suite 
>>> system
>>> at all ? I mean, we want to be able to run one test or another in
>>> eclipse while debugging, so everything we declare in a suite annotation
>>> will just be overriden by the annotations we have in each tests : this
>>> make it doubtful that the suite annotations are useful at all... Not to
>>> mention that it makes the annotation's handling way more simple if we
>>> don't have to handle the suites...
>> I agree.
>>
>> And I see another problem with suites: It happens that one forgets to
>> add a new test class ot the @Suite.SuiteClasses list. As surefire is
>> configured to only run the suites (<include>**/*ISuite.java</include>)
>> the not added test class won't run. IMO suites are more harmful than 
>> useful.
> I agree.
>
> I can remove them if nobpdy objects.
>
I removed the suites, and renamed the *Test classes to *IT classes, so 
that we don't have to add inclusion of *Test.class.

I also removed the QuickTest profile from the core-integ pom.xml.

I think we have to do the same clean up in server-integ.


-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com


Re: svn commit: r1395286 - in /directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core: authn/ authn/ppolicy/ authz/ jndi/ operations/add/ suites/

Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 10/7/12 6:59 PM, Stefan Seelmann a écrit :
> On 07.10.2012 17:22, Emmanuel Lécharny wrote:
>> Hi Stefan ! Glad to see you around :)
>>
>> Le 10/7/12 3:03 PM, Stefan Seelmann a écrit :
>>> On 07.10.2012 14:26, elecharny@apache.org wrote:
>>>> Author: elecharny
>>>> Date: Sun Oct  7 12:26:32 2012
>>>> New Revision: 1395286
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1395286&view=rev
>>>> Log:
>>>> Added a sysout to know which test is being processed (it's useful
>>>> when running the suite, as the tests are quite long)
>>>>
>>>> Modified:
>>>>      
>>>> directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/suites/MigratedStockCoreISuite.java
>>>>
>>>>      
>>>> directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/suites/StockCoreISuite.java
>>>>
>>> Maybe a dumb question but why not just remove the suites completely?
>> What I'm doing currently is to migrate the JNDI suites to use the API
>> instead (but keeping the pure JNDI tests just to be sure that we still
>> can access to the server using JNDI) to the Migrated suite. Once done,
>> I'll remove the StockCoreISuite. But this is a bit orthogonal to your
>> question...
>>
>> The reason we have the suite is because we can define some suite related
>> server, instead of having to declare that for every single class. At
>> least, this was the rational. Is it still useful ? That's
>> questionable... See later.
>>
>>> In pom.xml I replaced the current inclusion of the suites:
>>>
>>> -                <include>**/*ISuite.java</include>
>>> +                <include>**/*IT.java</include>
>>> +                <include>**/*Test.java</include>
>>>
>>> The result:
>>> * The build of core-integ does not take longer, rather it is some
>>> seconds faster!
>>> * 711 tests were run instead of 684 when using the suites, so it seems
>>> some test classes are missing in the suite classes.
>> Once upon a time, the IT tests were only ran when you use the
>> 'integration' profile (thus the -Dintegration parameter in the command
>> line).
>>
>> I'm not sure this is a good idea to have this flag anymore : all those
>> tests are mandatory, and needed to be sure that the server works, and I
>> personally always use this flag *before* committing.
>> So, IMO, we may make this a default build profile, and run all the tests
>> as you declared them (ie the double include).
> In fact it is already activated by default. The -Dintegration flag has
> no effect, the integration tests run even without that flag.
Doh...
>
> Looking into the core-integ/pom.xml there are three profiles for tests:
> * integration: activated by default, runs the (two) suites
> * integration-all-partitions: activated with -Dtest-all-partitions, runs
> the suites 3 times with JDBM, AVL, and LDIF partition, fails currently,
> not sure if this is useful
I guess it was added when you were working on the HBase partition, just 
in case we wanted to add some new partitions. Don't remember exactly the 
context...
> * quicktests: activated with -Dquicktest, only runs 9 tests, not at all
> useful IMO. Should it be removed?
IMO, yes.
>
>> I'd like to push it a bit further : do we *really* need the suite system
>> at all ? I mean, we want to be able to run one test or another in
>> eclipse while debugging, so everything we declare in a suite annotation
>> will just be overriden by the annotations we have in each tests : this
>> make it doubtful that the suite annotations are useful at all... Not to
>> mention that it makes the annotation's handling way more simple if we
>> don't have to handle the suites...
> I agree.
>
> And I see another problem with suites: It happens that one forgets to
> add a new test class ot the @Suite.SuiteClasses list. As surefire is
> configured to only run the suites (<include>**/*ISuite.java</include>)
> the not added test class won't run. IMO suites are more harmful than useful.
I agree.

I can remove them if nobpdy objects.

FYI, I'm waiting for MINA 2.0.7 to be released (next tuesday) to start 
cutting a new ADS release. So I have 1 full day to spend on such a task.


-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com


Re: svn commit: r1395286 - in /directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core: authn/ authn/ppolicy/ authz/ jndi/ operations/add/ suites/

Posted by Stefan Seelmann <ma...@stefan-seelmann.de>.
On 07.10.2012 17:22, Emmanuel Lécharny wrote:
> Hi Stefan ! Glad to see you around :)
> 
> Le 10/7/12 3:03 PM, Stefan Seelmann a écrit :
>> On 07.10.2012 14:26, elecharny@apache.org wrote:
>>> Author: elecharny
>>> Date: Sun Oct  7 12:26:32 2012
>>> New Revision: 1395286
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1395286&view=rev
>>> Log:
>>> Added a sysout to know which test is being processed (it's useful
>>> when running the suite, as the tests are quite long)
>>>
>>> Modified:
>>>     
>>> directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/suites/MigratedStockCoreISuite.java
>>>
>>>     
>>> directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/suites/StockCoreISuite.java
>>>
>> Maybe a dumb question but why not just remove the suites completely?
> What I'm doing currently is to migrate the JNDI suites to use the API
> instead (but keeping the pure JNDI tests just to be sure that we still
> can access to the server using JNDI) to the Migrated suite. Once done,
> I'll remove the StockCoreISuite. But this is a bit orthogonal to your
> question...
> 
> The reason we have the suite is because we can define some suite related
> server, instead of having to declare that for every single class. At
> least, this was the rational. Is it still useful ? That's
> questionable... See later.
> 
>>
>> In pom.xml I replaced the current inclusion of the suites:
>>
>> -                <include>**/*ISuite.java</include>
>> +                <include>**/*IT.java</include>
>> +                <include>**/*Test.java</include>
>>
>> The result:
>> * The build of core-integ does not take longer, rather it is some
>> seconds faster!
>> * 711 tests were run instead of 684 when using the suites, so it seems
>> some test classes are missing in the suite classes.
> Once upon a time, the IT tests were only ran when you use the
> 'integration' profile (thus the -Dintegration parameter in the command
> line).
> 
> I'm not sure this is a good idea to have this flag anymore : all those
> tests are mandatory, and needed to be sure that the server works, and I
> personally always use this flag *before* committing.

> So, IMO, we may make this a default build profile, and run all the tests
> as you declared them (ie the double include).

In fact it is already activated by default. The -Dintegration flag has
no effect, the integration tests run even without that flag.

Looking into the core-integ/pom.xml there are three profiles for tests:
* integration: activated by default, runs the (two) suites
* integration-all-partitions: activated with -Dtest-all-partitions, runs
the suites 3 times with JDBM, AVL, and LDIF partition, fails currently,
not sure if this is useful
* quicktests: activated with -Dquicktest, only runs 9 tests, not at all
useful IMO. Should it be removed?

> I'd like to push it a bit further : do we *really* need the suite system
> at all ? I mean, we want to be able to run one test or another in
> eclipse while debugging, so everything we declare in a suite annotation
> will just be overriden by the annotations we have in each tests : this
> make it doubtful that the suite annotations are useful at all... Not to
> mention that it makes the annotation's handling way more simple if we
> don't have to handle the suites...

I agree.

And I see another problem with suites: It happens that one forgets to
add a new test class ot the @Suite.SuiteClasses list. As surefire is
configured to only run the suites (<include>**/*ISuite.java</include>)
the not added test class won't run. IMO suites are more harmful than useful.

Kind Regards,
Stefan


Re: svn commit: r1395286 - in /directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core: authn/ authn/ppolicy/ authz/ jndi/ operations/add/ suites/

Posted by Emmanuel Lécharny <el...@gmail.com>.
Hi Stefan ! Glad to see you around :)

Le 10/7/12 3:03 PM, Stefan Seelmann a écrit :
> On 07.10.2012 14:26, elecharny@apache.org wrote:
>> Author: elecharny
>> Date: Sun Oct  7 12:26:32 2012
>> New Revision: 1395286
>>
>> URL: http://svn.apache.org/viewvc?rev=1395286&view=rev
>> Log:
>> Added a sysout to know which test is being processed (it's useful when running the suite, as the tests are quite long)
>>
>> Modified:
>>      directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/suites/MigratedStockCoreISuite.java
>>      directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/suites/StockCoreISuite.java
> Maybe a dumb question but why not just remove the suites completely?
What I'm doing currently is to migrate the JNDI suites to use the API 
instead (but keeping the pure JNDI tests just to be sure that we still 
can access to the server using JNDI) to the Migrated suite. Once done, 
I'll remove the StockCoreISuite. But this is a bit orthogonal to your 
question...

The reason we have the suite is because we can define some suite related 
server, instead of having to declare that for every single class. At 
least, this was the rational. Is it still useful ? That's 
questionable... See later.

>
> In pom.xml I replaced the current inclusion of the suites:
>
> -                <include>**/*ISuite.java</include>
> +                <include>**/*IT.java</include>
> +                <include>**/*Test.java</include>
>
> The result:
> * The build of core-integ does not take longer, rather it is some
> seconds faster!
> * 711 tests were run instead of 684 when using the suites, so it seems
> some test classes are missing in the suite classes.
Once upon a time, the IT tests were only ran when you use the 
'integration' profile (thus the -Dintegration parameter in the command 
line).

I'm not sure this is a good idea to have this flag anymore : all those 
tests are mandatory, and needed to be sure that the server works, and I 
personally always use this flag *before* committing.

So, IMO, we may make this a default build profile, and run all the tests 
as you declared them (ie the double include).

I'd like to push it a bit further : do we *really* need the suite system 
at all ? I mean, we want to be able to run one test or another in 
eclipse while debugging, so everything we declare in a suite annotation 
will just be overriden by the annotations we have in each tests : this 
make it doubtful that the suite annotations are useful at all... Not to 
mention that it makes the annotation's handling way more simple if we 
don't have to handle the suites...

Thoughst ?


-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com


Re: svn commit: r1395286 - in /directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core: authn/ authn/ppolicy/ authz/ jndi/ operations/add/ suites/

Posted by Stefan Seelmann <ma...@stefan-seelmann.de>.
On 07.10.2012 14:26, elecharny@apache.org wrote:
> Author: elecharny
> Date: Sun Oct  7 12:26:32 2012
> New Revision: 1395286
> 
> URL: http://svn.apache.org/viewvc?rev=1395286&view=rev
> Log:
> Added a sysout to know which test is being processed (it's useful when running the suite, as the tests are quite long)
> 
> Modified:
>     directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/suites/MigratedStockCoreISuite.java
>     directory/apacheds/trunk/core-integ/src/test/java/org/apache/directory/server/core/suites/StockCoreISuite.java

Maybe a dumb question but why not just remove the suites completely?

In pom.xml I replaced the current inclusion of the suites:

-                <include>**/*ISuite.java</include>
+                <include>**/*IT.java</include>
+                <include>**/*Test.java</include>

The result:
* The build of core-integ does not take longer, rather it is some
seconds faster!
* 711 tests were run instead of 684 when using the suites, so it seems
some test classes are missing in the suite classes.

Kind Regards,
Stefan