You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Thomas Mueller (JIRA)" <ji...@apache.org> on 2015/08/28 09:41:45 UTC

[jira] [Commented] (OAK-3167) [Blob GC] Wrong time units for blobGcMaxAge are passed from SegmentNodeStoreService

    [ https://issues.apache.org/jira/browse/OAK-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718156#comment-14718156 ] 

Thomas Mueller commented on OAK-3167:
-------------------------------------

I wonder, would it be possible to add a test case as well? I mean, sure it's fixed, but why is there no test case that failed without the fix? Without a good test case, we risk running into the same (or worse) problems again, with each change of Oak in that area. And this is a really important problem area: nobody wants to lose data.

> [Blob GC] Wrong time units for blobGcMaxAge are passed from SegmentNodeStoreService
> -----------------------------------------------------------------------------------
>
>                 Key: OAK-3167
>                 URL: https://issues.apache.org/jira/browse/OAK-3167
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: blob, segmentmk
>            Reporter: Amit Jain
>            Assignee: Amit Jain
>            Priority: Critical
>             Fix For: 1.2.4, 1.3.4, 1.0.18
>
>
> MarkSweepGarbageCollector#maxLastModifiedInterval expects time in millis while SegmentNodeStoreService passes the parameter in seconds. Due to this any blobs created after marking references and may be garbage collected.
> This can lead to lucene index corruption if async indexing run happened simultaneously with garbage collection. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)