[GitHub] nifi pull request #1213: NIFI-3029: QueryDatabaseTable supports max fragment...

[mattyb149 <gi...@git.apache.org>]

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1213#discussion_r91107893
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java ---
    @@ -120,6 +120,15 @@
                 .addValidator(StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR)
                 .build();
     
    +    public static final PropertyDescriptor MAX_FRAGMENTS = new PropertyDescriptor.Builder()
    +            .name("Maximum Number of Fragments")
    +            .description("The maximum number of fragments. If not specified, there is no maximum. " +
    +                    "This prevents OutOfMemoryError when this processor ingests huge table.")
    +            .defaultValue("1000")
    --- End diff --
    
    Since this is a new property and it is optional, the default behavior should be the same as if the property were not there (so the behavior does not change for flows created before the property was available). I'm thinking the default value should be empty.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---