[GitHub] [spark] attilapiros commented on a change in pull request #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter

[GitBox <gi...@apache.org>]

attilapiros commented on a change in pull request #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter
URL: https://github.com/apache/spark/pull/24365#discussion_r275952061
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -1687,6 +1687,15 @@ object SQLConf {
       .booleanConf
       .createWithDefault(false)
 
+  val LEGACY_PASS_PARTITION_BY_AS_OPTIONS =
+    buildConf("spark.sql.legacy.sources.write.passPartitionByAsOptions")
+      .internal()
 
 Review comment:
   Are you sure this must be internal?
   
   I see some of the previous ones with `LEGACY_` prefix are internal but before them there are a few externals: `LEGACY_REPLACE_DATABRICKS_SPARK_AVRO_ENABLED` and `LEGACY_SIZE_OF_NULL`. So what is the reason defining this as internal? 
   
   I assume if we expect the users to set it it then it must be external. 
   What is your (and the others) opinion?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org