[jira] [Comment Edited] (WW-4094) struts.allowed.action.names inconsistency

["Johno Crawford (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WW-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13676435#comment-13676435 ] 

Johno Crawford edited comment on WW-4094 at 6/5/13 10:35 PM:
-------------------------------------------------------------

We are observing the same misbehaviour in cleanupActionName.

{code}
2013-06-05 20:20:33,881 WARN  [http-8080-exec-5] (org.apache.struts2.dispatcher.mapper.DefaultActionMapper) Action [logout_ok] do not match allowed action names pattern [[a-z]*[A-Z]*[0-9]*[.\-_!/]*], cleaning it up! [userId=1 url=/account/logout_ok referer=null ip=127.0.0.1 parameters=[token:7f4a0dfce0]]
{code}
                
      was (Author: johno):
    We are observing the same misbehaviour in cleanupActionName.

2013-06-05 20:20:33,881 WARN  [http-8080-exec-5] (org.apache.struts2.dispatcher.mapper.DefaultActionMapper) Action [logout_ok] do not match allowed action names pattern [[a-z]*[A-Z]*[0-9]*[.\-_!/]*], cleaning it up! [userId=1 url=/account/logout_ok referer=null ip=127.0.0.1 parameters=[token:7f4a0dfce0]]
{code}test{code}
                  
> struts.allowed.action.names inconsistency
> -----------------------------------------
>
>                 Key: WW-4094
>                 URL: https://issues.apache.org/jira/browse/WW-4094
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.3.14.3
>            Reporter: Andreas Sachs
>            Priority: Minor
>
> I think there is a inconsistency in DefaultActionMapper.cleanupActionName
> According to http://struts.apache.org/development/2.x/docs/s2-015.html struts.allowed.action.names defines a regex the action name must match.
> The default regex is: [a-z]*[A-Z]*[0-9]*[.\-_!/]*
> I have an action with the name "core_blz"
> This action name does not match the regex (underscore is not at the end)(maybe the default value should be changed).
> DefaultActionMapper reports Action [#0] do not match allowed action names pattern [#1], cleaning it up!
> But the cleaned action name is still core_blz.
> If this function is only to remove suspicious characters, then the warning should not be displayed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira