You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/05/19 18:11:27 UTC
[GitHub] [ozone] adoroszlai opened a new pull request, #3433: HDDS-6097. Upgrade to Ratis 2.3.0, gRPC 1.44.0, Netty 4.1.74
adoroszlai opened a new pull request, #3433:
URL: https://github.com/apache/ozone/pull/3433
## What changes were proposed in this pull request?
Upgrade to Ratis 2.3.0. Includes bump to gRPC 1.44.0, Netty 4.1.74.
https://issues.apache.org/jira/browse/HDDS-6097
## How was this patch tested?
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/runs/6511490805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3433: HDDS-6097. Upgrade to Ratis 2.3.0, gRPC 1.44.0, Netty 4.1.74
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3433:
URL: https://github.com/apache/ozone/pull/3433#issuecomment-1132629946
Thanks @captainzmc, @kerneltime, @neils-dev, @smengcl for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3433: HDDS-6097. Upgrade to Ratis 2.3.0, gRPC 1.44.0, Netty 4.1.74
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3433:
URL: https://github.com/apache/ozone/pull/3433#issuecomment-1132044292
@neils-dev please review if you have time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] neils-dev commented on a diff in pull request #3433: HDDS-6097. Upgrade to Ratis 2.3.0, gRPC 1.44.0, Netty 4.1.74
Posted by GitBox <gi...@apache.org>.
neils-dev commented on code in PR #3433:
URL: https://github.com/apache/ozone/pull/3433#discussion_r877626102
##########
pom.xml:
##########
@@ -195,12 +195,12 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<!-- Maven protoc compiler -->
<protobuf-maven-plugin.version>0.5.1</protobuf-maven-plugin.version>
- <grpc.protobuf-compile.version>3.12.0</grpc.protobuf-compile.version>
+ <grpc.protobuf-compile.version>3.19.2</grpc.protobuf-compile.version>
<os-maven-plugin.version>1.5.0.Final</os-maven-plugin.version>
- <netty.version>4.1.63.Final</netty.version>
- <io.grpc.version>1.38.0</io.grpc.version>
- <tcnative.version>2.0.38.Final</tcnative.version> <!-- See table for correct version -->
+ <netty.version>4.1.74.Final</netty.version>
+ <io.grpc.version>1.44.0</io.grpc.version>
+ <tcnative.version>2.0.48.Final</tcnative.version> <!-- See table for correct version -->
Review Comment:
Thanks @adoroszlai for this upgrade to the build. We discussed previously that by upgrading `Netty` to _4.1.74_, the bill-of-materials, BOM, contains the versioning dependencies for netty and tcnative (not so for the previous version). Since the versioning of netty & tcnative is controlled by the BOM, can we _**remove**_ the explicit `tcnative.version` declaration here and its use in the supporting pom.xml files?
The versioning between netty and tcnative should be set by the BOM now if I understood you correctly. I removed the explicit version property for tcnative from the main pom file and its uses for `netty-tcnative` in the ozone-manager and ozone-common, however I needed to set the classifier. Does removing the explicit versioning property for `tcnative.version` and relying on the BOM to maintain consistency work for our build environment?
Previous comment on netty bom upgrade: https://github.com/apache/ozone/pull/2945#discussion_r811622506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #3433: HDDS-6097. Upgrade to Ratis 2.3.0, gRPC 1.44.0, Netty 4.1.74
Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3433:
URL: https://github.com/apache/ozone/pull/3433#issuecomment-1132080858
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #3433: HDDS-6097. Upgrade to Ratis 2.3.0, gRPC 1.44.0, Netty 4.1.74
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #3433:
URL: https://github.com/apache/ozone/pull/3433#discussion_r877881288
##########
pom.xml:
##########
@@ -195,12 +195,12 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<!-- Maven protoc compiler -->
<protobuf-maven-plugin.version>0.5.1</protobuf-maven-plugin.version>
- <grpc.protobuf-compile.version>3.12.0</grpc.protobuf-compile.version>
+ <grpc.protobuf-compile.version>3.19.2</grpc.protobuf-compile.version>
<os-maven-plugin.version>1.5.0.Final</os-maven-plugin.version>
- <netty.version>4.1.63.Final</netty.version>
- <io.grpc.version>1.38.0</io.grpc.version>
- <tcnative.version>2.0.38.Final</tcnative.version> <!-- See table for correct version -->
+ <netty.version>4.1.74.Final</netty.version>
+ <io.grpc.version>1.44.0</io.grpc.version>
+ <tcnative.version>2.0.48.Final</tcnative.version> <!-- See table for correct version -->
Review Comment:
Thanks @neils-dev for the reminder. I plan to do this separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3433: HDDS-6097. Upgrade to Ratis 2.3.0, gRPC 1.44.0, Netty 4.1.74
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3433:
URL: https://github.com/apache/ozone/pull/3433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org