You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2011/03/07 22:28:05 UTC

DO NOT REPLY [Bug 48548] [PATCH] FOP doesn't support change bar generation

https://issues.apache.org/bugzilla/show_bug.cgi?id=48548

--- Comment #13 from Stephan Thesing <th...@gmx.de> 2011-03-07 16:28:00 EST ---
Created an attachment (id=26741)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26741)
New change bar patch against /trunk

Attached is a new patch that adds change bar output and change-bar-begin/end
processing.
The output is done in AbstractRenderer.java by drawing change bar areas if an
area to be drawn is affected by change bars.
As such, it is not very efficient, i.e., it is not checked, if change bars
areas overlap.
Also, when drawing change bars for consecutive lines, the change bars are drawn
with the same height as the line area, causing gaps between the change bars (as
lines are offset).
This has been run through checkstyle.

The remaining functionality is very much the same as the first patch presented
one year (sic) ago.
Although 46 files are touched, most changes are quite trivial (adding recording
of change bars at areas or layout managers).

The test case attached to this PR is now handled correctly.

Missing:
 Unit tests
 extensive testing.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.