You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/18 06:59:02 UTC

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #15909: Fix append mode for WASB remote logging on v12

ephraimbuddy commented on a change in pull request #15909:
URL: https://github.com/apache/airflow/pull/15909#discussion_r634097505



##########
File path: airflow/providers/microsoft/azure/log/wasb_task_handler.py
##########
@@ -189,6 +189,7 @@ def wasb_write(self, log: str, remote_log_location: str, append: bool = True) ->
                 log,
                 self.wasb_container,
                 remote_log_location,
+                overwrite=True

Review comment:
       ```suggestion
                   overwrite=append
   ```
   I think we should use the function parameter instead of hard-coding




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org