You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "yjshen (via GitHub)" <gi...@apache.org> on 2023/04/30 08:03:13 UTC
[GitHub] [arrow-datafusion] yjshen opened a new pull request, #6166: feat: make threshold for using scalar update in aggregate configurable
yjshen opened a new pull request, #6166:
URL: https://github.com/apache/arrow-datafusion/pull/6166
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6166: feat: make threshold for using scalar update in aggregate configurable
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6166:
URL: https://github.com/apache/arrow-datafusion/pull/6166#discussion_r1181560644
##########
datafusion/common/src/config.rs:
##########
@@ -260,6 +263,23 @@ config_namespace! {
}
}
+config_namespace! {
+ /// Options related to aggregate execution
+ pub struct AggregateOptions {
+ /// Specifies the threshold for using `ScalarValue`s to update
+ /// accumulators during high-cardinality aggregations for each input batch.
+ ///
+ /// The aggregation is considered high-cardinality if the number of affected groups
+ /// is greater than or equal to `batch_size / scalar_update_factor`. In such cases,
+ /// `ScalarValue`s are utilized for updating accumulators, rather than the default
+ /// batch-slice approach. This can lead to performance improvements.
+ ///
+ /// By adjusting the `scalar_update_factor`, you can balance the trade-off between
Review Comment:
💯 for the text helping users understand the tradeoff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yjshen merged pull request #6166: feat: make threshold for using scalar update in aggregate configurable
Posted by "yjshen (via GitHub)" <gi...@apache.org>.
yjshen merged PR #6166:
URL: https://github.com/apache/arrow-datafusion/pull/6166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yjshen commented on pull request #6166: feat: make threshold for using scalar update in aggregate configurable
Posted by "yjshen (via GitHub)" <gi...@apache.org>.
yjshen commented on PR #6166:
URL: https://github.com/apache/arrow-datafusion/pull/6166#issuecomment-1529758653
Thanks for the review @alamb! ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org