You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/02/07 22:38:43 UTC
[kudu-CR] [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15187
Change subject: [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest
......................................................................
[tests] address flakiness in MasterReplicationAndRpcSizeLimitTest
Leader master can change after processing a request and before related
metrics are read from a new leader master. To avoid flakiness, get the
sum of read values for the metric across all masters in the cluster and
verify the result against the expected numbers.
Change-Id: I2f99f32d570680910a78e5181885b697b8743318
---
M src/kudu/integration-tests/master_replication-itest.cc
1 file changed, 27 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/15187/1
--
To view, visit http://gerrit.cloudera.org:8080/15187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f99f32d570680910a78e5181885b697b8743318
Gerrit-Change-Number: 15187
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15187 )
Change subject: [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest
......................................................................
Patch Set 2: Code-Review+2
Out of curiosity, are there any other tests that are vulnerable to this issue?
--
To view, visit http://gerrit.cloudera.org:8080/15187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f99f32d570680910a78e5181885b697b8743318
Gerrit-Change-Number: 15187
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Feb 2020 22:54:47 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15187 )
Change subject: [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest
......................................................................
[tests] address flakiness in MasterReplicationAndRpcSizeLimitTest
Leader master can change after processing a request and before related
metrics are read from a new leader master. To avoid flakiness, get the
sum of read values for the metric across all masters in the cluster and
verify the result against the expected numbers.
Change-Id: I2f99f32d570680910a78e5181885b697b8743318
Reviewed-on: http://gerrit.cloudera.org:8080/15187
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/master_replication-itest.cc
1 file changed, 28 insertions(+), 27 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f99f32d570680910a78e5181885b697b8743318
Gerrit-Change-Number: 15187
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Volodymyr Verovkin,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15187
to look at the new patch set (#2).
Change subject: [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest
......................................................................
[tests] address flakiness in MasterReplicationAndRpcSizeLimitTest
Leader master can change after processing a request and before related
metrics are read from a new leader master. To avoid flakiness, get the
sum of read values for the metric across all masters in the cluster and
verify the result against the expected numbers.
Change-Id: I2f99f32d570680910a78e5181885b697b8743318
---
M src/kudu/integration-tests/master_replication-itest.cc
1 file changed, 28 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/15187/2
--
To view, visit http://gerrit.cloudera.org:8080/15187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f99f32d570680910a78e5181885b697b8743318
Gerrit-Change-Number: 15187
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15187 )
Change subject: [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15187/1/src/kudu/integration-tests/master_replication-itest.cc
File src/kudu/integration-tests/master_replication-itest.cc:
http://gerrit.cloudera.org:8080/#/c/15187/1/src/kudu/integration-tests/master_replication-itest.cc@514
PS1, Line 514: To avoid flakiness, get the
: // readings for the metric from each master and verify the result.
> Could probably remove this part of the comment now.
Done
--
To view, visit http://gerrit.cloudera.org:8080/15187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f99f32d570680910a78e5181885b697b8743318
Gerrit-Change-Number: 15187
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Feb 2020 22:52:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15187 )
Change subject: [tests] address flakiness in MasterReplicationAndRpcSizeLimitTest
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15187/1/src/kudu/integration-tests/master_replication-itest.cc
File src/kudu/integration-tests/master_replication-itest.cc:
http://gerrit.cloudera.org:8080/#/c/15187/1/src/kudu/integration-tests/master_replication-itest.cc@514
PS1, Line 514: To avoid flakiness, get the
: // readings for the metric from each master and verify the result.
Could probably remove this part of the comment now.
--
To view, visit http://gerrit.cloudera.org:8080/15187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f99f32d570680910a78e5181885b697b8743318
Gerrit-Change-Number: 15187
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Feb 2020 22:49:01 +0000
Gerrit-HasComments: Yes