[GitHub] [accumulo] keith-turner commented on a diff in pull request #3047: Log the client address when FrameBuffer read or write methods return false

[GitBox <gi...@apache.org>]

keith-turner commented on code in PR #3047:
URL: https://github.com/apache/accumulo/pull/3047#discussion_r1005952162


##########
assemble/conf/log4j2-service.properties:
##########
@@ -78,6 +78,11 @@ logger.zookeeper.level = error
 logger.accumulo.name = org.apache.accumulo
 logger.accumulo.level = debug
 
+# uncomment if you start seeing Thrift FrameBuffer error messages
+# in the log (GitHub issue #3042)

Review Comment:
   > In general, I agree with this. The problem here is that the user has to read the source code to find out all the places where trace logging may be available.
   
   The following package is the beginning of an attempt to centralize important logging in the source code and make it discoverable by users.  I would like to move more logging to that package.
   
   https://github.com/apache/accumulo/blob/main/core/src/main/java/org/apache/accumulo/core/logging/package-info.java



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org