You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/09 12:02:21 UTC
[GitHub] [incubator-doris] yixiutt opened a new pull request, #10043: [optimize](compaction) optimize cu compaction policy in pick rowset
yixiutt opened a new pull request, #10043:
URL: https://github.com/apache/incubator-doris/pull/10043
origin _levels is between size_based_compaction_lower_bound_size and
size_based_promotion_size, default conf is 64M and 1024M, which is too
big for cu compaction, and once rowset size bigger than 64M it will be
promoted to base, so this rule seems to be useless.
update _leves to between 32M and 1K, which will reduce a lot of cpu.
In our test, we have 20 concurrent stream load and each rowset in disk
is 3K, after introduce this change, we save about 25% cpu.
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10043: [optimize](compaction) optimize cu compaction policy in pick rowset
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10043:
URL: https://github.com/apache/incubator-doris/pull/10043#issuecomment-1153696329
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhannngchen commented on a diff in pull request #10043: [optimize](compaction) optimize cu compaction policy in pick rowset
Posted by GitBox <gi...@apache.org>.
zhannngchen commented on code in PR #10043:
URL: https://github.com/apache/incubator-doris/pull/10043#discussion_r893442569
##########
be/src/olap/cumulative_compaction_policy.cpp:
##########
@@ -32,10 +32,11 @@ SizeBasedCumulativeCompactionPolicy::SizeBasedCumulativeCompactionPolicy(
_size_based_promotion_ratio(size_based_promotion_ratio),
_size_based_promotion_min_size(size_based_promotion_min_size),
_size_based_compaction_lower_bound_size(size_based_compaction_lower_bound_size) {
- // init _levels by divide 2 between size_based_promotion_size and size_based_compaction_lower_bound_size
- int64_t i_size = size_based_promotion_size / 2;
+ // init _levels by divide 2 between size_based_compaction_lower_bound_size and 1K
+ // cu compaction handle file size less then size_based_compaction_lower_bound_size
+ int64_t i_size = size_based_compaction_lower_bound_size / 2;
- while (i_size >= size_based_compaction_lower_bound_size) {
+ while (i_size >= 1024) {
Review Comment:
This value should be configurable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yixiutt closed pull request #10043: [optimize](compaction) optimize cu compaction policy in pick rowset
Posted by GitBox <gi...@apache.org>.
yixiutt closed pull request #10043: [optimize](compaction) optimize cu compaction policy in pick rowset
URL: https://github.com/apache/incubator-doris/pull/10043
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10043: [optimize](compaction) optimize cu compaction policy in pick rowset
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10043:
URL: https://github.com/apache/incubator-doris/pull/10043#issuecomment-1153696390
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org