You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/03/25 18:05:37 UTC

Review Request 32484: Strange template with puppet-style markup exists in service scripts

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32484/
-----------------------------------------------------------

Review request for Ambari and Andrew Onischuk.


Bugs: AMBARI-10204
    https://issues.apache.org/jira/browse/AMBARI-10204


Repository: ambari


Description
-------

File under question is ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/templates/health_check.j2 and it exists for both stacks.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py b6d2ba2 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/health_check-v2.j2 0a03d17 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/health_check.j2 1e47a3c 

Diff: https://reviews.apache.org/r/32484/diff/


Testing
-------

mvn clean test


Thanks,

Dmytro Sen


Re: Review Request 32484: Strange template with puppet-style markup exists in service scripts

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32484/#review77755
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Onischuk


On March 25, 2015, 5:05 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32484/
> -----------------------------------------------------------
> 
> (Updated March 25, 2015, 5:05 p.m.)
> 
> 
> Review request for Ambari and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-10204
>     https://issues.apache.org/jira/browse/AMBARI-10204
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> File under question is ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/templates/health_check.j2 and it exists for both stacks.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py b6d2ba2 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/health_check-v2.j2 0a03d17 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/health_check.j2 1e47a3c 
> 
> Diff: https://reviews.apache.org/r/32484/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 32484: Strange template with puppet-style markup exists in service scripts

Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32484/#review77878
-----------------------------------------------------------

Ship it!


Ship It!

- Myroslav Papirkovskyy


On Березень 26, 2015, 10:09 до полудня, Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32484/
> -----------------------------------------------------------
> 
> (Updated Березень 26, 2015, 10:09 до полудня)
> 
> 
> Review request for Ambari and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-10204
>     https://issues.apache.org/jira/browse/AMBARI-10204
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> File under question is ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/templates/health_check.j2 and it exists for both stacks.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py b6d2ba2 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/health_check-v2.j2 0a03d17 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/health_check.j2 1e47a3c 
>   ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py f606130 
> 
> Diff: https://reviews.apache.org/r/32484/diff/
> 
> 
> Testing
> -------
> 
> Ran 237 tests in 8.585s
> 
> OK
> ----------------------------------------------------------------------
> Total run:625
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 32484: Strange template with puppet-style markup exists in service scripts

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32484/
-----------------------------------------------------------

(Updated Март 26, 2015, 8:09 д.п.)


Review request for Ambari and Andrew Onischuk.


Bugs: AMBARI-10204
    https://issues.apache.org/jira/browse/AMBARI-10204


Repository: ambari


Description
-------

File under question is ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/templates/health_check.j2 and it exists for both stacks.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py b6d2ba2 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/health_check-v2.j2 0a03d17 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/health_check.j2 1e47a3c 
  ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py f606130 

Diff: https://reviews.apache.org/r/32484/diff/


Testing (updated)
-------

Ran 237 tests in 8.585s

OK
----------------------------------------------------------------------
Total run:625
Total errors:0
Total failures:0
OK


Thanks,

Dmytro Sen


Re: Review Request 32484: Strange template with puppet-style markup exists in service scripts

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32484/
-----------------------------------------------------------

(Updated Март 26, 2015, 7:49 д.п.)


Review request for Ambari and Andrew Onischuk.


Bugs: AMBARI-10204
    https://issues.apache.org/jira/browse/AMBARI-10204


Repository: ambari


Description
-------

File under question is ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/templates/health_check.j2 and it exists for both stacks.


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py b6d2ba2 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/health_check-v2.j2 0a03d17 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/health_check.j2 1e47a3c 
  ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py f606130 

Diff: https://reviews.apache.org/r/32484/diff/


Testing
-------

mvn clean test


Thanks,

Dmytro Sen