You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "asfimport (via GitHub)" <gi...@apache.org> on 2024/11/26 19:25:06 UTC

[I] [Java] MurmurHasher doesn't take the final bytes into account if size % 4 != 0 [arrow-java]

asfimport opened a new issue, #248:
URL: https://github.com/apache/arrow-java/issues/248

   Minimal test case: all buffers of size 1 currently hash to the same value (-1684229222)
   
   To my (admittedly untrained) eye, it looks like <https://github.com/apache/arrow/blob/c9588c54a1264ce02abc70cd02486966a1e97acf/java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/hash/MurmurHasher.java#L99> should range from `length - 1` rather than `index - 1`?
   
   Also, should the nearby `index += 1` be removed, so that `i` and `index` don't meet in the middle? (`index` is being checked in the loop condition)
   
   **Reporter**: [James Henderson](https://issues.apache.org/jira/browse/ARROW-15175) / @jarohen
   
   <sub>**Note**: *This issue was originally created as [ARROW-15175](https://issues.apache.org/jira/browse/ARROW-15175). Please see the [migration documentation](https://github.com/apache/arrow/issues/14542) for further details.*</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org