You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by li...@apache.org on 2024/03/27 19:47:06 UTC

(superset) branch table-time-comparison-color updated: update tooltip

This is an automated email from the ASF dual-hosted git repository.

lilykuang pushed a commit to branch table-time-comparison-color
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/table-time-comparison-color by this push:
     new 7e02a156fa update tooltip
7e02a156fa is described below

commit 7e02a156faee33448e4ce59749344d2a83b0b897
Author: lilykuang <ji...@gmail.com>
AuthorDate: Wed Mar 27 12:46:03 2024 -0700

    update tooltip
---
 .../plugins/plugin-chart-table/src/controlPanel.tsx            | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
index 641445913b..8aa8281745 100644
--- a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
+++ b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
@@ -601,10 +601,14 @@ const config: ControlPanelConfig = {
             name: 'comparison_color_enabled',
             config: {
               type: 'CheckboxControl',
-              label: t('basic conditional formatting for comparison '),
+              label: t('basic conditional formatting'),
               renderTrigger: true,
               default: false,
-              description: t('Add color for positive/negative change'),
+              description: t(
+                'This will be applied to the whole table. Arrows (↑ and ↓) will be added to ' +
+                  'main columns for increase and decrease. Basic conditional formatting can be ' +
+                  'overwritten by conditional formatting below.',
+              ),
             },
           },
         ],
@@ -613,7 +617,7 @@ const config: ControlPanelConfig = {
             name: 'comparison_color_scheme',
             config: {
               type: 'SelectControl',
-              label: t('color scheme for comparison'),
+              label: t('color type'),
               default: ColorSchemeEnum.Green,
               renderTrigger: true,
               choices: [