You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by GitBox <gi...@apache.org> on 2021/06/03 19:19:52 UTC

[GitHub] [wicket] rkurucz9 commented on pull request #471: WICKET-6888 ToggleableDataTable

rkurucz9 commented on pull request #471:
URL: https://github.com/apache/wicket/pull/471#issuecomment-854116236


   > I've taken a second look and actually your solution is very good. You clearly have understood how to work with components :).
   > 
   > My major grieve is how the collection of expanded objects is held in the component tree: this defies the 'holy mantra of detachment', i.e. the selected entities will get serialized along with the page. You could take a look at AbstractTree#newModel() for inspiration how this can be avoided.
   
   I hope I could fix it properly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org