You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shawn Heisey (JIRA)" <ji...@apache.org> on 2018/04/18 04:17:00 UTC

[jira] [Commented] (SOLR-12231) /etc/init.d/solr problem

    [ https://issues.apache.org/jira/browse/SOLR-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441872#comment-16441872 ] 

Shawn Heisey commented on SOLR-12231:
-------------------------------------

Other examples of the quick assignment can be found with this command on a Linux machine, and probably on other UNIX flavors that have an init.d directory:

{noformat}
grep "[A-Z_][A-Z_]*=[A-Za-z0-9][A-Za-z0-9]* " /etc/init.d/*
{noformat}

This also shows hits where that trick is NOT being used that happen to match the regex.

> /etc/init.d/solr problem
> ------------------------
>
>                 Key: SOLR-12231
>                 URL: https://issues.apache.org/jira/browse/SOLR-12231
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: scripts and tools
>    Affects Versions: 7.3
>         Environment: Centos 7.4 
> java-1.8.0-openjdk
>            Reporter: Lihua Wang
>            Assignee: Steve Rowe
>            Priority: Minor
>
> I noticed that there are a couple of minor issues with the init.d script in pretty much every version. 
> Basically, a semicolon (or an escaped semicolon) is missing in the *{color:#205081}BLUE{color}* lines blow:
>  
> if [ -n "$RUNAS" ]; then
>  {color:#205081}su -c "SOLR_INCLUDE=\"$SOLR_ENV\" \"$SOLR_INSTALL_DIR/bin/solr\" $SOLR_CMD" - "$RUNAS"{color}
>  else
>  {color:#205081}SOLR_INCLUDE="$SOLR_ENV" "$SOLR_INSTALL_DIR/bin/solr" "$SOLR_CMD"{color}
>  fi
>  
> *With the {color:#d04437}added semicolons{color} (escaped where necessary), the code would look like:* 
> if [ -n "$RUNAS" ]; then
>  *{color:#8eb021}{color:#8eb021}su -c "SOLR_INCLUDE=\"$SOLR_ENV\"{color:#d04437}\;{color}{color} \"$SOLR_INSTALL_DIR/bin/solr\" $SOLR_CMD" - "$RUNAS"{color}{color:#8eb021}*{color}*
>  *else*
>  *{color:#8eb021}*SOLR_INCLUDE="$SOLR_ENV"{color:#d04437};{color}{color}{color:#8eb021} "$SOLR_INSTALL_DIR/bin/solr" "$SOLR_CMD"{color}*
>  fi
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org