You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by Andy Seaborne <an...@apache.org> on 2014/06/20 16:40:58 UTC
Preparing for 2.12.0 - Java7 language upgrades
Over at JENA-714, there is a nice patch that upgrades many areas of the
source tree to Java7 idioms (and some Java 6 idioms)
We can either apply it before the first Java7-only release 2.12.0 or
just after. I'm neutral - patches are reversible by and large so it
isn't a huge, one-way step here. There are already a few other
Java7-isms where I was getting Eclipse warnings that I went and fixed.
Thoughts?
The current suggestion is release-then-apply.
Andy
PS I volunteer to be the RM for 2.12.0, subject to unpredictable time
constraints etc etc.
https://issues.apache.org/jira/browse/JENA-714
Re: Preparing for 2.12.0 - Java7 language upgrades
Posted by Claude Warren <cl...@xenei.com>.
Thx. I just went through the change log. Looks good from here.
Claude
On Tue, Jun 24, 2014 at 5:14 PM, Andy Seaborne <an...@apache.org> wrote:
> On 24/06/14 16:17, Claude Warren wrote:
>
>> Andy,
>>
>> Thanks for the hard work. Just for clarification, the security changes
>> were just removing code right? There are, as of yet, no new methods to
>> handle. Is that correct?
>>
>
> Nothing added :-)
>
> where there was
>
> XXX(,. boolean suppressReifications)
>
> which were no-ops even if you did make the same-named call on jena-core,
> then that method is no more.
>
> Some, not all, warnings on lack of generics got cleaned in passing.
>
> Tests pass!
>
> Andy
>
>
>
>
>
>> Claude
>>
>>
>> On Tue, Jun 24, 2014 at 4:02 PM, Andy Seaborne <an...@apache.org> wrote:
>>
>> Clearing up the code now done and hopefully reasonably recorded.
>>>
>>> Language level upgrade done (thanks for nudging us in that direction
>>> Kristian) and AutoCloseable.
>>>
>>> The documentation is still to be fixed up (JENA-728).
>>>
>>> Claude - I've brought jena-security up to date with the removal of
>>> deprecated ReificationStyle and the associated methods.
>>>
>>> I haven't touched any Experimental/ code.
>>>
>>> Andy
>>>
>>> On 21/06/14 10:47, Andy Seaborne wrote:
>>>
>>> On 20/06/14 15:47, Dave Reynolds wrote:
>>>>
>>>> On 20/06/14 15:40, Andy Seaborne wrote:
>>>>>
>>>>> Over at JENA-714, there is a nice patch that upgrades many areas of
>>>>>> the
>>>>>> source tree to Java7 idioms (and some Java 6 idioms)
>>>>>>
>>>>>> We can either apply it before the first Java7-only release 2.12.0 or
>>>>>> just after. I'm neutral - patches are reversible by and large so it
>>>>>> isn't a huge, one-way step here. There are already a few other
>>>>>> Java7-isms where I was getting Eclipse warnings that I went and fixed.
>>>>>>
>>>>>> Thoughts?
>>>>>>
>>>>>> The current suggestion is release-then-apply.
>>>>>>
>>>>>>
>>>>> Neutral. Happy to move to java7-only now or wait till after release.
>>>>>
>>>>> Dave
>>>>>
>>>>>
>>>>> JENA-725 asks that we add add AutoCloseable to QueryExecution.
>>>>
>>>> As is this an API change, doing it at 2.12.0 makes sense, and not post
>>>> 2.12.0.
>>>>
>>>> So I now think we should go for it and make the Java7 language changes
>>>> now.
>>>>
>>>> Andy
>>>>
>>>> PS I will do a deprecation sweep of at least ARQ to removed things we
>>>> have warned about.
>>>>
>>>>
>>>
>>>
>>
>>
>
--
I like: Like Like - The likeliest place on the web
<http://like-like.xenei.com>
LinkedIn: http://www.linkedin.com/in/claudewarren
Re: Preparing for 2.12.0 - Java7 language upgrades
Posted by Andy Seaborne <an...@apache.org>.
On 24/06/14 16:17, Claude Warren wrote:
> Andy,
>
> Thanks for the hard work. Just for clarification, the security changes
> were just removing code right? There are, as of yet, no new methods to
> handle. Is that correct?
Nothing added :-)
where there was
XXX(,. boolean suppressReifications)
which were no-ops even if you did make the same-named call on
jena-core, then that method is no more.
Some, not all, warnings on lack of generics got cleaned in passing.
Tests pass!
Andy
>
> Claude
>
>
> On Tue, Jun 24, 2014 at 4:02 PM, Andy Seaborne <an...@apache.org> wrote:
>
>> Clearing up the code now done and hopefully reasonably recorded.
>>
>> Language level upgrade done (thanks for nudging us in that direction
>> Kristian) and AutoCloseable.
>>
>> The documentation is still to be fixed up (JENA-728).
>>
>> Claude - I've brought jena-security up to date with the removal of
>> deprecated ReificationStyle and the associated methods.
>>
>> I haven't touched any Experimental/ code.
>>
>> Andy
>>
>> On 21/06/14 10:47, Andy Seaborne wrote:
>>
>>> On 20/06/14 15:47, Dave Reynolds wrote:
>>>
>>>> On 20/06/14 15:40, Andy Seaborne wrote:
>>>>
>>>>> Over at JENA-714, there is a nice patch that upgrades many areas of the
>>>>> source tree to Java7 idioms (and some Java 6 idioms)
>>>>>
>>>>> We can either apply it before the first Java7-only release 2.12.0 or
>>>>> just after. I'm neutral - patches are reversible by and large so it
>>>>> isn't a huge, one-way step here. There are already a few other
>>>>> Java7-isms where I was getting Eclipse warnings that I went and fixed.
>>>>>
>>>>> Thoughts?
>>>>>
>>>>> The current suggestion is release-then-apply.
>>>>>
>>>>
>>>> Neutral. Happy to move to java7-only now or wait till after release.
>>>>
>>>> Dave
>>>>
>>>>
>>> JENA-725 asks that we add add AutoCloseable to QueryExecution.
>>>
>>> As is this an API change, doing it at 2.12.0 makes sense, and not post
>>> 2.12.0.
>>>
>>> So I now think we should go for it and make the Java7 language changes
>>> now.
>>>
>>> Andy
>>>
>>> PS I will do a deprecation sweep of at least ARQ to removed things we
>>> have warned about.
>>>
>>
>>
>
>
Re: Preparing for 2.12.0 - Java7 language upgrades
Posted by Claude Warren <cl...@xenei.com>.
Andy,
Thanks for the hard work. Just for clarification, the security changes
were just removing code right? There are, as of yet, no new methods to
handle. Is that correct?
Claude
On Tue, Jun 24, 2014 at 4:02 PM, Andy Seaborne <an...@apache.org> wrote:
> Clearing up the code now done and hopefully reasonably recorded.
>
> Language level upgrade done (thanks for nudging us in that direction
> Kristian) and AutoCloseable.
>
> The documentation is still to be fixed up (JENA-728).
>
> Claude - I've brought jena-security up to date with the removal of
> deprecated ReificationStyle and the associated methods.
>
> I haven't touched any Experimental/ code.
>
> Andy
>
> On 21/06/14 10:47, Andy Seaborne wrote:
>
>> On 20/06/14 15:47, Dave Reynolds wrote:
>>
>>> On 20/06/14 15:40, Andy Seaborne wrote:
>>>
>>>> Over at JENA-714, there is a nice patch that upgrades many areas of the
>>>> source tree to Java7 idioms (and some Java 6 idioms)
>>>>
>>>> We can either apply it before the first Java7-only release 2.12.0 or
>>>> just after. I'm neutral - patches are reversible by and large so it
>>>> isn't a huge, one-way step here. There are already a few other
>>>> Java7-isms where I was getting Eclipse warnings that I went and fixed.
>>>>
>>>> Thoughts?
>>>>
>>>> The current suggestion is release-then-apply.
>>>>
>>>
>>> Neutral. Happy to move to java7-only now or wait till after release.
>>>
>>> Dave
>>>
>>>
>> JENA-725 asks that we add add AutoCloseable to QueryExecution.
>>
>> As is this an API change, doing it at 2.12.0 makes sense, and not post
>> 2.12.0.
>>
>> So I now think we should go for it and make the Java7 language changes
>> now.
>>
>> Andy
>>
>> PS I will do a deprecation sweep of at least ARQ to removed things we
>> have warned about.
>>
>
>
--
I like: Like Like - The likeliest place on the web
<http://like-like.xenei.com>
LinkedIn: http://www.linkedin.com/in/claudewarren
Re: Preparing for 2.12.0 - Java7 language upgrades
Posted by Andy Seaborne <an...@apache.org>.
Clearing up the code now done and hopefully reasonably recorded.
Language level upgrade done (thanks for nudging us in that direction
Kristian) and AutoCloseable.
The documentation is still to be fixed up (JENA-728).
Claude - I've brought jena-security up to date with the removal of
deprecated ReificationStyle and the associated methods.
I haven't touched any Experimental/ code.
Andy
On 21/06/14 10:47, Andy Seaborne wrote:
> On 20/06/14 15:47, Dave Reynolds wrote:
>> On 20/06/14 15:40, Andy Seaborne wrote:
>>> Over at JENA-714, there is a nice patch that upgrades many areas of the
>>> source tree to Java7 idioms (and some Java 6 idioms)
>>>
>>> We can either apply it before the first Java7-only release 2.12.0 or
>>> just after. I'm neutral - patches are reversible by and large so it
>>> isn't a huge, one-way step here. There are already a few other
>>> Java7-isms where I was getting Eclipse warnings that I went and fixed.
>>>
>>> Thoughts?
>>>
>>> The current suggestion is release-then-apply.
>>
>> Neutral. Happy to move to java7-only now or wait till after release.
>>
>> Dave
>>
>
> JENA-725 asks that we add add AutoCloseable to QueryExecution.
>
> As is this an API change, doing it at 2.12.0 makes sense, and not post
> 2.12.0.
>
> So I now think we should go for it and make the Java7 language changes now.
>
> Andy
>
> PS I will do a deprecation sweep of at least ARQ to removed things we
> have warned about.
Re: Preparing for 2.12.0 - Java7 language upgrades
Posted by Andy Seaborne <an...@apache.org>.
On 20/06/14 15:47, Dave Reynolds wrote:
> On 20/06/14 15:40, Andy Seaborne wrote:
>> Over at JENA-714, there is a nice patch that upgrades many areas of the
>> source tree to Java7 idioms (and some Java 6 idioms)
>>
>> We can either apply it before the first Java7-only release 2.12.0 or
>> just after. I'm neutral - patches are reversible by and large so it
>> isn't a huge, one-way step here. There are already a few other
>> Java7-isms where I was getting Eclipse warnings that I went and fixed.
>>
>> Thoughts?
>>
>> The current suggestion is release-then-apply.
>
> Neutral. Happy to move to java7-only now or wait till after release.
>
> Dave
>
JENA-725 asks that we add add AutoCloseable to QueryExecution.
As is this an API change, doing it at 2.12.0 makes sense, and not post
2.12.0.
So I now think we should go for it and make the Java7 language changes now.
Andy
PS I will do a deprecation sweep of at least ARQ to removed things we
have warned about.
Re: Preparing for 2.12.0 - Java7 language upgrades
Posted by Rob Vesse <rv...@dotnetrdf.org>.
Also kinda neutral
We seem to have said in the past that we would in the short term keep the
code backwards compatible for those who still need/want Java 6 but I am
inclined to support just pushing to Java 7 only to force people to bring
themselves up to date properly
Rob
On 20/06/2014 15:47, "Dave Reynolds" <da...@gmail.com> wrote:
>On 20/06/14 15:40, Andy Seaborne wrote:
>> Over at JENA-714, there is a nice patch that upgrades many areas of the
>> source tree to Java7 idioms (and some Java 6 idioms)
>>
>> We can either apply it before the first Java7-only release 2.12.0 or
>> just after. I'm neutral - patches are reversible by and large so it
>> isn't a huge, one-way step here. There are already a few other
>> Java7-isms where I was getting Eclipse warnings that I went and fixed.
>>
>> Thoughts?
>>
>> The current suggestion is release-then-apply.
>
>Neutral. Happy to move to java7-only now or wait till after release.
>
>Dave
>
Re: Preparing for 2.12.0 - Java7 language upgrades
Posted by Dave Reynolds <da...@gmail.com>.
On 20/06/14 15:40, Andy Seaborne wrote:
> Over at JENA-714, there is a nice patch that upgrades many areas of the
> source tree to Java7 idioms (and some Java 6 idioms)
>
> We can either apply it before the first Java7-only release 2.12.0 or
> just after. I'm neutral - patches are reversible by and large so it
> isn't a huge, one-way step here. There are already a few other
> Java7-isms where I was getting Eclipse warnings that I went and fixed.
>
> Thoughts?
>
> The current suggestion is release-then-apply.
Neutral. Happy to move to java7-only now or wait till after release.
Dave