You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/27 13:37:58 UTC

[GitHub] [pulsar] Shawyeok commented on a change in pull request #14480: [pulsar-common] Fix wrong calculation of consumerStats.avgMessagesPerEntry

Shawyeok commented on a change in pull request #14480:
URL: https://github.com/apache/pulsar/pull/14480#discussion_r815440821



##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/ConsumerStats.java
##########
@@ -53,7 +53,7 @@
     int getUnackedMessages();
 
     /** Number of average messages per entry for the consumer consumed. */
-    int getAvgMessagesPerEntry();
+    float getAvgMessagesPerEntry();

Review comment:
       Changed to stay return int, add a getter in `ConsumerStatsImpl`
   ```java
       // return integer for compatibility
       public int getAvgMessagesPerEntry() {
           return (int) avgMessagesPerEntry;
       }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org