You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "RaigorJiang (via GitHub)" <gi...@apache.org> on 2023/02/10 03:13:58 UTC

[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #24087: Remove JDBC dependency on logging module

RaigorJiang commented on code in PR #24087:
URL: https://github.com/apache/shardingsphere/pull/24087#discussion_r1102233327


##########
mode/type/cluster/core/pom.xml:
##########
@@ -48,6 +48,11 @@
             <artifactId>shardingsphere-single-core</artifactId>
             <version>${project.version}</version>
         </dependency>
+        <dependency>
+            <groupId>ch.qos.logback</groupId>
+            <artifactId>logback-classic</artifactId>

Review Comment:
   `logback` dependency should not be added to the cluster module.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org