You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/09 10:00:57 UTC

[GitHub] [pulsar] Jason918 opened a new pull request #10868: [docs] Update docs for topic stats in admin apis.

Jason918 opened a new pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868


   <!--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull request.
       Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ### Motivation
   
   There are a lot new variables which are not explained in docs when we get topic stats data using the cmd `bin/pulsar-admin topics stats <topic>`.
   This PR is trying to sync the docs with the source code.
   
   ### Modifications
   
   The new docs mostly come from comment in source code.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   Only doc is updated.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: ( no)
     - The schema: ( no )
     - The default values of configurations: (no)
     - The wire protocol: ( no)
     - The rest endpoints: ( no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no )
   
   ### Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10868: [docs] Update docs for topic stats in admin apis.

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868#discussion_r648781668



##########
File path: site2/docs/admin-api-topics.md
##########
@@ -187,14 +187,42 @@ You can check the following statistics of a given non-partitioned topic.
 
   -   **storageSize**: The sum of the ledgers' storage size for this topic. The space used to store the messages for the topic.
 
+  -   **bytesInCounter**: Total bytes published to the topic (bytes).
+
+  -   **msgInCounter**: Total messages published to the topic (msg).
+
+  -   **bytesOutCounter**: Total bytes delivered to consumer (bytes).
+
+  -   **msgOutCounter**: Total messages delivered to consumer (msg).
+
+  -   **msgChunkPublished**: Topic has chunked message published on it.
+
+  -   **backlogSize**: Estimated total unconsumed or backlog size in bytes.
+
+  -   **offloadedStorageSize**: Space used to store the offloaded messages for the topic.
+  
+  -   **waitingPublishers**: The number of publishers waiting in queue in exclusive access mode.

Review comment:
       ```suggestion
     -   **waitingPublishers**: Number of publishers waiting in a queue in exclusive access mode.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10868: [docs] Update docs for topic stats in admin apis.

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868#discussion_r648782811



##########
File path: site2/docs/admin-api-topics.md
##########
@@ -219,12 +251,46 @@ You can check the following statistics of a given non-partitioned topic.
           
           -   **lastExpireTimestamp**: The timestamp of the last message expire execution.
           
-          -   **lastConsumedFlowTimestamp**: The timestamp of the last flow command received. 
-          
+          -   **lastConsumedFlowTimestamp**: The timestamp of the last flow command received.
+
           -   **lastConsumedTimestamp**: The latest timestamp of all the consumed timestamp of the consumers.
           
           -   **lastAckedTimestamp**: The latest timestamp of all the acked timestamp of the consumers.
 
+          -   **bytesOutCounter**: Total bytes delivered to consumer (bytes).
+
+          -   **msgOutCounter**: Total messages delivered to consumer (msg).
+
+          -   **msgRateRedeliver**: Total rate of messages redelivered on this subscription (msg/s).
+
+          -   **chunkedMessageRate**: Chunked message dispatch rate.
+
+          -   **backlogSize**: Size of backlog in byte.
+
+          -   **msgBacklogNoDelayed**: Number of messages in the subscription backlog that do not contain the delay messages.
+
+          -   **blockedSubscriptionOnUnackedMsgs**: Flag to verify if subscription is blocked due to reaching threshold of unacked messages.

Review comment:
       ```suggestion
             -   **blockedSubscriptionOnUnackedMsgs**: Flag to verify if a subscription is blocked due to reaching threshold of unacked messages.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jason918 commented on pull request #10868: [docs] Update docs for topic stats in admin apis.

Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868#issuecomment-857569956


   @Anonymitaet Hi, can you please take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10868: [docs] Update docs for topic stats in admin apis.

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868#discussion_r648782984



##########
File path: site2/docs/admin-api-topics.md
##########
@@ -219,12 +251,46 @@ You can check the following statistics of a given non-partitioned topic.
           
           -   **lastExpireTimestamp**: The timestamp of the last message expire execution.
           
-          -   **lastConsumedFlowTimestamp**: The timestamp of the last flow command received. 
-          
+          -   **lastConsumedFlowTimestamp**: The timestamp of the last flow command received.
+
           -   **lastConsumedTimestamp**: The latest timestamp of all the consumed timestamp of the consumers.
           
           -   **lastAckedTimestamp**: The latest timestamp of all the acked timestamp of the consumers.
 
+          -   **bytesOutCounter**: Total bytes delivered to consumer (bytes).
+
+          -   **msgOutCounter**: Total messages delivered to consumer (msg).
+
+          -   **msgRateRedeliver**: Total rate of messages redelivered on this subscription (msg/s).
+
+          -   **chunkedMessageRate**: Chunked message dispatch rate.
+
+          -   **backlogSize**: Size of backlog in byte.
+
+          -   **msgBacklogNoDelayed**: Number of messages in the subscription backlog that do not contain the delay messages.
+
+          -   **blockedSubscriptionOnUnackedMsgs**: Flag to verify if subscription is blocked due to reaching threshold of unacked messages.
+
+          -   **msgDelayed**: Number of delayed messages currently being tracked.
+
+          -   **unackedMessages**: Number of unacknowledged messages for the subscription.
+
+          -   **activeConsumerName**: The name of the consumer that is active for single active consumer subscriptions i.e. failover or exclusive. 

Review comment:
       ```suggestion
             -   **activeConsumerName**: The name of the consumer that is active for single active consumer subscriptions. For example, failover or exclusive. 
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10868: [docs] Update docs for topic stats in admin apis.

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868#discussion_r648781558



##########
File path: site2/docs/admin-api-topics.md
##########
@@ -187,14 +187,42 @@ You can check the following statistics of a given non-partitioned topic.
 
   -   **storageSize**: The sum of the ledgers' storage size for this topic. The space used to store the messages for the topic.
 
+  -   **bytesInCounter**: Total bytes published to the topic (bytes).
+
+  -   **msgInCounter**: Total messages published to the topic (msg).
+
+  -   **bytesOutCounter**: Total bytes delivered to consumer (bytes).
+
+  -   **msgOutCounter**: Total messages delivered to consumer (msg).
+
+  -   **msgChunkPublished**: Topic has chunked message published on it.
+
+  -   **backlogSize**: Estimated total unconsumed or backlog size in bytes.

Review comment:
       ```suggestion
     -   **backlogSize**: Estimated total unconsumed or backlog size (in bytes).
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10868: [docs] Update docs for topic stats in admin apis.

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868#discussion_r648781668



##########
File path: site2/docs/admin-api-topics.md
##########
@@ -187,14 +187,42 @@ You can check the following statistics of a given non-partitioned topic.
 
   -   **storageSize**: The sum of the ledgers' storage size for this topic. The space used to store the messages for the topic.
 
+  -   **bytesInCounter**: Total bytes published to the topic (bytes).
+
+  -   **msgInCounter**: Total messages published to the topic (msg).
+
+  -   **bytesOutCounter**: Total bytes delivered to consumer (bytes).
+
+  -   **msgOutCounter**: Total messages delivered to consumer (msg).
+
+  -   **msgChunkPublished**: Topic has chunked message published on it.
+
+  -   **backlogSize**: Estimated total unconsumed or backlog size in bytes.
+
+  -   **offloadedStorageSize**: Space used to store the offloaded messages for the topic.
+  
+  -   **waitingPublishers**: The number of publishers waiting in queue in exclusive access mode.

Review comment:
       ```suggestion
     -   **waitingPublishers**: The number of publishers waiting in a queue in exclusive access mode.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10868: [docs] Update docs for topic stats in admin apis.

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868#discussion_r648783237



##########
File path: site2/docs/admin-api-topics.md
##########
@@ -239,10 +305,32 @@ You can check the following statistics of a given non-partitioned topic.
 
                 -   **blockedConsumerOnUnackedMsgs**: The flag used to verify if the consumer is blocked due to reaching threshold of the unacknowledged messages.
                 
-                -   **lastConsumedTimestamp**: The timestamp when the consumer reads a message the last time. 
-          
+                -   **lastConsumedTimestamp**: The timestamp when the consumer reads a message the last time.
+
                 -   **lastAckedTimestamp**: The timestamp when the consumer acknowledges a message the last time.
 
+                -   **address**: The IP address and source port for the connection of this consumer.
+
+                -   **connectedSince**: The timestamp when this consumer is created or reconnected last time.
+
+                -   **clientVersion**: The client library version of this consumer.
+
+                -   **bytesOutCounter**: Total bytes delivered to consumer (bytes).

Review comment:
       ```suggestion
                   -   **bytesOutCounter**: Total bytes delivered to consumer.
   ```

##########
File path: site2/docs/admin-api-topics.md
##########
@@ -239,10 +305,32 @@ You can check the following statistics of a given non-partitioned topic.
 
                 -   **blockedConsumerOnUnackedMsgs**: The flag used to verify if the consumer is blocked due to reaching threshold of the unacknowledged messages.
                 
-                -   **lastConsumedTimestamp**: The timestamp when the consumer reads a message the last time. 
-          
+                -   **lastConsumedTimestamp**: The timestamp when the consumer reads a message the last time.
+
                 -   **lastAckedTimestamp**: The timestamp when the consumer acknowledges a message the last time.
 
+                -   **address**: The IP address and source port for the connection of this consumer.
+
+                -   **connectedSince**: The timestamp when this consumer is created or reconnected last time.
+
+                -   **clientVersion**: The client library version of this consumer.
+
+                -   **bytesOutCounter**: Total bytes delivered to consumer (bytes).
+
+                -   **msgOutCounter**: Total messages delivered to consumer (msg).

Review comment:
       ```suggestion
                   -   **msgOutCounter**: Total messages delivered to consumer.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10868: [docs] Update docs for topic stats in admin apis.

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868#discussion_r648782700



##########
File path: site2/docs/admin-api-topics.md
##########
@@ -219,12 +251,46 @@ You can check the following statistics of a given non-partitioned topic.
           
           -   **lastExpireTimestamp**: The timestamp of the last message expire execution.
           
-          -   **lastConsumedFlowTimestamp**: The timestamp of the last flow command received. 
-          
+          -   **lastConsumedFlowTimestamp**: The timestamp of the last flow command received.
+
           -   **lastConsumedTimestamp**: The latest timestamp of all the consumed timestamp of the consumers.
           
           -   **lastAckedTimestamp**: The latest timestamp of all the acked timestamp of the consumers.
 
+          -   **bytesOutCounter**: Total bytes delivered to consumer (bytes).
+
+          -   **msgOutCounter**: Total messages delivered to consumer (msg).
+
+          -   **msgRateRedeliver**: Total rate of messages redelivered on this subscription (msg/s).
+
+          -   **chunkedMessageRate**: Chunked message dispatch rate.
+
+          -   **backlogSize**: Size of backlog in byte.

Review comment:
       ```suggestion
             -   **backlogSize**: Size of backlog (in byte).
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jason918 commented on pull request #10868: [docs] Update docs for topic stats in admin apis.

Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868#issuecomment-876853162


   @Anonymitaet Hi, Anyone we should invite to review to close this PR? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #10868: [docs] Update docs for topic stats in admin apis.

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868#discussion_r651446501



##########
File path: site2/docs/admin-api-topics.md
##########
@@ -187,14 +187,42 @@ You can check the following statistics of a given non-partitioned topic.
 
   -   **storageSize**: The sum of the ledgers' storage size for this topic. The space used to store the messages for the topic.
 
+  -   **bytesInCounter**: Total bytes published to the topic.
+
+  -   **msgInCounter**: Total messages published to the topic.
+
+  -   **bytesOutCounter**: Total bytes delivered to consumer (bytes).
+
+  -   **msgOutCounter**: Total messages delivered to consumer.
+
+  -   **msgChunkPublished**: Topic has chunked message published on it.
+
+  -   **backlogSize**: Estimated total unconsumed or backlog size (in bytes).
+
+  -   **offloadedStorageSize**: Space used to store the offloaded messages for the topic.

Review comment:
       It might be worth adding the units for this field, instead of just referencing "space".

##########
File path: site2/docs/admin-api-topics.md
##########
@@ -187,14 +187,42 @@ You can check the following statistics of a given non-partitioned topic.
 
   -   **storageSize**: The sum of the ledgers' storage size for this topic. The space used to store the messages for the topic.
 
+  -   **bytesInCounter**: Total bytes published to the topic.
+
+  -   **msgInCounter**: Total messages published to the topic.
+
+  -   **bytesOutCounter**: Total bytes delivered to consumer (bytes).

Review comment:
       Nit: this value is for _all_ consumers for the topic. (At least all consumers for as long as this topic has been on the given broker.)
   ```suggestion
     -   **bytesOutCounter**: Total bytes delivered to consumers (bytes).
   ```

##########
File path: site2/docs/admin-api-topics.md
##########
@@ -219,12 +251,46 @@ You can check the following statistics of a given non-partitioned topic.
           
           -   **lastExpireTimestamp**: The timestamp of the last message expire execution.
           
-          -   **lastConsumedFlowTimestamp**: The timestamp of the last flow command received. 
-          
+          -   **lastConsumedFlowTimestamp**: The timestamp of the last flow command received.
+
           -   **lastConsumedTimestamp**: The latest timestamp of all the consumed timestamp of the consumers.
           
           -   **lastAckedTimestamp**: The latest timestamp of all the acked timestamp of the consumers.
 
+          -   **bytesOutCounter**: Total bytes delivered to consumer.
+
+          -   **msgOutCounter**: Total messages delivered to consumer.
+
+          -   **msgRateRedeliver**: Total rate of messages redelivered on this subscription (msg/s).
+
+          -   **chunkedMessageRate**: Chunked message dispatch rate.
+
+          -   **backlogSize**: Size of backlog (in byte).

Review comment:
       ```suggestion
             -   **backlogSize**: Size of backlog for this subscription (in bytes).
   ```

##########
File path: site2/docs/admin-api-topics.md
##########
@@ -187,14 +187,42 @@ You can check the following statistics of a given non-partitioned topic.
 
   -   **storageSize**: The sum of the ledgers' storage size for this topic. The space used to store the messages for the topic.
 
+  -   **bytesInCounter**: Total bytes published to the topic.
+
+  -   **msgInCounter**: Total messages published to the topic.
+
+  -   **bytesOutCounter**: Total bytes delivered to consumer (bytes).
+
+  -   **msgOutCounter**: Total messages delivered to consumer.

Review comment:
       Nit: this value is for _all_ consumers for the topic. (At least all consumers for as long as this topic has been on the given broker.)
   ```suggestion
     -   **msgOutCounter**: Total messages delivered to consumers.
   ```

##########
File path: site2/docs/admin-api-topics.md
##########
@@ -187,14 +187,42 @@ You can check the following statistics of a given non-partitioned topic.
 
   -   **storageSize**: The sum of the ledgers' storage size for this topic. The space used to store the messages for the topic.
 
+  -   **bytesInCounter**: Total bytes published to the topic.
+
+  -   **msgInCounter**: Total messages published to the topic.
+
+  -   **bytesOutCounter**: Total bytes delivered to consumer (bytes).
+
+  -   **msgOutCounter**: Total messages delivered to consumer.
+
+  -   **msgChunkPublished**: Topic has chunked message published on it.
+
+  -   **backlogSize**: Estimated total unconsumed or backlog size (in bytes).
+
+  -   **offloadedStorageSize**: Space used to store the offloaded messages for the topic.
+  
+  -   **waitingPublishers**: The number of publishers waiting in a queue in exclusive access mode.
+  
+  -   **deduplicationStatus**: The status of message deduplication for the topic.
+  
+  -   **topicEpoch**: The topic epoch or empty if not set.
+
+  -   **nonContiguousDeletedMessagesRanges**: The number of non-contiguous deleted messages ranges.
+
+  -   **nonContiguousDeletedMessagesRangesSerializedSize**: The serialized size of non-contiguous deleted messages ranges.  
+
   -   **publishers**: The list of all local publishers into the topic. The list ranges from zero to thousands.
 
+      -   **accessMode**: The type of access to the topic that the producer requires.
+
       -   **msgRateIn**: The total rate of messages (msg/s) published by this publisher.
 
       -   **msgThroughputIn**: The total throughput (bytes/s) of the messages published by this publisher.
 
       -   **averageMsgSize**: The average message size in bytes from this publisher within the last interval.
 
+      -   **chunkedMessageRate**: Total chunked message count received.

Review comment:
       ```suggestion
         -   **chunkedMessageRate**: Total chunked message count received for this producer on this topic.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10868: [docs] Update docs for topic stats in admin apis.

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868#discussion_r648781238



##########
File path: site2/docs/admin-api-topics.md
##########
@@ -187,14 +187,42 @@ You can check the following statistics of a given non-partitioned topic.
 
   -   **storageSize**: The sum of the ledgers' storage size for this topic. The space used to store the messages for the topic.
 
+  -   **bytesInCounter**: Total bytes published to the topic (bytes).

Review comment:
       ```suggestion
     -   **bytesInCounter**: Total bytes published to the topic.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jason918 commented on pull request #10868: [docs] Update docs for topic stats in admin apis.

Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868#issuecomment-858230242


   > Thanks for your contribution. I’ve left some comments, PTAL.
   
   @Anonymitaet  Thx, all the comments are resolved, PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet merged pull request #10868: [docs] Update docs for topic stats in admin apis.

Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jason918 commented on pull request #10868: [docs] Update docs for topic stats in admin apis.

Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868#issuecomment-862148080


   @michaeljmarshall Thank you for your comments. All the comments are resolved, PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10868: [docs] Update docs for topic stats in admin apis.

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868#discussion_r648783119



##########
File path: site2/docs/admin-api-topics.md
##########
@@ -219,12 +251,46 @@ You can check the following statistics of a given non-partitioned topic.
           
           -   **lastExpireTimestamp**: The timestamp of the last message expire execution.
           
-          -   **lastConsumedFlowTimestamp**: The timestamp of the last flow command received. 
-          
+          -   **lastConsumedFlowTimestamp**: The timestamp of the last flow command received.
+
           -   **lastConsumedTimestamp**: The latest timestamp of all the consumed timestamp of the consumers.
           
           -   **lastAckedTimestamp**: The latest timestamp of all the acked timestamp of the consumers.
 
+          -   **bytesOutCounter**: Total bytes delivered to consumer (bytes).
+
+          -   **msgOutCounter**: Total messages delivered to consumer (msg).
+
+          -   **msgRateRedeliver**: Total rate of messages redelivered on this subscription (msg/s).
+
+          -   **chunkedMessageRate**: Chunked message dispatch rate.
+
+          -   **backlogSize**: Size of backlog in byte.
+
+          -   **msgBacklogNoDelayed**: Number of messages in the subscription backlog that do not contain the delay messages.
+
+          -   **blockedSubscriptionOnUnackedMsgs**: Flag to verify if subscription is blocked due to reaching threshold of unacked messages.
+
+          -   **msgDelayed**: Number of delayed messages currently being tracked.
+
+          -   **unackedMessages**: Number of unacknowledged messages for the subscription.
+
+          -   **activeConsumerName**: The name of the consumer that is active for single active consumer subscriptions i.e. failover or exclusive. 
+
+          -   **totalMsgExpired**: Total messages expired on this subscription. 
+
+          -   **lastMarkDeleteAdvancedTimestamp**: Last MarkDelete position advanced timestamp.
+
+          -   **durable**: Tells whether this subscription is durable or ephemeral (eg.: from a reader).

Review comment:
       ```suggestion
             -   **durable**: Whether the subscription is durable or ephemeral (for example, from a reader).
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jason918 commented on a change in pull request #10868: [docs] Update docs for topic stats in admin apis.

Posted by GitBox <gi...@apache.org>.
Jason918 commented on a change in pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868#discussion_r652449415



##########
File path: site2/docs/admin-api-topics.md
##########
@@ -187,14 +187,42 @@ You can check the following statistics of a given non-partitioned topic.
 
   -   **storageSize**: The sum of the ledgers' storage size for this topic. The space used to store the messages for the topic.
 
+  -   **bytesInCounter**: Total bytes published to the topic.
+
+  -   **msgInCounter**: Total messages published to the topic.
+
+  -   **bytesOutCounter**: Total bytes delivered to consumer (bytes).
+
+  -   **msgOutCounter**: Total messages delivered to consumer.
+
+  -   **msgChunkPublished**: Topic has chunked message published on it.
+
+  -   **backlogSize**: Estimated total unconsumed or backlog size (in bytes).
+
+  -   **offloadedStorageSize**: Space used to store the offloaded messages for the topic.

Review comment:
       Add **bytes** in the latest commit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10868: [docs] Update docs for topic stats in admin apis.

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868#discussion_r648782538



##########
File path: site2/docs/admin-api-topics.md
##########
@@ -219,12 +251,46 @@ You can check the following statistics of a given non-partitioned topic.
           
           -   **lastExpireTimestamp**: The timestamp of the last message expire execution.
           
-          -   **lastConsumedFlowTimestamp**: The timestamp of the last flow command received. 
-          
+          -   **lastConsumedFlowTimestamp**: The timestamp of the last flow command received.
+
           -   **lastConsumedTimestamp**: The latest timestamp of all the consumed timestamp of the consumers.
           
           -   **lastAckedTimestamp**: The latest timestamp of all the acked timestamp of the consumers.
 
+          -   **bytesOutCounter**: Total bytes delivered to consumer (bytes).

Review comment:
       ```suggestion
             -   **bytesOutCounter**: Total bytes delivered to consumer.
   ```

##########
File path: site2/docs/admin-api-topics.md
##########
@@ -219,12 +251,46 @@ You can check the following statistics of a given non-partitioned topic.
           
           -   **lastExpireTimestamp**: The timestamp of the last message expire execution.
           
-          -   **lastConsumedFlowTimestamp**: The timestamp of the last flow command received. 
-          
+          -   **lastConsumedFlowTimestamp**: The timestamp of the last flow command received.
+
           -   **lastConsumedTimestamp**: The latest timestamp of all the consumed timestamp of the consumers.
           
           -   **lastAckedTimestamp**: The latest timestamp of all the acked timestamp of the consumers.
 
+          -   **bytesOutCounter**: Total bytes delivered to consumer (bytes).
+
+          -   **msgOutCounter**: Total messages delivered to consumer (msg).

Review comment:
       ```suggestion
             -   **msgOutCounter**: Total messages delivered to consumer.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet commented on pull request #10868: [docs] Update docs for topic stats in admin apis.

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868#issuecomment-876854712


   @Jason918 I think now it's fine, we can merge this PR after it passes the tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10868: [docs] Update docs for topic stats in admin apis.

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868#discussion_r648781310



##########
File path: site2/docs/admin-api-topics.md
##########
@@ -187,14 +187,42 @@ You can check the following statistics of a given non-partitioned topic.
 
   -   **storageSize**: The sum of the ledgers' storage size for this topic. The space used to store the messages for the topic.
 
+  -   **bytesInCounter**: Total bytes published to the topic (bytes).
+
+  -   **msgInCounter**: Total messages published to the topic (msg).

Review comment:
       ```suggestion
     -   **msgInCounter**: Total messages published to the topic.
   ```

##########
File path: site2/docs/admin-api-topics.md
##########
@@ -187,14 +187,42 @@ You can check the following statistics of a given non-partitioned topic.
 
   -   **storageSize**: The sum of the ledgers' storage size for this topic. The space used to store the messages for the topic.
 
+  -   **bytesInCounter**: Total bytes published to the topic (bytes).
+
+  -   **msgInCounter**: Total messages published to the topic (msg).
+
+  -   **bytesOutCounter**: Total bytes delivered to consumer (bytes).
+
+  -   **msgOutCounter**: Total messages delivered to consumer (msg).

Review comment:
       ```suggestion
     -   **msgOutCounter**: Total messages delivered to consumer.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jason918 commented on pull request #10868: [docs] Update docs for topic stats in admin apis.

Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #10868:
URL: https://github.com/apache/pulsar/pull/10868#issuecomment-876864088


   > @Jason918 I think now it's fine, we can merge this PR after it passes the tests.
   
   @Anonymitaet  Great, thanks a lot~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org