[GitHub] [incubator-brpc] zyearn commented on a change in pull request #723: fix build scripts under mac os env and add building section for README

[GitBox <gi...@apache.org>]

zyearn commented on a change in pull request #723: fix build  scripts under mac os env and add building section for README
URL: https://github.com/apache/incubator-brpc/pull/723#discussion_r274748285
 
 

 ##########
 File path: config_brpc.sh
 ##########
 @@ -138,7 +138,12 @@ find_dir_of_header_or_die() {
 
 # Inconvenient to check these headers in baidu-internal
 #PTHREAD_HDR=$(find_dir_of_header_or_die pthread.h)
-OPENSSL_HDR=$(find_dir_of_header_or_die openssl/ssl.h)
+if [ "$SYSTEM" = "Darwin" ]; then
+    OPENSSL_HDR="/usr/local/Cellar/openssl\@1.1/1.1.1b/include"
+    OPENSSL_LIB="/usr/local/Cellar/openssl\@1.1/1.1.1b/lib"
+else
+    OPENSSL_HDR=$(find_dir_of_header_or_die openssl/ssl.h)
+fi
 
 Review comment:
   这边路径写死和getting_started.md中写的openssl: 0.97-1.1是矛盾的？有些用户看到文档自己有1.0.2了就不装1.1了，然后这里就挂了吧

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org