[GitHub] [nifi-fds] scottyaslan commented on a change in pull request #14: [WIP] NIFI-6212 introduce webpack, ES6, TS, linting, dev build watch

[GitBox <gi...@apache.org>]

scottyaslan commented on a change in pull request #14: [WIP] NIFI-6212 introduce webpack, ES6, TS, linting, dev build watch
URL: https://github.com/apache/nifi-fds/pull/14#discussion_r279456036
 
 

 ##########
 File path: README.md
 ##########
 @@ -21,21 +21,152 @@ System.config({
   // existing configuration options
   map: {
     ...,
-    '@flow-design-system/core': 'node_modules/@nifi-fds/core/flow-design-system.module.js',
-    '@flow-design-system/dialogs': 'node_modules/@nifi-fds/core/dialogs/fds-dialogs.module.js',
-    '@flow-design-system/dialog-component': 'node_modules/@nifi-fds/core/dialogs/fds-dialog.component.js',
-    '@flow-design-system/dialog-service': 'node_modules/@nifi-fds/core/dialogs/services/dialog.service.js',
-    '@flow-design-system/confirm-dialog-component': 'node_modules/@nifi-fds/core/dialogs/confirm-dialog/confirm-dialog.component.js',
-    '@flow-design-system/snackbars': 'node_modules/@nifi-fds/core/snackbars/fds-snackbars.module.js',
-    '@flow-design-system/snackbar-component': 'node_modules/@nifi-fds/core/snackbars/fds-snackbar.component.js',
-    '@flow-design-system/snackbar-service': 'node_modules/@nifi-fds/core/snackbars/services/snackbar.service.js',
-    '@flow-design-system/coaster-component': 'node_modules/@nifi-fds/core/snackbars/coaster/coaster.component.js',
-    '@flow-design-system/common/storage-service': 'node_modules/@nifi-fds/core/common/services/fds-storage.service.js'
+    '@flow-design-system/core': 'node_modules/@nifi-fds/core'
   }
 });
 ```
 
-Next, import the **Apache NiFi Flow Design System** NgModule into your angular application. 
+#### ES6/TS
+If your project is using the webpack to load modules, you will need to add `@nifi-fds/core` as an alias:
+
+```javascript
+const path = require('path');
+
+module.exports = {
+    // Flow Design System
+    '@flow-design-system/core': path.resolve(__dirname, 'platform/core/flow-design-system.module.js'),
 
 Review comment:
   good catch

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services