You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/25 22:37:12 UTC
[GitHub] [spark] rdblue opened a new pull request #28027: [SPARK-31255][SQL]
Add SupportsMetadataColumns to DSv2 (WIP)
rdblue opened a new pull request #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027
### What changes were proposed in this pull request?
This adds support for metadata columns to DataSourceV2. If a source implements `SupportsMetadataColumns` it must also implement `SupportsPushDownRequiredColumns` to support projecting those columns.
The analyzer is updated to resolve metadata columns from `LogicalPlan.metadataOutput`, and this adds a rule that will add metadata columns to the output of `DataSourceV2Relation` if one is used.
### Why are the changes needed?
This is the solution discussed for exposing additional data in the Kafka source. It is also needed for a generic `MERGE INTO` plan.
### Does this PR introduce any user-facing change?
Yes. Users can project additional columns from sources that implement the new API. This also updates `DescribeTableExec` to show metadata columns.
### How was this patch tested?
Will include new unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] fbocse commented on a change in pull request #28027:
[SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
fbocse commented on a change in pull request #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#discussion_r398901106
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
##########
@@ -48,6 +48,15 @@ case class DataSourceV2Relation(
import DataSourceV2Implicits._
+ override lazy val metadataOutput: Seq[AttributeReference] = table match {
+ case hasMeta: SupportsMetadataColumns =>
+ val attrs = hasMeta.metadataColumns
+ val outputNames = outputSet.map(_.name).toSet
+ attrs.filterNot(col => outputNames.contains(col.name)).toAttributes
Review comment:
Can this possibly be buggy because of case-sensitivity playing a trick when filtering by Set.contains or column names are somehow "normalized" wrt to case?
```suggestion
val outputNames = outputSet.map(_.name.toLowerCase()).toSet
attrs.filterNot(col => outputNames.contains(col.name.toLowerCase())).toAttributes
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #28027: [SPARK-31255][SQL]
Add SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-604954698
It would be nice if we have TODO list or what's missing so that the PR is marked as WIP; it can help reviewers to avoid any misunderstanding or confusions. It would also help to determine whether the PR is ready to be reviewed or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rdblue edited a comment on issue #28027: [SPARK-31255][SQL]
Add SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
rdblue edited a comment on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-605320803
@HeartSaVioR, this is currently missing tests.
We have this deployed in our internal Spark build and it works fine. In particular, metadata columns are only projected if they are purposely referenced. We haven't observed any problems with them being added by * expansion and we haven't had any issues with the changes to the analyzer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rdblue commented on issue #28027: [SPARK-31255][SQL] Add
SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
rdblue commented on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-605320803
@HeartSaVioR, this is currently missing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28027: [SPARK-31255][SQL]
Add SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-604208943
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28027:
[SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-604208943
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28027: [SPARK-31255][SQL]
Add SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-604126551
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25088/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28027:
[SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-604126551
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25088/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28027: [SPARK-31255][SQL]
Add SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-604144381
cc @dbtsai
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28027: [SPARK-31255][SQL]
Add SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-604124045
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25087/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28027: [SPARK-31255][SQL] Add
SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-604208444
**[Test build #120378 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120378/testReport)** for PR 28027 at commit [`0a5c7ca`](https://github.com/apache/spark/commit/0a5c7caebb807f2d256ce696ba8112acc24292b7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` implicit class MetadataColumnsHelper(metadata: Array[MetadataColumn]) `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28027:
[SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-604126542
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28027: [SPARK-31255][SQL]
Add SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-604124036
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rdblue commented on issue #28027: [SPARK-31255][SQL] Add
SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
rdblue commented on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-604124358
FYI @HeartSaVioR and @brkyvz.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] fbocse commented on a change in pull request #28027:
[SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
fbocse commented on a change in pull request #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#discussion_r398901106
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
##########
@@ -48,6 +48,15 @@ case class DataSourceV2Relation(
import DataSourceV2Implicits._
+ override lazy val metadataOutput: Seq[AttributeReference] = table match {
+ case hasMeta: SupportsMetadataColumns =>
+ val attrs = hasMeta.metadataColumns
+ val outputNames = outputSet.map(_.name).toSet
+ attrs.filterNot(col => outputNames.contains(col.name)).toAttributes
Review comment:
Can this possibly be buggy because of case-sensitivity playing a trick when filtering by Set.contains or column names are "normalized" wrt to case?
```suggestion
val outputNames = outputSet.map(_.name.toLowerCase()).toSet
attrs.filterNot(col => outputNames.contains(col.name.toLowerCase())).toAttributes
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] fbocse commented on a change in pull request #28027:
[SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
fbocse commented on a change in pull request #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#discussion_r398901106
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
##########
@@ -48,6 +48,15 @@ case class DataSourceV2Relation(
import DataSourceV2Implicits._
+ override lazy val metadataOutput: Seq[AttributeReference] = table match {
+ case hasMeta: SupportsMetadataColumns =>
+ val attrs = hasMeta.metadataColumns
+ val outputNames = outputSet.map(_.name).toSet
+ attrs.filterNot(col => outputNames.contains(col.name)).toAttributes
Review comment:
Can this possibly be buggy because of case-sensitivity playing a trick when filtering by Set.contains or column names are "normalized" wrt to case?
```suggestion
val outputNames = outputSet.map(_.name.toLowerCase()).toSet
attrs.filterNot(col => outputNames.contains(col.name.toLowerCase())).toAttributes
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28027: [SPARK-31255][SQL]
Add SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-604208946
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120378/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] fbocse commented on a change in pull request #28027:
[SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
fbocse commented on a change in pull request #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#discussion_r398901106
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
##########
@@ -48,6 +48,15 @@ case class DataSourceV2Relation(
import DataSourceV2Implicits._
+ override lazy val metadataOutput: Seq[AttributeReference] = table match {
+ case hasMeta: SupportsMetadataColumns =>
+ val attrs = hasMeta.metadataColumns
+ val outputNames = outputSet.map(_.name).toSet
+ attrs.filterNot(col => outputNames.contains(col.name)).toAttributes
Review comment:
Can this possibly be buggy because of case-sensitivity playing a trick when filtering by Set.contains?
```suggestion
val outputNames = outputSet.map(_.name.toLowerCase()).toSet
attrs.filterNot(col => outputNames.contains(col.name.toLowerCase())).toAttributes
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28027: [SPARK-31255][SQL] Add
SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-604126136
**[Test build #120378 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120378/testReport)** for PR 28027 at commit [`0a5c7ca`](https://github.com/apache/spark/commit/0a5c7caebb807f2d256ce696ba8112acc24292b7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28027:
[SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-604208946
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120378/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28027:
[SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-604124036
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28027: [SPARK-31255][SQL]
Add SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-604126542
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28027:
[SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-604126136
**[Test build #120378 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120378/testReport)** for PR 28027 at commit [`0a5c7ca`](https://github.com/apache/spark/commit/0a5c7caebb807f2d256ce696ba8112acc24292b7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28027:
[SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-604124045
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25087/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org