You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/03/22 05:57:55 UTC

[GitHub] [james-project] chibenwa edited a comment on pull request #924: JAMES-3715 Migrates to Netty4

chibenwa edited a comment on pull request #924:
URL: https://github.com/apache/james-project/pull/924#issuecomment-1074768865


   > FYI Also includes a fix for TCP_NODELAY still wasn't being set properly (configureBootstrap() was being run after socket was bound).
   
   Crap my bad!
   
   > Please cherry-pick: https://github.com/glennosss/james-project/commit/19ca9349f5a26e114c7acc1121bdc208be27e622
   
   I will review that carefully tomorrow.
   
   Don't you opening it as a pull request?
   
   This will ease discussions for sure.
   
   Also, splitting it into smaller commits would make it significantly easier to adopt! I see 5 bullet points in your commit, this should likely be 5 different commits...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org