You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Neha Narkhede <ne...@gmail.com> on 2013/12/03 15:35:26 UTC
Review Request 15964: Patch for KAFKA-1156
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15964/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1156
https://issues.apache.org/jira/browse/KAFKA-1156
Repository: kafka
Description
-------
Improved the partition reassignment tool to - 1) Output the previous partition replica assignment before kicking off the new assignment, to help with rollback 2) Have 3 options - generate, verify, execute 3) Cleaned up tool to use the 3 options properly
Diffs
-----
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 70d1b81f7dab2b3316af77738d682427d668be14
Diff: https://reviews.apache.org/r/15964/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 15964: Patch for KAFKA-1156
Posted by Neha Narkhede <ne...@gmail.com>.
> On Dec. 3, 2013, 10:46 p.m., Jun Rao wrote:
> > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, lines 181-182
> > <https://reviews.apache.org/r/15964/diff/2/?file=393096#file393096line181>
> >
> > Could we put the sentence starting from Save in a new line? Also, may be we can remove the dot at the end of the first sentence since it's not part of the json output.
Good observation, Jun :)
- Neha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15964/#review29688
-----------------------------------------------------------
On Dec. 3, 2013, 6:21 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15964/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2013, 6:21 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1156
> https://issues.apache.org/jira/browse/KAFKA-1156
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Found and fixed a bug during partition reassignment if a partition is being reassigned to the same set of replicas repeatedly
>
>
> Improved the partition reassignment tool to - 1) Output the previous partition replica assignment before kicking off the new assignment, to help with rollback 2) Have 3 options - generate, verify, execute 3) Cleaned up tool to use the 3 options properly
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 70d1b81f7dab2b3316af77738d682427d668be14
> core/src/main/scala/kafka/controller/KafkaController.scala 4c319aba97655e7c4ec97fac2e34de4e28c9f5d3
>
> Diff: https://reviews.apache.org/r/15964/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 15964: Patch for KAFKA-1156
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15964/#review29688
-----------------------------------------------------------
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
<https://reviews.apache.org/r/15964/#comment57126>
Could we put the sentence starting from Save in a new line? Also, may be we can remove the dot at the end of the first sentence since it's not part of the json output.
- Jun Rao
On Dec. 3, 2013, 6:21 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15964/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2013, 6:21 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1156
> https://issues.apache.org/jira/browse/KAFKA-1156
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Found and fixed a bug during partition reassignment if a partition is being reassigned to the same set of replicas repeatedly
>
>
> Improved the partition reassignment tool to - 1) Output the previous partition replica assignment before kicking off the new assignment, to help with rollback 2) Have 3 options - generate, verify, execute 3) Cleaned up tool to use the 3 options properly
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 70d1b81f7dab2b3316af77738d682427d668be14
> core/src/main/scala/kafka/controller/KafkaController.scala 4c319aba97655e7c4ec97fac2e34de4e28c9f5d3
>
> Diff: https://reviews.apache.org/r/15964/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 15964: Patch for KAFKA-1156
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15964/#review29684
-----------------------------------------------------------
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
<https://reviews.apache.org/r/15964/#comment57121>
If we get here, the generateOpt must already be set.
core/src/main/scala/kafka/controller/KafkaController.scala
<https://reviews.apache.org/r/15964/#comment57125>
Could the case statement be just on this statement?
- Jun Rao
On Dec. 3, 2013, 6:21 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15964/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2013, 6:21 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1156
> https://issues.apache.org/jira/browse/KAFKA-1156
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Found and fixed a bug during partition reassignment if a partition is being reassigned to the same set of replicas repeatedly
>
>
> Improved the partition reassignment tool to - 1) Output the previous partition replica assignment before kicking off the new assignment, to help with rollback 2) Have 3 options - generate, verify, execute 3) Cleaned up tool to use the 3 options properly
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 70d1b81f7dab2b3316af77738d682427d668be14
> core/src/main/scala/kafka/controller/KafkaController.scala 4c319aba97655e7c4ec97fac2e34de4e28c9f5d3
>
> Diff: https://reviews.apache.org/r/15964/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 15964: Patch for KAFKA-1156
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15964/#review29692
-----------------------------------------------------------
Ship it!
Ship It!
- Jun Rao
On Dec. 4, 2013, 12:22 a.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15964/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2013, 12:22 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1156
> https://issues.apache.org/jira/browse/KAFKA-1156
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Removed the option to output the entire cluster's current partition assignment, since it doesn't seem very relevant to the generate option
>
>
> Included Jun's review suggestions
>
>
> Found and fixed a bug during partition reassignment if a partition is being reassigned to the same set of replicas repeatedly
>
>
> Improved the partition reassignment tool to - 1) Output the previous partition replica assignment before kicking off the new assignment, to help with rollback 2) Have 3 options - generate, verify, execute 3) Cleaned up tool to use the 3 options properly
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 70d1b81f7dab2b3316af77738d682427d668be14
> core/src/main/scala/kafka/controller/KafkaController.scala 4c319aba97655e7c4ec97fac2e34de4e28c9f5d3
>
> Diff: https://reviews.apache.org/r/15964/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 15964: Patch for KAFKA-1156
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15964/#review29777
-----------------------------------------------------------
Ship it!
Ship It!
- Guozhang Wang
On Dec. 4, 2013, 12:22 a.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15964/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2013, 12:22 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1156
> https://issues.apache.org/jira/browse/KAFKA-1156
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Removed the option to output the entire cluster's current partition assignment, since it doesn't seem very relevant to the generate option
>
>
> Included Jun's review suggestions
>
>
> Found and fixed a bug during partition reassignment if a partition is being reassigned to the same set of replicas repeatedly
>
>
> Improved the partition reassignment tool to - 1) Output the previous partition replica assignment before kicking off the new assignment, to help with rollback 2) Have 3 options - generate, verify, execute 3) Cleaned up tool to use the 3 options properly
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 70d1b81f7dab2b3316af77738d682427d668be14
> core/src/main/scala/kafka/controller/KafkaController.scala 4c319aba97655e7c4ec97fac2e34de4e28c9f5d3
>
> Diff: https://reviews.apache.org/r/15964/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 15964: Patch for KAFKA-1156
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15964/
-----------------------------------------------------------
(Updated Dec. 4, 2013, 12:22 a.m.)
Review request for kafka.
Bugs: KAFKA-1156
https://issues.apache.org/jira/browse/KAFKA-1156
Repository: kafka
Description (updated)
-------
Removed the option to output the entire cluster's current partition assignment, since it doesn't seem very relevant to the generate option
Included Jun's review suggestions
Found and fixed a bug during partition reassignment if a partition is being reassigned to the same set of replicas repeatedly
Improved the partition reassignment tool to - 1) Output the previous partition replica assignment before kicking off the new assignment, to help with rollback 2) Have 3 options - generate, verify, execute 3) Cleaned up tool to use the 3 options properly
Diffs (updated)
-----
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 70d1b81f7dab2b3316af77738d682427d668be14
core/src/main/scala/kafka/controller/KafkaController.scala 4c319aba97655e7c4ec97fac2e34de4e28c9f5d3
Diff: https://reviews.apache.org/r/15964/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 15964: Patch for KAFKA-1156
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15964/
-----------------------------------------------------------
(Updated Dec. 4, 2013, 12:20 a.m.)
Review request for kafka.
Bugs: KAFKA-1156
https://issues.apache.org/jira/browse/KAFKA-1156
Repository: kafka
Description (updated)
-------
Included Jun's review suggestions
Found and fixed a bug during partition reassignment if a partition is being reassigned to the same set of replicas repeatedly
Improved the partition reassignment tool to - 1) Output the previous partition replica assignment before kicking off the new assignment, to help with rollback 2) Have 3 options - generate, verify, execute 3) Cleaned up tool to use the 3 options properly
Diffs (updated)
-----
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 70d1b81f7dab2b3316af77738d682427d668be14
core/src/main/scala/kafka/controller/KafkaController.scala 4c319aba97655e7c4ec97fac2e34de4e28c9f5d3
Diff: https://reviews.apache.org/r/15964/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 15964: Patch for KAFKA-1156
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15964/
-----------------------------------------------------------
(Updated Dec. 3, 2013, 6:21 p.m.)
Review request for kafka.
Bugs: KAFKA-1156
https://issues.apache.org/jira/browse/KAFKA-1156
Repository: kafka
Description (updated)
-------
Found and fixed a bug during partition reassignment if a partition is being reassigned to the same set of replicas repeatedly
Improved the partition reassignment tool to - 1) Output the previous partition replica assignment before kicking off the new assignment, to help with rollback 2) Have 3 options - generate, verify, execute 3) Cleaned up tool to use the 3 options properly
Diffs (updated)
-----
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 70d1b81f7dab2b3316af77738d682427d668be14
core/src/main/scala/kafka/controller/KafkaController.scala 4c319aba97655e7c4ec97fac2e34de4e28c9f5d3
Diff: https://reviews.apache.org/r/15964/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 15964: Patch for KAFKA-1156
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15964/
-----------------------------------------------------------
(Updated Dec. 3, 2013, 2:37 p.m.)
Review request for kafka.
Bugs: KAFKA-1156
https://issues.apache.org/jira/browse/KAFKA-1156
Repository: kafka
Description (updated)
-------
Improved the partition reassignment tool to - 1) Output the previous partition replica assignment before kicking off the new assignment, to help with rollback 2) Have 3 options - generate, verify, execute 3) Cleaned up tool to use the 3 options properly
Will update the wiki once the patch is reviewed
Diffs
-----
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 70d1b81f7dab2b3316af77738d682427d668be14
Diff: https://reviews.apache.org/r/15964/diff/
Testing
-------
Thanks,
Neha Narkhede