You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Benedikt Ritter (Created) (JIRA)" <ji...@apache.org> on 2012/02/07 17:12:59 UTC
[jira] [Created] (SANDBOX-389) [BeanUtils2] Implement populate() on
DefaultBeanAccessor
[BeanUtils2] Implement populate() on DefaultBeanAccessor
---------------------------------------------------------
Key: SANDBOX-389
URL: https://issues.apache.org/jira/browse/SANDBOX-389
Project: Commons Sandbox
Issue Type: Improvement
Components: BeanUtils2
Affects Versions: Nightly Builds
Reporter: Benedikt Ritter
Implement {{populate()}} as discussed on the ML (see http://markmail.org/thread/niv47muvrms56pqr)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (SANDBOX-389) [BeanUtils2] Implement
populate() on DefaultBeanAccessor
Posted by "Benedikt Ritter (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205386#comment-13205386 ]
Benedikt Ritter edited comment on SANDBOX-389 at 2/10/12 12:13 PM:
-------------------------------------------------------------------
I finally got the time to review and fix my patch. I re-implemented {{equals()}} on {{TestBean}} using commons lang 3. Commons lang 3.1 has been added as a dependency in test scope to pom.xml.
Now everything should be fine with {{populate()}}.
Regards,
Benedikt
was (Author: britter):
I finally got the time to review and fix my patch. I re-implemented {{equals()}} on {{TestBean}} using commons lang 3. Commons lang 3.1 has been added as a dependency in test scope to pom.xml.
Now everything should be fine with {{populate}()}.
Regards,
Benedikt
> [BeanUtils2] Implement populate() on DefaultBeanAccessor
> ---------------------------------------------------------
>
> Key: SANDBOX-389
> URL: https://issues.apache.org/jira/browse/SANDBOX-389
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Attachments: SANDBOX-389.txt, SANDBOX-389v2.txt
>
>
> Implement {{populate()}} as discussed on the ML (see http://markmail.org/thread/niv47muvrms56pqr)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SANDBOX-389) [BeanUtils2] Implement populate()
on DefaultBeanAccessor
Posted by "Benedikt Ritter (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202616#comment-13202616 ]
Benedikt Ritter commented on SANDBOX-389:
-----------------------------------------
I've just realized, that I have made the dumbest mistake in the implementation of {{equals()}}. Please hold on, until I've corrected that.
> [BeanUtils2] Implement populate() on DefaultBeanAccessor
> ---------------------------------------------------------
>
> Key: SANDBOX-389
> URL: https://issues.apache.org/jira/browse/SANDBOX-389
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Attachments: SANDBOX-389.txt
>
>
> Implement {{populate()}} as discussed on the ML (see http://markmail.org/thread/niv47muvrms56pqr)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SANDBOX-389) [BeanUtils2] Implement populate() on
DefaultBeanAccessor
Posted by "Benedikt Ritter (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benedikt Ritter updated SANDBOX-389:
------------------------------------
Attachment: SANDBOX-389.txt
I've attached a patch:
* Implemented {{populate()}} on {{DefaultBeanAccessor}} as discussed
** passing null will result in {{NullPointerException}}
** null keys will be ignored
** null values will be accepted for non primitive properties
** null values will raise a {{IllegalArgumentAcception}} for primitive properties
** values for properties that are read only will be ignored
** unknown keys will be ignored
* Added throws declaration to {{BeanAccessor}} interface
* Added {{equals()}} to TestBean for testing purpose (will be useful for {{clone()}} as well)
> [BeanUtils2] Implement populate() on DefaultBeanAccessor
> ---------------------------------------------------------
>
> Key: SANDBOX-389
> URL: https://issues.apache.org/jira/browse/SANDBOX-389
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Attachments: SANDBOX-389.txt
>
>
> Implement {{populate()}} as discussed on the ML (see http://markmail.org/thread/niv47muvrms56pqr)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SANDBOX-389) [BeanUtils2] Implement populate()
on DefaultBeanAccessor
Posted by "Simone Tripodi (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simone Tripodi resolved SANDBOX-389.
------------------------------------
Resolution: Fixed
Assignee: Simone Tripodi
Patch applied, see [r1243720|http://svn.apache.org/viewvc?rev=1243720&view=rev] but please:
* pay attention on new files where license header is located, its proper location is {{before}} the import statements
* inverted logic in {{continue}} statements;
* *NO TABS* in pom XML;
* why did you think putting the {{commons-lang}} version as property would be a benefit?
> [BeanUtils2] Implement populate() on DefaultBeanAccessor
> ---------------------------------------------------------
>
> Key: SANDBOX-389
> URL: https://issues.apache.org/jira/browse/SANDBOX-389
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Assignee: Simone Tripodi
> Attachments: SANDBOX-389.txt, SANDBOX-389v2.txt
>
>
> Implement {{populate()}} as discussed on the ML (see http://markmail.org/thread/niv47muvrms56pqr)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SANDBOX-389) [BeanUtils2] Implement populate() on
DefaultBeanAccessor
Posted by "Benedikt Ritter (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benedikt Ritter updated SANDBOX-389:
------------------------------------
Attachment: SANDBOX-389v2.txt
I finally got the time to review and fix my patch. I re-implemented {{equals()}} on {{TestBean}} using commons lang 3. Commons lang 3.1 has been added as a dependency in test scope to pom.xml.
Now everything should be fine with {{populate}()}.
Regards,
Benedikt
> [BeanUtils2] Implement populate() on DefaultBeanAccessor
> ---------------------------------------------------------
>
> Key: SANDBOX-389
> URL: https://issues.apache.org/jira/browse/SANDBOX-389
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Attachments: SANDBOX-389.txt, SANDBOX-389v2.txt
>
>
> Implement {{populate()}} as discussed on the ML (see http://markmail.org/thread/niv47muvrms56pqr)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira