You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Roster (Jira)" <ji...@apache.org> on 2020/03/01 09:03:00 UTC

[jira] [Commented] (AIRFLOW-4547) Negative priority_weight should not be permitted

    [ https://issues.apache.org/jira/browse/AIRFLOW-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048501#comment-17048501 ] 

Roster commented on AIRFLOW-4547:
---------------------------------

[~alexabraham] your scenario is specific to your needs. I work with negative weights and it's perfect for me.

I think tough there can be a solution to satisfy everyone. Allowing in airflow.cfg to config max_priority_weight and min_priority_weight that way any one can config it according to his own needs. The default can be unlimited for each one so it will be backward compatible.

> Negative priority_weight should not be permitted
> ------------------------------------------------
>
>                 Key: AIRFLOW-4547
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4547
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: operators
>    Affects Versions: 1.10.3
>            Reporter: Teresa Martyny
>            Priority: Major
>             Fix For: 2.0.0
>
>
> Airflow allows a dev to assign a negative priority_weight to a task. However, the Airflow code does math to determine the priority_weight on its own in models.py#priority_weight_total on line 2796
> This makes the final priority_weight wrong in the end. Airflow should raise an error if an operator has priority_weight assigned to a negative number at any point. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)