You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/09 13:08:56 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #504: Fix nxstyle
complants
yamt opened a new pull request #504: Fix nxstyle complants
URL: https://github.com/apache/incubator-nuttx/pull/504
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #504: Fix nxstyle
complants
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #504: Fix nxstyle complants
URL: https://github.com/apache/incubator-nuttx/pull/504#issuecomment-596568519
> do you disagree?
No, I don't disagree at all. This situation is this:
- It is and "undocumented" convention to indent all such compound statement by only two spaces. It is like this in all files.
- This is not documented clearly in the coding standard. That is probably an oversight. This is not addressed at all in the coding standard except under https://cwiki.apache.org/confluence/display/NUTTX/Coding+Standard#indentation where it says that the first level of indentation is 2-spaces.
- I don't think there is anything wrong with changing that convention. It certainly simplified nxstyle.
I am not opposed so there no reason to argue with me. I would just like to get the opinion and consenus of others.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #504: Fix nxstyle
complants
Posted by GitBox <gi...@apache.org>.
jerpelea commented on issue #504: Fix nxstyle complants
URL: https://github.com/apache/incubator-nuttx/pull/504#issuecomment-596569555
I am for simplifying the convention and making it easy to understand
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #504: Fix nxstyle
complants
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #504: Fix nxstyle complants
URL: https://github.com/apache/incubator-nuttx/pull/504
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea edited a comment on issue #504: Fix
nxstyle complants
Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on issue #504: Fix nxstyle complants
URL: https://github.com/apache/incubator-nuttx/pull/504#issuecomment-596569555
I think that we should simplify the convention and make it easy to understand
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #504: Fix nxstyle
complants
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #504: Fix nxstyle complants
URL: https://github.com/apache/incubator-nuttx/pull/504#issuecomment-596578632
I think the change seems reasonable, but should be documented in the coding standard.
I see no reason to hold this up. Having one concurrence is enough to assure that this is not just the personal opinion of KAMT or me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #504: Fix nxstyle
complants
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #504: Fix nxstyle complants
URL: https://github.com/apache/incubator-nuttx/pull/504#issuecomment-596543107
nxstyle told me this.
and i couldn't find any counter-explanations in NuttXCCodingStandard.html.
so i thought it should be.
do you disagree?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #504: Fix nxstyle
complants
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #504: Fix nxstyle complants
URL: https://github.com/apache/incubator-nuttx/pull/504#issuecomment-596539886
What say you all... should we indent these kinds of changes by 4 spaces instead of the usual 2?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services