You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/02/08 08:06:52 UTC
[GitHub] codecov-io commented on issue #279: SCB-336 1.add ut about find instance with tag 2.optimize find api
codecov-io commented on issue #279: SCB-336 1.add ut about find instance with tag 2.optimize find api
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/279#issuecomment-364032781
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=h1) Report
> Merging [#279](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/268cba27f2ee6ff533ea94de12833c3052b1206d?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `96%`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #279 +/- ##
==========================================
- Coverage 70.39% 70.34% -0.05%
==========================================
Files 17 17
Lines 3418 3416 -2
==========================================
- Hits 2406 2403 -3
Misses 846 846
- Partials 166 167 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=tree) | Coverage ? | |
|---|---|---|
| [server/service/util/rule\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9ydWxlX3V0aWwuZ28=) | `68.24% <100%> (-0.22%)` | :arrow_down: |
| [server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv) | `71.07% <66.66%> (-0.05%)` | :arrow_down: |
| [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `75.43% <0%> (-0.59%)` | :arrow_down: |
| [server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv) | `57.58% <0%> (-0.17%)` | :arrow_down: |
| [server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==) | `77.25% <0%> (+0.42%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `? = absolute <relative> (impact)`, `? = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=footer). Last update [268cba2...7b7d403](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services